Skip to content

Commit 2b483d9

Browse files
committed
bugfix/port configuration
Former-commit-id: e2131d5
1 parent f7af2ed commit 2b483d9

7 files changed

Lines changed: 1259 additions & 6 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<groupId>berlin.yuna</groupId>
1414
<artifactId>nats-streaming-server-embedded</artifactId>
15-
<version>0.4.2</version>
15+
<version>0.4.3</version>
1616
<packaging>jar</packaging>
1717

1818
<name>${project.artifactId}</name>

src/main/java/berlin/yuna/natsserver/annotation/EnableNatsServerContextCustomizer.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public void customizeContext(ConfigurableApplicationContext context, MergedConte
5050
}
5151

5252
NatsServer natsServerBean = new NatsServer(enableNatsServer.natsServerConfig());
53+
natsServerBean.port(overwritePort(natsServerBean));
5354
String sourceUrl = environment.getProperty("nats.source.default");
5455
natsServerBean.source(isEmpty(sourceUrl) ? natsServerBean.source() : sourceUrl);
5556
natsServerBean.setNatsServerConfig(mergeConfig(environment, natsServerBean.getNatsServerConfig()));
@@ -66,6 +67,10 @@ public void customizeContext(ConfigurableApplicationContext context, MergedConte
6667
((DefaultSingletonBeanRegistry) beanFactory).registerDisposableBean(NatsServer.BEAN_NAME, natsServerBean);
6768
}
6869

70+
private int overwritePort(NatsServer natsServerBean) {
71+
return enableNatsServer.port() != (Integer) NatsServerConfig.PORT.getDefaultValue() ? enableNatsServer.port() : natsServerBean.port();
72+
}
73+
6974
private Map<NatsServerConfig, String> mergeConfig(final ConfigurableEnvironment environment, final Map<NatsServerConfig, String> originalConfig) {
7075
Map<NatsServerConfig, String> mergedConfig = new HashMap<>(originalConfig);
7176
for (NatsServerConfig natsServerConfig : NatsServerConfig.values()) {

src/main/java/berlin/yuna/natsserver/logic/NatsServer.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import static berlin.yuna.natsserver.config.NatsServerConfig.PORT;
3030
import static berlin.yuna.system.logic.SystemUtil.OperatingSystem.WINDOWS;
3131
import static berlin.yuna.system.logic.SystemUtil.getOsType;
32+
import static berlin.yuna.system.logic.SystemUtil.killProcessByName;
3233
import static java.nio.channels.Channels.newChannel;
3334
import static java.nio.file.attribute.PosixFilePermission.OTHERS_EXECUTE;
3435
import static java.nio.file.attribute.PosixFilePermission.OTHERS_READ;
@@ -173,9 +174,10 @@ public NatsServer start() throws IOException {
173174
public NatsServer stop() {
174175
try {
175176
LOG.info("Stopping [{}]", BEAN_NAME);
177+
// Runtime.getRuntime().addShutdownHook(new Thread(() -> process.destroy()));
178+
// killProcessByName(getNatsServerPath(OPERATING_SYSTEM).getFileName().toString());
176179
process.destroy();
177180
process.waitFor();
178-
// killProcessByName(getNatsServerPath(OPERATING_SYSTEM).getFileName().toString());
179181
} catch (NullPointerException | InterruptedException e) {
180182
LOG.warn("Could not stop [{}] cause cant find process", BEAN_NAME);
181183
} finally {

0 commit comments

Comments
 (0)