Merge pull request #1 from YuxinZhaozyx/dev

feature: add unregister and is_registered to Registry.

Author: YuxinZhaozyx

easycore/common/registry/registry.py

@@ -88,6 +88,29 @@ def decorator(func_or_class:object) -> object:
             name = obj.__name__
         self._do_register(name, obj)
 
+    def unregister(self, name:str) -> None:
+        """
+        Remove registered object.
+
+        Args:
+            name (str): registered name
+        """
+        if name not in self._obj_map:
+            raise KeyError("An object named '{}' isn't registered in '{}' registry.".format(name, self._name))
+        else:
+            del self._obj_map[name]
+
+    def is_registered(self, name):
+        """
+        Get whether the given name has been registered.
+
+        Args:
+            name (str):
+
+        Returns:
+            bool: whether the name has been registered. 
+        """
+        return name in self._obj_map
 
     def get(self, name:str) -> object:
         """

easycore/torch/parallel/engine.py

@@ -46,7 +46,7 @@ def __init__(self,
                      init_func,
                      work_func,
                      end_func):
-            super(BaseRunner._Consumer, self).__init__()
+            super(BaseRunner._Consumer, self).__init__(daemon=True)
             self.receive_func = receive_func
             self.input_queue = input_queue
             self.output_queue = output_queue

test/registry/test_registry.py

@@ -53,4 +53,17 @@ def C():
 
     registered_names = FUNC_REGISTRY.registered_names()
     assert set(registered_names) == set(['A', 'B', 'C', 'D'])
-    
+
+def test_unregister():
+    REGISTRY = Registry("test")
+
+    assert REGISTRY.is_registered('obj') == False
+
+    REGISTRY.register('obj', ["hello world"])
+
+    assert REGISTRY.is_registered('obj') == True
+
+    REGISTRY.unregister('obj')
+
+    assert REGISTRY.is_registered('obj') == False
+