Refined useEffectOnce to solely act as an alias for React.useEffect(effect, [||]).
#600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the `useEffectOnce` hook.
…t(effect, [||])`, removing logic dependent on double effect invocation in `React.StrictMode` which led to bugs in `IDisposable` overloads.
|
Hello! I somewhat agree with the changes proposed here. Today, while revivifing the test suit, i noticed that the test about useEffect were failing in some cases #655. I added referenced to this PR and the relevant issue to #655 and will resolve this after updating to the jsx output as suggested by Maxime. Are you willing to rebase the PR when the project restructure is more advanced? Otherwise i will just implement the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #595