Generation of nullable required property

[christoph-feb22]

Hi Zaid,

I have an API definition which contains a model with an required property with the datatype nullable string.
Hawaii generates the type as string. I expect it to be a string option.

Hawaii/src/OperationParameters.fs

Line 138 in 9b117d2

required = parameter.Required || not nullable

As I understand it correct, this line is responsible if a type is optional or not.
Maybe the following replacement is an option?

parameter.Required && not nullable

Maybe there is an reason for only checking the required property?

Thanks in advance.

[Zaid-Ajaj]

Hi there @christoph-feb22, thanks for filing the issue!

I believe the reason the generated type is string and not string option is because when you use None as the value for your property, Fable generates undefined which is then removed from the serialized JSON AFAIK but I would need to double check this.

If the generated type is string and it is nullable, you can simply use null for the value at runtime, right?