Ledgerlens-core/tests/test_evm_address_validation.py at main · Zalgia-Saga/Ledgerlens-core · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
"""Tests for EVM address validation (checksum, malformed rejection, config validation)."""

import pytest
from web3 import Web3


# ---------------------------------------------------------------------------
# (a) Non-checksummed EVM address is converted on ingest
# ---------------------------------------------------------------------------


def test_non_checksummed_address_converted_on_ingest():
    """EVMTradeLoader.pool_addresses converts lowercase addresses to checksum form."""
    from ingestion.evm_loader import EVMTradeLoader

    lowercase = "0xab5801a7d398351b8be11c439e05c5b3259aec9b"
    checksummed = "0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B"

    loader = EVMTradeLoader(
        chain="ethereum",
        rpc_url="https://mock.example.com",
        pool_addresses=[lowercase],
    )
    assert loader.pool_addresses == [checksummed]
    assert Web3.is_checksum_address(loader.pool_addresses[0])


def test_mixed_case_address_accepted():
    """A correctly-checksummed address passes validation unchanged."""
    from ingestion.evm_loader import EVMTradeLoader

    checksummed = "0xCBCdF9626bC03E24f779434178A73a0B4bad62eD"
    loader = EVMTradeLoader(
        chain="ethereum",
        rpc_url="https://mock.example.com",
        pool_addresses=[checksummed],
    )
    assert loader.pool_addresses == [checksummed]


# ---------------------------------------------------------------------------
# (b) Malformed address raises ValueError
# ---------------------------------------------------------------------------


def test_malformed_address_raises_value_error():
    """An address that is not a 42-char hex string raises ValueError on ingest."""
    from ingestion.evm_loader import EVMTradeLoader

    with pytest.raises(ValueError, match="Malformed"):
        EVMTradeLoader(
            chain="ethereum",
            rpc_url="https://mock.example.com",
            pool_addresses=["not-an-address"],
        )


def test_too_short_address_raises_value_error():
    """A hex string shorter than 42 characters raises ValueError."""
    from ingestion.evm_loader import EVMTradeLoader

    with pytest.raises(ValueError):
        EVMTradeLoader(
            chain="ethereum",
            rpc_url="https://mock.example.com",
            pool_addresses=["0xABCDEF"],
        )


def test_address_without_0x_prefix_raises():
    """An address lacking the '0x' prefix raises ValueError."""
    from ingestion.evm_loader import EVMTradeLoader

    with pytest.raises(ValueError):
        EVMTradeLoader(
            chain="ethereum",
            rpc_url="https://mock.example.com",
            pool_addresses=["ab5801a7d398351b8be11c439e05c5b3259aec9b"],
        )


# ---------------------------------------------------------------------------
# (c) EVM_POOL_ADDRESSES with invalid address fails at Settings.__post_init__()
# ---------------------------------------------------------------------------


def test_settings_rejects_invalid_pool_address(monkeypatch):
    """Settings raises ValueError at construction when EVM_POOL_ADDRESSES has bad data."""
    monkeypatch.setenv("EVM_POOL_ADDRESSES", "not-a-valid-address")
    from config.settings import Settings
    with pytest.raises(ValueError):
        Settings()


def test_settings_rejects_non_checksummed_pool_address(monkeypatch):
    """Settings raises ValueError when EVM_POOL_ADDRESSES contains a lowercase address."""
    monkeypatch.setenv(
        "EVM_POOL_ADDRESSES",
        "0xab5801a7d398351b8be11c439e05c5b3259aec9b",  # not checksummed
    )
    from config.settings import Settings
    with pytest.raises(ValueError, match="non-checksummed"):
        Settings()


def test_settings_accepts_valid_checksummed_pool_address(monkeypatch):
    """Settings accepts a valid checksummed EVM address in EVM_POOL_ADDRESSES."""
    monkeypatch.setenv(
        "EVM_POOL_ADDRESSES",
        "0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B",
    )
    from config.settings import Settings
    s = Settings()
    assert "0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B" in s.evm_pool_addresses


def test_settings_accepts_empty_pool_addresses(monkeypatch):
    """Empty EVM_POOL_ADDRESSES (default) is valid — no validation error."""
    monkeypatch.delenv("EVM_POOL_ADDRESSES", raising=False)
    from config.settings import Settings
    s = Settings()
    assert s.evm_pool_addresses == ""


# ---------------------------------------------------------------------------
# EVM address checksum utility
# ---------------------------------------------------------------------------


def test_web3_checksum_round_trip():
    """to_checksum_address is idempotent on already-checksummed addresses."""
    addr = "0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B"
    assert Web3.to_checksum_address(addr) == addr
    assert Web3.is_checksum_address(addr)


def test_web3_checksum_upcases_lowercase():
    """to_checksum_address produces a valid checksum from all-lowercase."""
    lower = "0xab5801a7d398351b8be11c439e05c5b3259aec9b"
    checksummed = Web3.to_checksum_address(lower)
    assert Web3.is_checksum_address(checksummed)
    assert checksummed != lower