Commit 2e5d6bb
committed
fix(client): add run_forever()+stop() to ZhubConnection and ZhubExposure
run_forever() was referenced in the module docstring and the publish()
docstring but never implemented — any user following the quickstart
got AttributeError before a connection was even attempted.
ZhubConnection and ZhubExposure also lacked stop(), making them
impossible to shut down cleanly without touching private _task/_stop_event.
Add async run_forever() to all three classes (awaits _stop_event, unblocks
when stop() is called). Add stop() to ZhubConnection and ZhubExposure
mirroring ZhubPublication.stop(). Fix the __init__.py quickstart to use
the correct asyncio.run(main()) + await pub.run_forever() pattern.
Update the publish() docstring to describe the auto-start behaviour.1 parent cf34f87 commit 2e5d6bb
2 files changed
Lines changed: 54 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
| 36 | + | |
32 | 37 | | |
33 | 38 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
42 | 50 | | |
43 | 51 | | |
44 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
115 | 121 | | |
116 | 122 | | |
117 | 123 | | |
| |||
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
132 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
133 | 143 | | |
134 | 144 | | |
135 | 145 | | |
| |||
481 | 491 | | |
482 | 492 | | |
483 | 493 | | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
484 | 504 | | |
485 | 505 | | |
486 | 506 | | |
| |||
616 | 636 | | |
617 | 637 | | |
618 | 638 | | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
619 | 649 | | |
620 | 650 | | |
621 | 651 | | |
| |||
0 commit comments