|
| 1 | +"""Sign + verify round-trip and tamper detection (unit tests). |
| 2 | +End-to-end signed-publish tests live at the bottom and need fastapi/uvicorn.""" |
| 3 | + |
| 4 | +import pytest |
| 5 | + |
| 6 | +from zhub.signing import ( |
| 7 | + generate_keypair, sign_manifest, verify_manifest, public_key_from_private, |
| 8 | +) |
| 9 | + |
| 10 | + |
| 11 | +def _example_manifest() -> dict: |
| 12 | + return { |
| 13 | + "schema_version": "0.1", |
| 14 | + "name": "zai", |
| 15 | + "description": "father's autonomous AI", |
| 16 | + "accepts": "openai-v1-chat-completions", |
| 17 | + "auth": {"type": "bearer"}, |
| 18 | + "rate_limit": "60/min", |
| 19 | + "capabilities": [{"name": "chat", "description": "x"}], |
| 20 | + "public": True, |
| 21 | + "operator": "zawwar", |
| 22 | + "contact": "", |
| 23 | + "extensions": {}, |
| 24 | + } |
| 25 | + |
| 26 | + |
| 27 | +def test_sign_then_verify_succeeds(): |
| 28 | + sk, pk = generate_keypair() |
| 29 | + signed = sign_manifest(_example_manifest(), sk) |
| 30 | + assert "signature" in signed |
| 31 | + assert "public_key" in signed |
| 32 | + assert signed["public_key"] == pk |
| 33 | + assert verify_manifest(signed) is True |
| 34 | + |
| 35 | + |
| 36 | +def test_tamper_detection_changes_field(): |
| 37 | + sk, _ = generate_keypair() |
| 38 | + signed = sign_manifest(_example_manifest(), sk) |
| 39 | + signed["description"] = "TAMPERED" |
| 40 | + assert verify_manifest(signed) is False |
| 41 | + |
| 42 | + |
| 43 | +def test_tamper_detection_changes_signature(): |
| 44 | + sk, _ = generate_keypair() |
| 45 | + signed = sign_manifest(_example_manifest(), sk) |
| 46 | + signed["signature"] = "00" * 64 |
| 47 | + assert verify_manifest(signed) is False |
| 48 | + |
| 49 | + |
| 50 | +def test_missing_signature_fails_verify(): |
| 51 | + m = _example_manifest() |
| 52 | + assert verify_manifest(m) is False |
| 53 | + |
| 54 | + |
| 55 | +def test_public_key_from_private_matches_keypair(): |
| 56 | + sk, pk = generate_keypair() |
| 57 | + assert public_key_from_private(sk) == pk |
| 58 | + |
| 59 | + |
| 60 | +def test_two_different_keys_produce_different_signatures(): |
| 61 | + sk1, _ = generate_keypair() |
| 62 | + sk2, _ = generate_keypair() |
| 63 | + a = sign_manifest(_example_manifest(), sk1) |
| 64 | + b = sign_manifest(_example_manifest(), sk2) |
| 65 | + assert a["signature"] != b["signature"] |
| 66 | + assert a["public_key"] != b["public_key"] |
| 67 | + |
| 68 | + |
| 69 | +def test_resigning_replaces_signature_idempotent(): |
| 70 | + sk, _ = generate_keypair() |
| 71 | + signed_once = sign_manifest(_example_manifest(), sk) |
| 72 | + signed_twice = sign_manifest(signed_once, sk) |
| 73 | + # Same content + same key → same signature (ed25519 is deterministic) |
| 74 | + assert signed_twice["signature"] == signed_once["signature"] |
| 75 | + |
| 76 | + |
| 77 | +def test_swapped_public_key_with_intact_signature_fails(): |
| 78 | + """Even if signature bytes are kept, swapping public_key invalidates the |
| 79 | + signed payload (since public_key IS part of what's signed).""" |
| 80 | + sk1, _ = generate_keypair() |
| 81 | + _, pk2 = generate_keypair() |
| 82 | + signed = sign_manifest(_example_manifest(), sk1) |
| 83 | + signed["public_key"] = pk2 # swap the claimed key |
| 84 | + assert verify_manifest(signed) is False |
| 85 | + |
| 86 | + |
| 87 | +# ---- end-to-end (needs hub) --------------------------------------------- |
| 88 | + |
| 89 | +import asyncio |
| 90 | +import socket |
| 91 | +import threading |
| 92 | +import time |
| 93 | + |
| 94 | +try: |
| 95 | + import fastapi # noqa |
| 96 | + import uvicorn # noqa |
| 97 | + SERVER_AVAILABLE = True |
| 98 | +except ImportError: |
| 99 | + SERVER_AVAILABLE = False |
| 100 | + |
| 101 | +if SERVER_AVAILABLE: |
| 102 | + from zhub.server import create_app |
| 103 | +from zhub import publish |
| 104 | + |
| 105 | + |
| 106 | +def _free_port() -> int: |
| 107 | + with socket.socket() as s: |
| 108 | + s.bind(("", 0)) |
| 109 | + return s.getsockname()[1] |
| 110 | + |
| 111 | + |
| 112 | +@pytest.fixture(scope="module") |
| 113 | +def hub_port(): |
| 114 | + if not SERVER_AVAILABLE: |
| 115 | + pytest.skip("fastapi/uvicorn not installed") |
| 116 | + port = _free_port() |
| 117 | + |
| 118 | + def run(): |
| 119 | + config = uvicorn.Config(create_app(), host="127.0.0.1", port=port, log_level="warning") |
| 120 | + asyncio.run(uvicorn.Server(config).serve()) |
| 121 | + |
| 122 | + threading.Thread(target=run, daemon=True).start() |
| 123 | + for _ in range(30): |
| 124 | + try: |
| 125 | + with socket.create_connection(("127.0.0.1", port), timeout=0.1): |
| 126 | + break |
| 127 | + except OSError: |
| 128 | + time.sleep(0.1) |
| 129 | + yield port |
| 130 | + |
| 131 | + |
| 132 | +@pytest.mark.asyncio |
| 133 | +async def test_signed_publish_succeeds(hub_port): |
| 134 | + """A publisher with a private_key has its signed manifest accepted.""" |
| 135 | + sk, _pk = generate_keypair() |
| 136 | + pub = publish( |
| 137 | + name="signed-ai", |
| 138 | + description="signed test", |
| 139 | + chat_handler=lambda m, o: "ok", |
| 140 | + hub_url=f"ws://127.0.0.1:{hub_port}", |
| 141 | + private_key=sk, |
| 142 | + ) |
| 143 | + for _ in range(50): |
| 144 | + if pub.api_key: |
| 145 | + break |
| 146 | + await asyncio.sleep(0.1) |
| 147 | + assert pub.api_key, "signed manifest should register cleanly" |
| 148 | + |
| 149 | + |
| 150 | +@pytest.mark.asyncio |
| 151 | +async def test_signed_publish_with_tampered_signature_rejected(hub_port): |
| 152 | + """A manifest whose signature does not match its content is rejected.""" |
| 153 | + import zhub.signing as _signing |
| 154 | + real_sign = _signing.sign_manifest |
| 155 | + |
| 156 | + def mutating_sign(manifest, sk): |
| 157 | + out = real_sign(manifest, sk) |
| 158 | + out["signature"] = "00" * 64 # break the signature |
| 159 | + return out |
| 160 | + |
| 161 | + _signing.sign_manifest = mutating_sign |
| 162 | + try: |
| 163 | + sk, _ = generate_keypair() |
| 164 | + pub = publish( |
| 165 | + name="tampered", |
| 166 | + description="should fail", |
| 167 | + chat_handler=lambda m, o: "no", |
| 168 | + hub_url=f"ws://127.0.0.1:{hub_port}", |
| 169 | + private_key=sk, |
| 170 | + ) |
| 171 | + # Wait briefly — registration should fail and api_key stays empty. |
| 172 | + for _ in range(20): |
| 173 | + await asyncio.sleep(0.1) |
| 174 | + assert not pub.api_key, "tampered signature should not register" |
| 175 | + finally: |
| 176 | + _signing.sign_manifest = real_sign |
| 177 | + |
| 178 | + |
| 179 | +@pytest.mark.asyncio |
| 180 | +async def test_unsigned_publish_still_works(hub_port): |
| 181 | + """Backwards-compat: a manifest without a signature still registers |
| 182 | + (legacy v0 publishers don't sign).""" |
| 183 | + pub = publish( |
| 184 | + name="legacy", |
| 185 | + description="unsigned", |
| 186 | + chat_handler=lambda m, o: "ok", |
| 187 | + hub_url=f"ws://127.0.0.1:{hub_port}", |
| 188 | + # no private_key |
| 189 | + ) |
| 190 | + for _ in range(50): |
| 191 | + if pub.api_key: |
| 192 | + break |
| 193 | + await asyncio.sleep(0.1) |
| 194 | + assert pub.api_key, "unsigned manifest should still register (backwards compat)" |
0 commit comments