dont crash parsing a manifest with unknown fields

Author: Zawwarsami16

tests/test_manifest.py

@@ -29,3 +29,20 @@ def test_chat_only_helper():
     assert m.name == "test-ai"
     assert m.public is False
     assert any(c.name == "chat" for c in m.capabilities)
+
+
+def test_from_dict_ignores_unknown_fields():
+    # A manifest published by a newer schema version carries fields a v0.1
+    # reader doesn't know. Parsing it must degrade gracefully, not raise.
+    m = Manifest.from_dict({
+        "schema_version": "0.2",
+        "name": "future-ai",
+        "description": "from a newer hub",
+        "tags": ["vision", "beta"],
+        "capabilities": [
+            {"name": "chat", "description": "chat", "cost_per_token": 0.001},
+        ],
+    })
+    assert m.name == "future-ai"
+    assert m.schema_version == "0.2"
+    assert m.capabilities[0].name == "chat"

zhub/manifest.py

@@ -7,7 +7,7 @@
 
 from __future__ import annotations
 
-from dataclasses import dataclass, field, asdict
+from dataclasses import dataclass, field, asdict, fields
 from typing import Any, Optional
 import json
 
@@ -75,9 +75,19 @@ def to_json(self) -> str:
 
     @classmethod
     def from_dict(cls, data: dict[str, Any]) -> "Manifest":
-        caps_raw = data.get("capabilities", [])
-        caps = [Capability(**c) if isinstance(c, dict) else c for c in caps_raw]
-        kwargs = {k: v for k, v in data.items() if k != "capabilities"}
+        # Drop keys we don't know about instead of crashing. schema_version
+        # exists precisely so a newer hub can add fields; a v0.1 reader parsing
+        # a v0.2 manifest (or any extra top-level key) must degrade gracefully,
+        # not raise TypeError. Same for unknown keys on a capability.
+        cap_fields = {f.name for f in fields(Capability)}
+        caps = [
+            Capability(**{k: v for k, v in c.items() if k in cap_fields})
+            if isinstance(c, dict) else c
+            for c in data.get("capabilities", [])
+        ]
+        manifest_fields = {f.name for f in fields(cls)} - {"capabilities"}
+        kwargs = {k: v for k, v in data.items()
+                  if k in manifest_fields and k != "capabilities"}
         return cls(capabilities=caps, **kwargs)
 
     @classmethod