Skip to content

Commit 1178b1c

Browse files
[CI] Fix cache resolution and syntax in check binary size workflow (jaegertracing#2591)
## Which problem is this PR solving? - Resolves jaegertracing#2590 ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: chahatsagarmain <[email protected]>
1 parent 1ee19c2 commit 1178b1c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/check_bundle.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ jobs:
3939
with:
4040
path: bundle_size.txt
4141
key: jaeger-ui-bundle-size
42+
restore-keys: |
43+
jaeger-ui-bundle-size
4244
4345
- name: Compare bundle sizes
44-
if: steps.cache-bundle-size.outputs.cache-hit == 'true'
46+
if: steps.cache-bundle-size.outputs.cache-matched-key != ''
4547
run: |
4648
OLD_BUNDLE_SIZE=$(cat bundle_size.txt)
4749
NEW_BUNDLE_SIZE=$(cat new_bundle_size.txt)
@@ -62,8 +64,8 @@ jobs:
6264
run: mv new_bundle_size.txt bundle_size.txt
6365

6466
- name: Save new bundle size
65-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
67+
if: ${{ (github.event_name == 'push') && (github.ref == 'refs/heads/main') }}
6668
uses: actions/cache/save@v4
6769
with:
6870
path: bundle_size.txt
69-
key: jaeger-ui-bundle-size
71+
key: jaeger-ui-bundle-size-${{ github.run_id }}

0 commit comments

Comments
 (0)