Implement execute_proposal Function

[bitfalt]

Description

Implement the logic to execute a passed proposal. This function will iterate through the proposal's defined actions and execute them, such as calling the Treasury contract to transfer funds.
Acceptance Criteria:

1. The execute_proposal function is implemented.
2. The function includes the following checks (reverting if any fail):
   • The proposal's state must be Succeeded (i.e., voting has ended, quorum was met, and the passing threshold was reached).
   • The proposal must not have been executed already (check is_executed flag).
3. The function sets the is_executed flag to true to prevent re-entrancy and double execution.
4. The function iterates through the actions array stored in the Proposal struct.
5. For each action, it makes an external contract call using call_contract_syscall with the specified target address, function selector, and calldata.
6. A ProposalExecuted event is emitted with the proposal_id.

[OWK50GA]

Hi, I want to work on this issue.
I am a Cairo Smart Contract Dev, and I have experience with propsal-related implementations like this.

ETA - 24 hours

[anihdev]

Hi Gm I'm Ani Soma,
Im a smart contract developer with experience in Cairo, Solidity, TypeScript, Foundry. I've worked on several Smart contracts.

After reviewing the project documentation, task overview, requirements, I understand what this task requires and can go about it.

To implement the execute_proposal function, I’ll retriev the proposal details using the proposal_id. Ensuring the proposal has succeeded and the proposal passed. I’ll validate it hasn’t already been executed. If either condition isn’t met, the function will revert to prevent invalid execution. Once validated, I’ll set the is_executed to true. After all actions are executed, I’ll emit a ProposalExecuted event with the proposal_id to mark completion.

As stated, I'II also write comprehensive test cases to verify functionality in isolation and proper integration

ETA: less than 2 days
Looking forward to contributing to this project

[gelluisaac]

hi I'd like to implement the execute_proposal function with proper checks to ensure only successful, unexecuted proposals can be run. I will set the is_executed flag early to prevent re-entrancy, then iterate over the proposal’s actions. Each action will be executed using call_contract_syscall with its target, selector, and calldata. Finally, I’ll emit the ProposalExecuted event with the proposal ID.

[evgongora]

@OWK50GA Any updates on this?

[OWK50GA]

@evgongora
I sort of need the create_proposal done in order to do this.

[emarc99]

@bitfalt you got any issue for an OD fellow?

[Gerson2102]

---

Hey! I'm Gerson, a fellow from OnlyDust. 👋

Member of Dojo Coding. I have contributed before to other projects like:

• Raito
• kakarot-rpc
• Cairo Native
• ef-tests
• Madara
• kakarot-ssj
• starknet-phone
• starkiro
• Trustless-Work
• Giza

Check my OnlyDust profile, I've contributed to many projects: Profile

---

Plan to Solve the Issue:

1. Study the codebase to understand the current structure and functionality.
2. Understand the problem that needs to be solved by thoroughly reading the issue details.
3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
4. If I encounter roadblocks, I will ask questions ASAP in the Telegram group to move forward effectively.
5. I will open a PR and wait for your feedback

---

Recommended by OnlyDust for exceptional experience, quality, and reliability.

[Akinbola247]

i'd like to take on this issue