Commit 03543a3
committed
refactor(hu): abort leaked plugin tasks, harden config, drop legacy world
Address PR #236 review findings in crates/hiroz-union:
- Abort background tokio tasks on drop: add Drop impls that call
AbortHandle::abort() for subscription/raw-sub/liveliness/queryable/
rate-tracker state, and break the rate-tracker loop when the receiver
is gone. Prevents unbounded task accumulation across plugin reload.
- Share a single process-wide WASM engine (OnceLock) with one epoch
ticker for its lifetime, instead of spawning a fresh engine+ticker on
every load_plugins/load_plugin_named call.
- Escape untrusted manifest endpoints through serde_json when building
the connect/endpoints config array (was raw format! interpolation).
- Deduplicate load_plugins/load_plugin_named into a shared load_from.
- Replace the DispatchOutcome enum with Option<u32> and update callers.
- Remove the never-shipped v0.3 legacy hu-plugin alias world:
PluginBindings::Legacy, try_load_legacy, plugin-event variant, and the
tui_bindgen module (the top-level bindgen now targets hu-tui-plugin).
- Drop the deprecated --headless/--web CLI flags.1 parent 60d1a8e commit 03543a3
6 files changed
Lines changed: 116 additions & 214 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | 57 | | |
62 | 58 | | |
63 | 59 | | |
| |||
74 | 70 | | |
75 | 71 | | |
76 | 72 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 73 | | |
82 | 74 | | |
83 | 75 | | |
| |||
185 | 177 | | |
186 | 178 | | |
187 | 179 | | |
188 | | - | |
| 180 | + | |
189 | 181 | | |
190 | 182 | | |
191 | 183 | | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | 184 | | |
212 | 185 | | |
213 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
74 | | - | |
| 72 | + | |
75 | 73 | | |
76 | 74 | | |
77 | 75 | | |
| |||
91 | 89 | | |
92 | 90 | | |
93 | 91 | | |
94 | | - | |
| 92 | + | |
95 | 93 | | |
96 | 94 | | |
97 | 95 | | |
| |||
101 | 99 | | |
102 | 100 | | |
103 | 101 | | |
104 | | - | |
| 102 | + | |
105 | 103 | | |
106 | 104 | | |
107 | 105 | | |
108 | 106 | | |
109 | | - | |
| 107 | + | |
110 | 108 | | |
111 | 109 | | |
112 | 110 | | |
113 | 111 | | |
114 | 112 | | |
115 | 113 | | |
116 | | - | |
| 114 | + | |
117 | 115 | | |
118 | 116 | | |
119 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
13 | | - | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 36 | | |
54 | 37 | | |
55 | 38 | | |
| |||
0 commit comments