Commit 12a968a
committed
fix(node): bound the FFI advanced dispatch queue too
The conversion to dispatch_capacity covered three of four
CallbackDispatcher::spawn sites. node.rs's advanced (TransientLocal) arm
still passed DISPATCH_UNBOUNDED, so an FFI raw subscriber declaring
KeepLast(n) got an unbounded queue fed by remote samples -- the exact
defect the other three sites were changed to remove.
Two shipped doc comments and the PR description asserted 'both paths pass
dispatch_capacity'. There are four paths, and one did not.
Nothing caught it because the ffi feature is enabled by no crate, so this
arm is never compiled on the PR gate (#291). Found by an audit agent
reading the diff against its own description.1 parent 0d48f84 commit 12a968a
2 files changed
Lines changed: 15 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
642 | 642 | | |
643 | 643 | | |
644 | 644 | | |
645 | | - | |
| 645 | + | |
646 | 646 | | |
647 | 647 | | |
648 | 648 | | |
| |||
678 | 678 | | |
679 | 679 | | |
680 | 680 | | |
681 | | - | |
682 | | - | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
683 | 686 | | |
684 | 687 | | |
685 | 688 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
392 | 392 | | |
393 | 393 | | |
394 | 394 | | |
395 | | - | |
396 | | - | |
397 | | - | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
398 | 404 | | |
399 | 405 | | |
400 | 406 | | |
| |||
0 commit comments