test(rcl-z): final review

Author: YuanYuYuan

rcl-z/src/context.rs

@@ -163,14 +163,12 @@ pub extern "C" fn rcl_logging_configure_with_output_handler(
     RCL_RET_OK as _
 }
 
-// TODO: Not implemented yet
 #[unsafe(no_mangle)]
 pub extern "C" fn rcl_logging_rosout_enabled() -> bool {
     // Rosout logging is always enabled in our implementation
     true
 }
 
-// TODO: Not implemented yet
 #[unsafe(no_mangle)]
 pub extern "C" fn rcl_logging_rosout_init_publisher_for_node(
     _node: *mut rcl_node_t,
@@ -181,7 +179,6 @@ pub extern "C" fn rcl_logging_rosout_init_publisher_for_node(
     RCL_RET_OK as _
 }
 
-// TODO: Not implemented yet
 #[unsafe(no_mangle)]
 pub extern "C" fn rcl_logging_rosout_fini_publisher_for_node(
     _node: *mut rcl_node_t,

rcl-z/src/graph.rs

@@ -102,40 +102,6 @@ pub unsafe extern "C" fn rcl_names_and_types_init(
     RCL_RET_OK as _
 }
 
-// impl TryFrom<EndpointEntity> for rcl_names_and_types_t {
-//     type Error = NulError;
-//     fn try_from(value: EndpointEntity) -> Result<Self, Self::Error> {
-//     pub names: rcutils_string_array_t,
-//     pub types: *mut rcutils_string_array_t,
-//     }
-// }
-
-// impl<S> From<Vec<S>> for rcutils_string_array_t
-// where
-//     S: AsRef<str>,
-// {
-//     fn from(strings: Vec<S>) -> Self {
-//         let mut c_strings: Vec<*mut c_char> = strings
-//             .into_iter()
-//             .map(|s| {
-//                 CString::new(s.as_ref())
-//                     .expect("CString::new failed")
-//                     .into_raw()
-//             })
-//             .collect();
-//
-//         let len = c_strings.len();
-//         let ptr = c_strings.as_mut_ptr();
-//         std::mem::forget(c_strings);
-//
-//         Self {
-//             data: ptr,
-//             size: len,
-//             allocator: rcutils_allocator_t::default(),
-//         }
-//     }
-// }
-
 impl From<Vec<CString>> for rcutils_string_array_t {
     fn from(strings: Vec<CString>) -> Self {
         let mut c_strings: Vec<*mut c_char> = strings.into_iter().map(|s| s.into_raw()).collect();

rcl-z/src/utils.rs

@@ -48,23 +48,6 @@ impl Notifier {
     }
 }
 
-// pub struct DebugCStr(pub *const c_char);
-//
-// impl std::fmt::Debug for DebugCStr {
-//     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-//         unsafe {
-//             if self.0.is_null() {
-//                 write!(f, "null")
-//             } else {
-//                 match CStr::from_ptr(self.0).to_str() {
-//                     Ok(s) => write!(f, "{:?}", s),
-//                     Err(_) => write!(f, "invalid utf-8"),
-//                 }
-//             }
-//         }
-//     }
-// }
-
 #[macro_export]
 macro_rules! impl_has_impl_ptr {
     ($ctype:ty, $cimpl_type:ty, $impl_type:ty) => {

rcl-z/tests/test_events.rs

@@ -9,7 +9,7 @@ mod test_msgs_support;
 
 use std::ptr;
 
-// Dummy status structs since rcl-z doesn't support events
+// Status structs for event testing
 #[repr(C)]
 #[derive(Debug, Default, Clone)]
 pub struct rmw_offered_deadline_missed_status_t {