[Feature Request] Some idea to make this tool more interesting

[Gxiandy]

Hi ZhangGe,
This is an excellent work which help me a lot during my work.
I have been looking for a good visual model modification tool, and then I found that this tool may be able to meet my expectations. So I hope to contribute to this work to make it more interesting.

Here are some points I think could make this tool more useful:

1. A cleaner UI. The tool's UI is not as clean as native netron's. Actually I have pushed a PR([refactor]: Modify the UI of model related buttons #122) to achieve a better UI.
2. Support node coloring. User can change the color of selected node, this will need modification of netron.
3. Support selecting nodes and make some changes (delete/coloring...) to these nodes.
4. Support load&download of mlir model. Since MLIR has been the most popular ai compiler infrastructure, a model modification tool which can parse the IR of mlir will be very useful. I have developed some codes before to convert the mlir ir to onnx node and display it with netron, and also convert it back to mlir ir file.
5. Support adding a new node attribute.
6. Support inserting custom node.

• ......

I will be very glad if you are interested in my proposal. And I will be very happy to contribute to implement these ideas. Looking forward to you reply.

[ZhangGe6]

Hi @Gxiandy, thanks for the inspirational suggestions and efforts! I edited the comments with proposed points as an ordered list, and want to share my opinions for them respectively.

1. I tried the PR locally and found that the index page gets really cleaner! But maybe the PR will not be merged, mainly for two reasons: a) As netron focuses on visualization, the UI is expected to be as clean as possible. However, onnx-modifier focuses on model editing, so the interactive buttons should be reached as conveniently as possible. To this point, "hiding" the buttons in the menu dropdown will make users have to do one more click, and may not be a good idea. b) If the buttons are hidden, the demo gif in the readme should be updated together.
2. Yes! This is really a good idea! It can help users mark/locate the nodes they are interested in.
3. Deleting the selected nodes is already supported.
4. Good job! As I know, mlir support is still under active development in netron project. Waiting and reusing the feature may be the right direction. In addition, to keep focusing and things simple, onnx-modifer focuses on editing ONNX only.
5. Editing attribute is already supported. What is the real case to ADD a new attribute?
6. Yes! This is exactly what the community calls for.