fix: cache running apps to avoid repeated DispatchQueue.main.sync

Call getRunningApps() once at the top of each resolve() entry point
and pass the result through the entire call chain. This eliminates
multiple DispatchQueue.main.sync dispatches per resolve invocation —
findRunningBundleId, resolveViaTmuxClient, and resolveFromRunningApps
now accept an apps parameter instead of fetching independently.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZhaoChaoqun

ClaudeIsland/Services/Window/TerminalResolver.swift

@@ -42,6 +42,8 @@ struct TerminalResolver: Sendable {
 
     /// Resolve terminal using a pre-built process tree (avoids duplicate sysctl calls)
     nonisolated func resolve(claudePid: Int, tree: [Int: ProcessInfo]) -> ResolvedTerminal? {
+        // Fetch running apps once for the entire resolve chain (single DispatchQueue.main.sync)
+        let apps = Self.getRunningApps()
 
         // Check if in tmux
         let isInTmux = ProcessTreeBuilder.shared.isInTmux(pid: claudePid, tree: tree)
@@ -52,7 +54,7 @@ struct TerminalResolver: Sendable {
         // Walk up process tree to find terminal app
         if let appInfo = TerminalAppRegistry.appInfo(forPid: claudePid, tree: tree) {
             // Verify the app is actually running and get its bundle ID
-            if let bundleId = findRunningBundleId(for: appInfo) {
+            if let bundleId = findRunningBundleId(for: appInfo, apps: apps) {
                 return ResolvedTerminal(
                     appInfo: appInfo,
                     bundleId: bundleId,
@@ -65,24 +67,25 @@ struct TerminalResolver: Sendable {
         // If we're in tmux, the terminal might not be a direct parent.
         // Try to find it via tmux client PID.
         if isInTmux {
-            return resolveViaTmuxClient(claudePid: claudePid, tree: tree, tty: tty)
+            return resolveViaTmuxClient(claudePid: claudePid, tree: tree, tty: tty, apps: apps)
         }
 
         // Last resort: check running applications against known terminals
-        return resolveFromRunningApps(tty: tty)
+        return resolveFromRunningApps(tty: tty, apps: apps)
     }
 
     /// Resolve terminal using TTY (when PID is not available)
     nonisolated func resolve(tty: String) -> ResolvedTerminal? {
         // Parse TTY to find a PID associated with it
         let tree = ProcessTreeBuilder.shared.buildTree()
+        let apps = Self.getRunningApps()
 
         // Find processes on this TTY
         for (pid, info) in tree {
             guard let processTTY = info.tty else { continue }
             if tty.hasSuffix(processTTY) || processTTY == tty {
                 // Found a process on this TTY, resolve from here
-                if let resolved = resolveFromTree(pid: pid, tree: tree) {
+                if let resolved = resolveFromTree(pid: pid, tree: tree, apps: apps) {
                     return resolved
                 }
             }
@@ -94,12 +97,12 @@ struct TerminalResolver: Sendable {
     // MARK: - Private
 
     /// Walk up from a PID in a pre-built tree
-    private nonisolated func resolveFromTree(pid: Int, tree: [Int: ProcessInfo]) -> ResolvedTerminal? {
+    private nonisolated func resolveFromTree(pid: Int, tree: [Int: ProcessInfo], apps: [NSRunningApplication]) -> ResolvedTerminal? {
         let isInTmux = ProcessTreeBuilder.shared.isInTmux(pid: pid, tree: tree)
         let tty = findTTY(forPid: pid, tree: tree)
 
         if let appInfo = TerminalAppRegistry.appInfo(forPid: pid, tree: tree),
-           let bundleId = findRunningBundleId(for: appInfo) {
+           let bundleId = findRunningBundleId(for: appInfo, apps: apps) {
             return ResolvedTerminal(
                 appInfo: appInfo,
                 bundleId: bundleId,
@@ -112,7 +115,7 @@ struct TerminalResolver: Sendable {
     }
 
     /// Try to find the terminal via tmux client PID
-    private nonisolated func resolveViaTmuxClient(claudePid: Int, tree: [Int: ProcessInfo], tty: String?) -> ResolvedTerminal? {
+    private nonisolated func resolveViaTmuxClient(claudePid: Int, tree: [Int: ProcessInfo], tty: String?, apps: [NSRunningApplication]) -> ResolvedTerminal? {
         // Find tmux server in the parent chain
         var current = claudePid
         var depth = 0
@@ -139,7 +142,7 @@ struct TerminalResolver: Sendable {
 
             // Walk up from this client to find the terminal
             if let appInfo = TerminalAppRegistry.appInfo(forPid: pid, tree: tree),
-               let bundleId = findRunningBundleId(for: appInfo) {
+               let bundleId = findRunningBundleId(for: appInfo, apps: apps) {
                 return ResolvedTerminal(
                     appInfo: appInfo,
                     bundleId: bundleId,
@@ -155,11 +158,10 @@ struct TerminalResolver: Sendable {
     /// Fallback: check all running apps for known terminals.
     /// Only returns a result if exactly one terminal app is running,
     /// otherwise we can't determine which terminal owns this session.
-    private nonisolated func resolveFromRunningApps(tty: String? = nil) -> ResolvedTerminal? {
-        let runningApps = Self.getRunningApps()
+    private nonisolated func resolveFromRunningApps(tty: String? = nil, apps: [NSRunningApplication]) -> ResolvedTerminal? {
         var matches: [(appInfo: TerminalAppInfo, bundleId: String)] = []
 
-        for app in runningApps {
+        for app in apps {
             guard let bundleId = app.bundleIdentifier,
                   let appInfo = TerminalAppRegistry.appInfo(forBundleId: bundleId) else {
                 continue
@@ -181,10 +183,9 @@ struct TerminalResolver: Sendable {
     }
 
     /// Find the bundle ID of a running instance for a terminal app
-    private nonisolated func findRunningBundleId(for appInfo: TerminalAppInfo) -> String? {
-        let runningApps = Self.getRunningApps()
+    private nonisolated func findRunningBundleId(for appInfo: TerminalAppInfo, apps: [NSRunningApplication]) -> String? {
         for bundleId in appInfo.bundleIds {
-            if runningApps.contains(where: { $0.bundleIdentifier == bundleId }) {
+            if apps.contains(where: { $0.bundleIdentifier == bundleId }) {
                 return bundleId
             }
         }