Skip to content

Commit 18f4dfa

Browse files
zejiang0jasonaescolar
authored andcommitted
tests: counter: basic_api: relax counter_stop assertions
counter_stop() is not required to succeed on all hardware. Free-running counters (e.g. OS Timer) correctly return -ENOTSUP. Update the three call sites in the unit test to accept -ENOTSUP as a valid outcome. Signed-off-by: Jason Yu <zejiang.yu@nxp.com>
1 parent f88842e commit 18f4dfa

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

tests/drivers/counter/counter_basic_api/src/test_counter.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ static void counter_tear_down_instance(const struct device *dev)
256256
"%s: Setting top value to default failed", dev->name);
257257

258258
err = counter_stop(dev);
259-
zassert_equal(0, err, "%s: Counter failed to stop", dev->name);
259+
zassert_true((err == 0) || (err == -ENOTSUP),
260+
"%s: Counter failed to stop (err: %d)", dev->name, err);
260261

261262
}
262263

@@ -596,7 +597,8 @@ static void test_single_shot_alarm_instance(const struct device *dev, bool set_t
596597
"%s: Setting top value to default failed", dev->name);
597598

598599
err = counter_stop(dev);
599-
zassert_equal(0, err, "%s: Counter failed to stop", dev->name);
600+
zassert_true((err == 0) || (err == -ENOTSUP),
601+
"%s: Counter failed to stop (err: %d)", dev->name, err);
600602
}
601603

602604
void test_single_shot_alarm_notop_instance(const struct device *dev)
@@ -872,7 +874,8 @@ static void test_valid_function_without_alarm(const struct device *dev)
872874
zassert_true((ticks > 0), "%s: counter did not count", dev->name);
873875

874876
err = counter_stop(dev);
875-
zassert_equal(0, err, "%s: counter failed to stop", dev->name);
877+
zassert_true((err == 0) || (err == -ENOTSUP),
878+
"%s: counter failed to stop (err: %d)", dev->name, err);
876879
}
877880

878881
static bool ms_period_capable(const struct device *dev)

0 commit comments

Comments
 (0)