fixes

Author: Zibbp

internal/exec/exec.go

@@ -58,6 +58,29 @@ func appendFFmpegLiveOutputStreamArgs(args []string, audioOnly bool) []string {
 	)
 }
 
+func appendYtDlpVideoConfigArgs(args []string, configArgs string) []string {
+	skipValue := false
+	for _, arg := range strings.Split(configArgs, ",") {
+		trimmedArg := strings.TrimSpace(arg)
+		if skipValue {
+			skipValue = false
+			continue
+		}
+		if trimmedArg == "-o" || trimmedArg == "--output" || trimmedArg == "-P" || trimmedArg == "--paths" {
+			skipValue = true
+			continue
+		}
+		if strings.HasPrefix(trimmedArg, "--output=") || strings.HasPrefix(trimmedArg, "--paths=") ||
+			(len(trimmedArg) > 2 && (strings.HasPrefix(trimmedArg, "-o") || strings.HasPrefix(trimmedArg, "-P"))) {
+			continue
+		}
+		if trimmedArg != "" {
+			args = append(args, trimmedArg)
+		}
+	}
+	return args
+}
+
 func twitchVideoDownloadArgs(quality, url, outputPath, configArgs string) []string {
 	args := []string{
 		"-f", quality,
@@ -72,14 +95,9 @@ func twitchVideoDownloadArgs(quality, url, outputPath, configArgs string) []stri
 	}
 
 	// User arguments are intentionally last so an explicit downloader preference
-	// in the configuration can override the default.
-	for _, arg := range strings.Split(configArgs, ",") {
-		if strings.TrimSpace(arg) != "" {
-			args = append(args, arg)
-		}
-	}
-
-	return args
+	// in the configuration can override the default. Output options are excluded
+	// so the application-owned temporary path remains authoritative.
+	return appendYtDlpVideoConfigArgs(args, configArgs)
 }
 
 // DownloadTwitchVideo downloads a Twitch video.

internal/exec/exec_test.go

@@ -91,6 +91,36 @@ func TestTwitchVideoDownloadArgsPreferFFmpegForHLS(t *testing.T) {
 	}
 }
 
+func TestAppendYtDlpVideoConfigArgsExcludesOutputOptions(t *testing.T) {
+	t.Parallel()
+
+	initial := []string{"-o", "/data/temp/video.%(ext)s"}
+	configArgs := strings.Join([]string{
+		"  --retries  ", "  10 ", "  ",
+		"-o", "/tmp/short-separated",
+		"--output", "/tmp/long-separated",
+		"-o=/tmp/short-equals",
+		"-o/tmp/short-attached",
+		"--output=/tmp/long-equals",
+		"-P", "/tmp/path-short-separated",
+		"--paths", "/tmp/path-long-separated",
+		"-P=/tmp/path-short-equals",
+		"-P/tmp/path-short-attached",
+		"--paths=/tmp/path-long-equals",
+		" --fragment-retries", "20 ",
+	}, ",")
+
+	got := appendYtDlpVideoConfigArgs(initial, configArgs)
+	want := []string{
+		"-o", "/data/temp/video.%(ext)s",
+		"--retries", "10",
+		"--fragment-retries", "20",
+	}
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("appendYtDlpVideoConfigArgs() = %v, want %v", got, want)
+	}
+}
+
 func TestPostProcessVideoFFmpegArgsIncludesTitleMetadata(t *testing.T) {
 	t.Parallel()