Skip to content

Contracts filters: add PENDING (your-move contracts), rename ACTIVE to CLOSED #82

Description

@Zillatron27

Request

From beta tester @Aemuthi (Discord), agreed by Zillatron: a filter for contracts where you still have something to do — mirroring vanilla PrUn's "Pending Contracts" sidebar (screenshot in Discord). The current ACTIVE filter isn't that: it includes contracts that are only waiting on the partner.

Agreed shape (Zillatron's ruling in the thread):

  • New PENDING filter — contracts where you have an action: any condition available to you, OR acceptance is awaiting-mine (ACCEPT/REJECT is your move too).
  • Rename ACTIVE → CLOSED — matching the game's own status vocabulary for accepted, in-progress contracts.

Implementation notes

  • ContractDetail.actionable already exists and was built for exactly this ("drives a future filter — contracts to fulfil"); PENDING = actionable || acceptance === 'awaiting-mine'.
  • Filter set + counts live in assembleContractDetails / ContractFilter (gameState); the filter bar persists selection — a reconcileOrder-style self-heal may be needed for saved filter state containing the old active id.
  • Caveat for the definition: after the Contract actions: one-tap ACCEPT / REJECT / FULFILL from the contract sheet #73 device findings, dependency-available ≠ game-enabled (shipment arrival etc.) — PENDING will slightly over-show. That's fine for a filter (the sheet's disabled guard is the truth at act time), but worth a note in the UI copy decision.
  • Coordinate with Contracts filter taps sometimes select the wrong filter / revert to ACTIVE #81 (filter tap reliability) — same surface; fix the bug first or together.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions