Skip to content

Commit 56141f5

Browse files
authored
fix : sign hash screen (#54)
* change message to sign hash * bump version * snapshots * handle undeterministic processing snapshots
1 parent e89997e commit 56141f5

139 files changed

Lines changed: 19 additions & 8 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ GIT_DESCRIBE=$(shell git describe --tags --abbrev=8 --always --long --dirty 2>/d
3737
VERSION_TAG=$(shell echo $(GIT_DESCRIBE) | sed 's/^v//g')
3838
APPVERSION_M=1
3939
APPVERSION_N=6
40-
APPVERSION_P=1
40+
APPVERSION_P=2
4141
APPVERSION=$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
4242
APPNAME = "Mina"
4343

src/sign_msg_bagl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ UX_STEP_NOCB(
126126
{
127127
&C_icon_eye,
128128
"Sign",
129-
"fullCommitment"
129+
"hash"
130130
}
131131
);
132132

@@ -182,12 +182,12 @@ UX_STEP_VALID(
182182
}
183183
);
184184

185-
// Field element step (displays as "fullCommitment" instead of "Message")
185+
// Field element step (displays as "hash" instead of "Message")
186186
UX_STEP_NOCB(
187187
ux_sign_field_flow_field_step,
188188
bn_paging,
189189
{
190-
"fullCommitment",
190+
"hash",
191191
_msgData.msgDataBuf
192192
}
193193
);

src/sign_msg_nbgl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static void prepare_msg_context(void) {
5454
}
5555

5656
if (_mode == POSEIDON_KIMCHI) {
57-
messageContext.tagValuePair[nbPairs].item = "fullCommitment";
57+
messageContext.tagValuePair[nbPairs].item = "hash";
5858
} else {
5959
messageContext.tagValuePair[nbPairs].item = "Message";
6060
}
@@ -103,9 +103,9 @@ void ui_sign_msg(uint8_t *dataBuffer, uint8_t dataLength, uint8_t net_id, poseid
103103
nbgl_useCaseReviewBlindSigning(TYPE_TRANSACTION | BLIND_OPERATION,
104104
&messageContext.tagValueList,
105105
&C_Mina_64px,
106-
"Review\nfullCommitment",
106+
"Review\nhash",
107107
NULL,
108-
"Accept risk and\nsign fullCommitment?",
108+
"Accept risk and\nsign hash?",
109109
NULL,
110110
review_choice);
111111
} else {
-193 Bytes
-127 Bytes
-182 Bytes
3.06 KB
-193 Bytes
-125 Bytes
-182 Bytes

0 commit comments

Comments
 (0)