Add Apex by chcmedeiros · Pull Request #230 · Zondax/ledger-oasis

chcmedeiros · 2025-11-06T12:02:11Z

github-advanced-security · 2025-11-06T12:05:11Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

abenso · 2025-11-07T16:58:53Z

  "dependencies": {
    "@zondax/ledger-oasis": "file:../js",
-    "@zondax/zemu": "^0.50.2"
+    "@zondax/zemu": "^0.62.2"


please use npm version

abenso · 2025-11-07T17:00:15Z

Please update the Readme

github-actions · 2025-11-07T17:19:36Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v18.1.8) reports: 34 file(s) not formatted

app/c_api/rust.c
app/src/ristretto.c
app/src/ristretto.h
app/src/eth_utils.c
app/src/consumer/coin_consumer.h
app/src/parser_impl_eth.c
app/src/apdu_handler.c
app/src/addr.c
app/src/eth_addr.h
app/src/common/tx.h
app/src/parser_txdef.h
app/src/common/tx.c
app/src/crypto.h
app/src/common/actions.c
app/src/crypto_helper.c
app/src/consumer/parser_txdef_con.h
app/src/parser_impl_eth.h
app/src/common/main.c
app/src/consumer/parser_consumer.c
app/src/parser_impl.h
app/src/common/parser.h
app/src/eth_addr.c
app/src/consumer/parser_impl_con.c
app/src/crypto_helper.h
app/rust/include/rslib.h
app/src/c_api/rust.c
app/src/consumer/cbor_helper.h
app/src/coin.h
app/src/common/actions.h
app/src/addr.h
app/src/eth_utils.h
app/src/consumer/parser_impl_con.h
app/src/crypto.c
app/src/common/parser_common.h

clang-tidy (v18.1.8) reports: 54 concern(s)

app/src/ristretto.h:43:1: error: [clang-diagnostic-error]

unknown type name 'cx_err_t'

   43 | cx_err_t crypto_scalarmult_ristretto255_base_sdk(unsigned char *q, const unsigned char *n);
      | ^

app/src/apdu_handler.c:155:1: warning: [clang-diagnostic-return-type]

non-void function does not return a value in all control paths
```
  155 | }
      | ^
```
app/src/apdu_handler.c:256:1: warning: [clang-diagnostic-return-type]

non-void function does not return a value in all control paths
```
  256 | }
      | ^
```
app/src/apdu_handler.c:350:37: warning: [clang-diagnostic-deprecated-non-prototype]

passing arguments to 'tx_parse' without a prototype is deprecated in all versions of C and is not supported in C23
```
  350 |     const char *error_msg = tx_parse(&parser_err);
      |                                     ^
```
app/src/apdu_handler.c:381:37: warning: [clang-diagnostic-deprecated-non-prototype]

passing arguments to 'tx_parse' without a prototype is deprecated in all versions of C and is not supported in C23
```
  381 |     const char *error_msg = tx_parse(&parser_err);
      |                                     ^
```
app/src/apdu_handler.c:412:37: warning: [clang-diagnostic-deprecated-non-prototype]

passing arguments to 'tx_parse' without a prototype is deprecated in all versions of C and is not supported in C23
```
  412 |     const char *error_msg = tx_parse(&parser_err);
      |                                     ^
```
app/src/apdu_handler.c:436:37: warning: [clang-diagnostic-deprecated-non-prototype]

passing arguments to 'tx_parse' without a prototype is deprecated in all versions of C and is not supported in C23
```
  436 |     const char *error_msg = tx_parse(&parser_err);
      |                                     ^
```
app/src/eth_addr.h:25:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   25 | zxerr_t eth_addr_getNumItems(uint8_t *num_items);
      | ^
```

app/src/eth_addr.h:25:30: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   25 | zxerr_t eth_addr_getNumItems(uint8_t *num_items);
      |                              ^

app/src/eth_addr.h:28:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   28 | zxerr_t eth_addr_getItem(int8_t displayIdx,
      | ^
```

app/src/eth_addr.h:28:26: error: [clang-diagnostic-error]

unknown type name 'int8_t'

   28 | zxerr_t eth_addr_getItem(int8_t displayIdx,
      |                          ^

app/src/eth_addr.h:29:36: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   29 |                      char *outKey, uint16_t outKeyLen,
      |                                    ^

app/src/eth_addr.h:30:38: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   30 |                      char *outValue, uint16_t outValueLen,
      |                                      ^

app/src/eth_addr.h:31:22: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   31 |                      uint8_t pageIdx, uint8_t *pageCount);
      |                      ^

app/src/eth_addr.h:31:39: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   31 |                      uint8_t pageIdx, uint8_t *pageCount);
      |                                       ^

app/src/crypto_helper.h:21:48: error: [clang-diagnostic-error]

unknown type name 'size_t'

   21 | zxerr_t crypto_getBytesToSign(uint8_t *toSign, size_t toSignLen);
      |                                                ^

app/src/crypto_helper.h:22:65: error: [clang-diagnostic-error]

unknown type name 'size_t'

   22 | const uint8_t *crypto_getSr25519BytesToSign(uint8_t *msgDigest, size_t msgDigestLen, uint32_t *ctxLen);
      |                                                                 ^

app/src/consumer/cbor_helper.h:20:12: error: [clang-diagnostic-error]

unknown type name 'parser_error_t'
```
   20 | __Z_INLINE parser_error_t parser_mapCborError(CborError err) {
      |            ^
```

app/src/consumer/cbor_helper.h:20:47: error: [clang-diagnostic-error]

unknown type name 'CborError'

   20 | __Z_INLINE parser_error_t parser_mapCborError(CborError err) {
      |                                               ^

app/src/consumer/cbor_helper.h:22:14: error: [clang-diagnostic-error]

use of undeclared identifier 'CborErrorUnexpectedEOF'
```
   22 |         case CborErrorUnexpectedEOF:
      |              ^
```
app/src/consumer/cbor_helper.h:23:20: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_cbor_unexpected_EOF'
```
   23 |             return parser_cbor_unexpected_EOF;
      |                    ^
```
app/src/consumer/cbor_helper.h:24:14: error: [clang-diagnostic-error]

use of undeclared identifier 'CborErrorMapNotSorted'
```
   24 |         case CborErrorMapNotSorted:
      |              ^
```
app/src/consumer/cbor_helper.h:25:20: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_cbor_not_canonical'
```
   25 |             return parser_cbor_not_canonical;
      |                    ^
```
app/src/consumer/cbor_helper.h:26:14: error: [clang-diagnostic-error]

use of undeclared identifier 'CborNoError'
```
   26 |         case CborNoError:
      |              ^
```
app/src/consumer/cbor_helper.h:27:20: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_ok'
```
   27 |             return parser_ok;
      |                    ^
```
app/src/consumer/cbor_helper.h:29:20: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_cbor_unexpected'
```
   29 |             return parser_cbor_unexpected;
      |                    ^
```

app/src/consumer/cbor_helper.h:52:12: error: [clang-diagnostic-error]

unknown type name 'parser_error_t'

   52 | __Z_INLINE parser_error_t _matchKey(CborValue *value, const char *expectedKey) {
      |            ^

app/src/consumer/cbor_helper.h:52:37: error: [clang-diagnostic-error]

unknown type name 'CborValue'

   52 | __Z_INLINE parser_error_t _matchKey(CborValue *value, const char *expectedKey) {
      |                                     ^

app/src/consumer/cbor_helper.h:53:5: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_unexpected_type'

   53 |     CHECK_CBOR_TYPE(cbor_value_get_type(value), CborTextStringType)
      |     ^
/__w/ledger-oasis/ledger-oasis/app/src/consumer/cbor_helper.h:38:69: note: expanded from macro 'CHECK_CBOR_TYPE'
   38 | #define CHECK_CBOR_TYPE(type, expected) {if (type!=expected) return parser_unexpected_type;}
      |                                                                     ^

app/src/consumer/cbor_helper.h:53:21: error: [clang-diagnostic-implicit-function-declaration]

call to undeclared function 'cbor_value_get_type'; ISO C99 and later do not support implicit function declarations
```
   53 |     CHECK_CBOR_TYPE(cbor_value_get_type(value), CborTextStringType)
      |                     ^
```

app/src/consumer/cbor_helper.h:53:49: error: [clang-diagnostic-error]

use of undeclared identifier 'CborTextStringType'

   53 |     CHECK_CBOR_TYPE(cbor_value_get_type(value), CborTextStringType)
      |                                                 ^

app/src/consumer/cbor_helper.h:56:5: error: [clang-diagnostic-error]

use of undeclared identifier 'CborError'

   56 |     CHECK_CBOR_ERR(cbor_value_text_string_equals(value, expectedKey, &result))
      |     ^
/__w/ledger-oasis/ledger-oasis/app/src/consumer/cbor_helper.h:34:5: note: expanded from macro 'CHECK_CBOR_ERR'
   34 |     CborError err = CALL;  \
      |     ^

app/src/consumer/cbor_helper.h:56:5: error: [clang-diagnostic-error]

use of undeclared identifier 'CborNoError'

   56 |     CHECK_CBOR_ERR(cbor_value_text_string_equals(value, expectedKey, &result))
      |     ^
/__w/ledger-oasis/ledger-oasis/app/src/consumer/cbor_helper.h:36:14: note: expanded from macro 'CHECK_CBOR_ERR'
   36 |     if (err!=CborNoError) return parser_mapCborError(err);}
      |              ^

app/src/consumer/cbor_helper.h:56:5: error: [clang-diagnostic-error]

use of undeclared identifier 'err'

   56 |     CHECK_CBOR_ERR(cbor_value_text_string_equals(value, expectedKey, &result))
      |     ^
/__w/ledger-oasis/ledger-oasis/app/src/consumer/cbor_helper.h:36:9: note: expanded from macro 'CHECK_CBOR_ERR'
   36 |     if (err!=CborNoError) return parser_mapCborError(err);}
      |         ^

app/src/consumer/cbor_helper.h:58:16: error: [clang-diagnostic-error]

use of undeclared identifier 'parser_unexpected_field'
```
   58 |         return parser_unexpected_field;
      |                ^
```
app/src/addr.h:24:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   24 | zxerr_t addr_getNumItems(uint8_t *num_items);
      | ^
```

app/src/addr.h:24:26: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   24 | zxerr_t addr_getNumItems(uint8_t *num_items);
      |                          ^

app/src/addr.h:27:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   27 | zxerr_t addr_getItem_ed25519(int8_t displayIdx,
      | ^
```

app/src/addr.h:27:30: error: [clang-diagnostic-error]

unknown type name 'int8_t'

   27 | zxerr_t addr_getItem_ed25519(int8_t displayIdx,
      |                              ^

app/src/addr.h:28:44: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   28 |                              char *outKey, uint16_t outKeyLen,
      |                                            ^

app/src/addr.h:29:46: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   29 |                              char *outValue, uint16_t outValueLen,
      |                                              ^

app/src/addr.h:30:30: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   30 |                              uint8_t pageIdx, uint8_t *pageCount);
      |                              ^

app/src/addr.h:30:47: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   30 |                              uint8_t pageIdx, uint8_t *pageCount);
      |                                               ^

app/src/addr.h:31:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   31 | zxerr_t addr_getItem_secp256k1(int8_t displayIdx,
      | ^
```

app/src/addr.h:31:32: error: [clang-diagnostic-error]

unknown type name 'int8_t'

   31 | zxerr_t addr_getItem_secp256k1(int8_t displayIdx,
      |                                ^

app/src/addr.h:32:46: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   32 |                                char *outKey, uint16_t outKeyLen,
      |                                              ^

app/src/addr.h:33:48: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   33 |                                char *outValue, uint16_t outValueLen,
      |                                                ^

app/src/addr.h:34:32: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   34 |                                uint8_t pageIdx, uint8_t *pageCount);
      |                                ^

app/src/addr.h:34:49: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   34 |                                uint8_t pageIdx, uint8_t *pageCount);
      |                                                 ^

app/src/addr.h:35:1: error: [clang-diagnostic-error]

unknown type name 'zxerr_t'
```
   35 | zxerr_t addr_getItem_sr25519(int8_t displayIdx,
      | ^
```

app/src/addr.h:35:30: error: [clang-diagnostic-error]

unknown type name 'int8_t'

   35 | zxerr_t addr_getItem_sr25519(int8_t displayIdx,
      |                              ^

app/src/addr.h:36:46: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   36 |                                char *outKey, uint16_t outKeyLen,
      |                                              ^

app/src/addr.h:37:48: error: [clang-diagnostic-error]

unknown type name 'uint16_t'

   37 |                                char *outValue, uint16_t outValueLen,
      |                                                ^

app/src/addr.h:38:32: error: [clang-diagnostic-error]

unknown type name 'uint8_t'

   38 |                                uint8_t pageIdx, uint8_t *pageCount);
      |                                ^

Have any feedback or feature suggestions? Share it here.

chcmedeiros added 4 commits November 5, 2025 14:20

update zxlib

f5852bc

update CI

0de9c6a

update icons & makefiles

1ce1a93

Add apex support & remove nanoS

871243c

chcmedeiros force-pushed the feat/apex branch 3 times, most recently from 58d1d13 to 31c450d Compare November 6, 2025 12:32

chcmedeiros added 2 commits November 6, 2025 11:38

update tests

3d448d9

update snapshots

d518177

chcmedeiros force-pushed the feat/apex branch 20 times, most recently from ee58864 to f6d9d96 Compare November 7, 2025 12:38

chcmedeiros force-pushed the feat/apex branch 5 times, most recently from 1d46a68 to db5f1ca Compare November 7, 2025 15:40

improvements

1eaf325

chcmedeiros force-pushed the feat/apex branch from db5f1ca to 1eaf325 Compare November 7, 2025 16:04

abenso approved these changes Nov 7, 2025

View reviewed changes

update readme

6aecd18

chcmedeiros merged commit 6ecee66 into dev Nov 7, 2025
44 of 61 checks passed

chcmedeiros deleted the feat/apex branch November 7, 2025 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Apex#230

Add Apex#230
chcmedeiros merged 8 commits intodevfrom
feat/apex

chcmedeiros commented Nov 6, 2025 •

edited by zboto Bot

Loading

Uh oh!

github-advanced-security AI commented Nov 6, 2025

Uh oh!

abenso Nov 7, 2025

Uh oh!

abenso commented Nov 7, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chcmedeiros commented Nov 6, 2025 • edited by zboto Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-advanced-security AI commented Nov 6, 2025

Uh oh!

abenso Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

abenso commented Nov 7, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 7, 2025

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chcmedeiros commented Nov 6, 2025 •

edited by zboto Bot

Loading