Fix dropping reference warning

Zondax · Dec 9, 2024 · 5a4c982 · 5a4c982
1 parent d840e1a
commit 5a4c982
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/zemu/src/ui_toolkit/backends/nanosplus.rs b/zemu/src/ui_toolkit/backends/nanosplus.rs
@@ -141,7 +141,11 @@ impl UIBackend<KEY_SIZE> for NanoSPBackend {
     }
 
     fn message_buf(&mut self) -> Self::MessageBuf {
-        core::mem::drop(self);
+        // core::mem::drop(self);
+        // We do not know what is self, but the compiler
+        // does, so let it know we are done with self
+        // at this point
+        _ = self;
 
         core::str::from_utf8_mut(&mut Self::static_mut().message)
             //this should never happen as we always asciify

diff --git a/zemu/src/ui_toolkit/backends/nanox.rs b/zemu/src/ui_toolkit/backends/nanox.rs
@@ -141,7 +141,10 @@ impl UIBackend<KEY_SIZE> for NanoXBackend {
     }
 
     fn message_buf(&mut self) -> Self::MessageBuf {
-        core::mem::drop(self);
+        // We do not know what is self, but the compiler
+        // does, so let it know we are done with self
+        // at this point
+        _ = self;
 
         core::str::from_utf8_mut(&mut Self::static_mut().message)
             //this should never happen as we always asciify