clean code

Author: abenso

app/src/common/parser_common.h

@@ -83,6 +83,7 @@ typedef enum {
     parser_ui_find_bracket_buffer_too_small,
     parser_ui_buffer_not_initialized,
     parser_ui_buffer_init_failed,
+    parser_ui_buffer_too_small,
 } parser_error_t;
 
 #ifdef __cplusplus

app/src/modules/bank_reader.c

@@ -63,19 +63,15 @@ parser_error_t read_bank_call_message(parser_context_t *ctx, bank_call_message_t
             print_string("BANK_CALL_MESSAGE_CREATE_TOKEN NOT IMPLEMENTED");
             return parser_unexpected_error;
         case BANK_CALL_MESSAGE_TRANSFER:
-            print_string("CALL_MESSAGE_TRANSFER");
             CHECK_ERROR(read_bank_transfer(ctx, &bank->transfer));
             break;
         case BANK_CALL_MESSAGE_BURN:
-            print_string("BANK_CALL_MESSAGE_BURN");
             CHECK_ERROR(read_bank_burn(ctx, &bank->burn));
             break;
         case BANK_CALL_MESSAGE_MINT:
-            print_string("BANK_CALL_MESSAGE_MINT");
             CHECK_ERROR(read_bank_mint(ctx, &bank->mint));
             break;
         case BANK_CALL_MESSAGE_FREEZE:
-            print_string("BANK_CALL_MESSAGE_FREEZE");
             CHECK_ERROR(read_bank_freeze(ctx, &bank->freeze));
             break;
         default:

app/src/modules/common_reader.c

@@ -22,11 +22,6 @@ parser_error_t read_amount(parser_context_t *ctx, amount_t *amount) {
 
     CHECK_ERROR(read_u64(ctx, &amount->lo));
     CHECK_ERROR(read_u64(ctx, &amount->hi));
-    print_u64_hex("amount:", amount->lo);
-    print_u64_hex("amount:", amount->hi);
-
-    print_u64("amount:", amount->lo);
-    print_u64("amount:", amount->hi);
 
     return parser_ok;
 }
@@ -39,8 +34,6 @@ parser_error_t read_token_id(parser_context_t *ctx, token_id_t *token_id) {
     token_id->token.ptr = ctx->buffer.ptr + ctx->offset;
     CTX_CHECK_AND_ADVANCE(ctx, TOKEN_ID_SIZE)
 
-    print_buffer(&token_id->token, "token_id");
-
     return parser_ok;
 }
 
@@ -49,14 +42,11 @@ parser_error_t read_address(parser_context_t *ctx, address_t *address) {
     CHECK_INPUT(address);
 
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&address->type));
-    print_u8("address type", address->type);
 
     address->address.len = ADDRESS_SIZE;
     address->address.ptr = ctx->buffer.ptr + ctx->offset;
     CTX_CHECK_AND_ADVANCE(ctx, ADDRESS_SIZE);
 
-    print_buffer(&address->address, "address");
-
     return parser_ok;
 }
 
@@ -76,8 +66,6 @@ parser_error_t read_gas(parser_context_t *ctx, gas_t *gas) {
 
     for (int i = 0; i < GAS_DIMENSIONS; i++) {
         CHECK_ERROR(read_u64(ctx, &gas->gas[i]));
-        print_u64_hex("gas[%d]:", gas->gas[i]);
-        print_u64("gas[%d]:", gas->gas[i]);
     }
 
     return parser_ok;

app/src/modules/paymaster_reader.c

@@ -21,28 +21,23 @@ parser_error_t read_payee_policy_allow(parser_context_t *ctx, payee_policy_allow
     CHECK_INPUT(allow);
 
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&allow->has_max_fee));
-    print_u8("has max fee:", allow->has_max_fee);
     if (allow->has_max_fee) {
         CHECK_ERROR(read_amount(ctx, &allow->max_fee));
     }
 
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&allow->has_gas_limit));
-    print_u8("has gas limit:", allow->has_gas_limit);
     if (allow->has_gas_limit) {
         CHECK_ERROR(read_gas(ctx, &allow->gas_limit));
     }
 
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&allow->has_max_gas_price));
-    print_u8("has max gas price:", allow->has_max_gas_price);
     if (allow->has_max_gas_price) {
         CHECK_ERROR(read_gas_u128(ctx, &allow->max_gas_price));
     }
 
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&allow->has_transaction_limit));
-    print_u8("has transaction limit:", allow->has_transaction_limit);
     if (allow->has_transaction_limit) {
         CHECK_ERROR(read_u64(ctx, &allow->transaction_limit));
-        print_u64("transaction limit:", allow->transaction_limit);
     }
 
     return parser_ok;
@@ -73,7 +68,6 @@ parser_error_t read_payee_policy_list(parser_context_t *ctx, payee_policy_list_t
     CHECK_INPUT(payees);
 
     CHECK_ERROR(read_u32(ctx, &payees->length));
-    print_u32("payees list length:", payees->length);
     for (int i = 0; i < (int)payees->length; i++) {
         CHECK_ERROR(read_address(ctx, &payees->pairs[i].address));
         CHECK_ERROR(read_payee_policy(ctx, &payees->pairs[i].policy));
@@ -86,7 +80,6 @@ parser_error_t read_authorized_updaters(parser_context_t *ctx, address_list_t *u
     CHECK_INPUT(updaters);
 
     CHECK_ERROR(read_u32(ctx, &updaters->length));
-    print_u32("authorized updaters length:", updaters->length);
     for (int i = 0; i < (int)updaters->length; i++) {
         CHECK_ERROR(read_address(ctx, &updaters->address[i]));
     }
@@ -103,7 +96,6 @@ parser_error_t read_authorized_sequencers(parser_context_t *ctx, authorized_sequ
             print_string("AUTHORIZED_SEQUENCERS_ALL");
             break;
         case AUTHORIZED_SEQUENCERS_SOME:
-            print_string("AUTHORIZED_SEQUENCERS_SOME");
             CHECK_ERROR(read_authorized_updaters(ctx, &sequencers->updaters));
             break;
     }
@@ -139,7 +131,7 @@ parser_error_t read_paymaster_call_message(parser_context_t *ctx, paymaster_call
     CHECK_ERROR(read_u8(ctx, (uint8_t *)&paymaster->type));
     switch (paymaster->type) {
         case PAYMASTER_CALL_REGISTER_PAYMASTER:
-            print_string("PAYMASTER_CALL_REGISTER_PAYMASTER");
+
             CHECK_ERROR(read_paymaster_register_paymaster(ctx, &paymaster->register_paymaster));
             break;
         case PAYMASTER_CALL_SET_PAYER_FOR_SEQUENCER:

app/src/parser_impl.c

@@ -29,10 +29,7 @@ parser_error_t _read(parser_context_t *c, parser_tx_t *v) {
     CHECK_ERROR(schema_chain_hash_read(c, v));
 
     if (c->offset != c->buffer.len) {
-        print_string("Failed to parse unsigned transaction\n");
         return parser_unexpected_error;
-    } else {
-        print_string("Successfully parsed unsigned transaction\n");
     }
 
     return parser_ok;
@@ -131,6 +128,8 @@ const char *parser_getErrorDescription(parser_error_t err) {
             return "buffer not initialized";
         case parser_ui_buffer_init_failed:
             return "buffer init failed";
+        case parser_ui_buffer_too_small:
+            return "buffer too small";
 
         default:
             return "Unrecognized error code";