format files

abenso · abenso · commit d932c3067da0 · 2025-07-17T09:38:48.000-03:00
diff --git a/.clang-format b/.clang-format
@@ -1,5 +1,5 @@
 BasedOnStyle: Google
 IndentWidth: 4
-ColumnLimit: 125
+ColumnLimit: 120
 DerivePointerAlignment: false
 PointerAlignment: Right
diff --git a/README.md b/README.md
@@ -72,7 +72,7 @@ then run:
 - This project requires Ledger firmware 2.0
     - The current repository keeps track of Ledger's SDK but it is possible to override it by changing the git submodule.
 
-*Warning*: Some IDEs may not use the same python interpreter or virtual enviroment as the one you used when running `pip`.
+*Warning*: Some IDEs may not use the same python interpreter or virtual environment as the one you used when running `pip`.
 If you see conan is not found, check that you installed the package in the same interpreter as the one that launches `cmake`.
 
 ## How to build ?
diff --git a/app/src/addr.c b/app/src/addr.c
@@ -34,8 +34,8 @@ zxerr_t addr_getNumItems(uint8_t *num_items) {
     return zxerr_ok;
 }
 
-zxerr_t addr_getItem(int8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal, uint16_t outValLen, uint8_t pageIdx,
-                     uint8_t *pageCount) {
+zxerr_t addr_getItem(int8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal, uint16_t outValLen,
+                     uint8_t pageIdx, uint8_t *pageCount) {
     ZEMU_LOGF(50, "[addr_getItem] %d/%d\n", displayIdx, pageIdx)
 
     switch (displayIdx) {
diff --git a/app/src/common/parser.h b/app/src/common/parser.h
@@ -35,8 +35,8 @@ parser_error_t parser_validate(parser_tx_t *txObj);
 parser_error_t parser_getNumItems(const parser_tx_t *txObj, uint8_t *num_items);
 
 // retrieves a readable output for each field / page
-parser_error_t parser_getItem(const parser_tx_t *txObj, uint8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal,
-                              uint16_t outValLen, uint8_t pageIdx, uint8_t *pageCount);
+parser_error_t parser_getItem(const parser_tx_t *txObj, uint8_t displayIdx, char *outKey, uint16_t outKeyLen,
+                              char *outVal, uint16_t outValLen, uint8_t pageIdx, uint8_t *pageCount);
 
 #ifdef __cplusplus
 }
diff --git a/app/src/common/tx.c b/app/src/common/tx.c
@@ -85,8 +85,8 @@ zxerr_t tx_getNumItems(uint8_t *num_items) {
     return zxerr_ok;
 }
 
-zxerr_t tx_getItem(int8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal, uint16_t outValLen, uint8_t pageIdx,
-                   uint8_t *pageCount) {
+zxerr_t tx_getItem(int8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal, uint16_t outValLen,
+                   uint8_t pageIdx, uint8_t *pageCount) {
     uint8_t numItems = 0;
 
     CHECK_ZXERR(tx_getNumItems(&numItems))
diff --git a/app/src/crypto.c b/app/src/crypto.c
@@ -71,7 +71,8 @@ zxerr_t crypto_sign(uint8_t *signature, uint16_t signatureMaxlen, const uint8_t
     CATCH_CXERROR(os_derive_bip32_with_seed_no_throw(HDW_ED25519_SLIP10, CX_CURVE_Ed25519, hdPath, HDPATH_LEN_DEFAULT,
                                                      privateKeyData, NULL, NULL, 0));
 
-    CATCH_CXERROR(cx_ecfp_init_private_key_no_throw(CX_CURVE_Ed25519, privateKeyData, SCALAR_LEN_ED25519, &cx_privateKey));
+    CATCH_CXERROR(
+        cx_ecfp_init_private_key_no_throw(CX_CURVE_Ed25519, privateKeyData, SCALAR_LEN_ED25519, &cx_privateKey));
 
     // Sign
     CATCH_CXERROR(cx_eddsa_sign_no_throw(&cx_privateKey, CX_SHA512, message, messageLen, signature, signatureMaxlen));
diff --git a/app/src/crypto_helper.c b/app/src/crypto_helper.c
@@ -86,8 +86,8 @@ zxerr_t crypto_computeAddress(uint8_t *address, uint16_t addressLen, const uint8
 
     uint8_t sha[PK_LEN_25519] = {0};
     CHECK_ZXERR(crypto_sha256_one_shot(sha, sizeof(sha), pubkey, PK_LEN_25519));
-    CHECK_ZXERR(
-        bech32EncodeFromBytes((char *)address, ADDRESS_MAX_LENGTH, HRP, sha, PUBKEY_SHA_LEN, 1, BECH32_ENCODING_BECH32M));
+    CHECK_ZXERR(bech32EncodeFromBytes((char *)address, ADDRESS_MAX_LENGTH, HRP, sha, PUBKEY_SHA_LEN, 1,
+                                      BECH32_ENCODING_BECH32M));
 
     return zxerr_ok;
 }
diff --git a/app/src/parser.c b/app/src/parser.c
@@ -86,8 +86,8 @@ static parser_error_t checkSanity(uint8_t numItems, uint8_t displayIdx) {
     return parser_ok;
 }
 
-parser_error_t page_title(parser_tx_t *txObj, char *outKey, uint16_t outKeyLen, const char *title, primitive_t *primitive,
-                          parser_context_t *data_context) {
+parser_error_t page_title(parser_tx_t *txObj, char *outKey, uint16_t outKeyLen, const char *title,
+                          primitive_t *primitive, parser_context_t *data_context) {
     CHECK_INPUT(outKey);
     CHECK_INPUT(title);
 
@@ -130,8 +130,8 @@ static uint8_t calculate_page_count(const char *text, uint16_t maxCharsPerPage)
     return pageCount;
 }
 
-parser_error_t page_item(parser_tx_t *txObj, char *outValue, uint16_t outValueLen, const char *title, primitive_t *primitive,
-                         parser_context_t *data_context, uint8_t pageIdx, uint8_t *pageCount) {
+parser_error_t page_item(parser_tx_t *txObj, char *outValue, uint16_t outValueLen, const char *title,
+                         primitive_t *primitive, parser_context_t *data_context, uint8_t pageIdx, uint8_t *pageCount) {
     CHECK_INPUT(outValue);
     CHECK_INPUT(title);
     CHECK_INPUT(primitive);
@@ -188,8 +188,8 @@ parser_error_t page_item(parser_tx_t *txObj, char *outValue, uint16_t outValueLe
     return parser_ok;
 }
 
-parser_error_t parser_getItem(const parser_tx_t *txObj, uint8_t displayIdx, char *outKey, uint16_t outKeyLen, char *outVal,
-                              uint16_t outValLen, uint8_t pageIdx, uint8_t *pageCount) {
+parser_error_t parser_getItem(const parser_tx_t *txObj, uint8_t displayIdx, char *outKey, uint16_t outKeyLen,
+                              char *outVal, uint16_t outValLen, uint8_t pageIdx, uint8_t *pageCount) {
     UNUSED(pageIdx);
     *pageCount = 1;
     uint8_t numItems = 0;
diff --git a/app/src/render.c b/app/src/render.c
@@ -153,8 +153,8 @@ parser_error_t render_fixed_point(parser_context_t *ctx, fixed_point_display_t d
     }
 }
 
-parser_error_t render_primitive_integer(parser_context_t *ctx, integer_display_t display, uint128_t value, char *outValue,
-                                        uint16_t outValueLen) {
+parser_error_t render_primitive_integer(parser_context_t *ctx, integer_display_t display, uint128_t value,
+                                        char *outValue, uint16_t outValueLen) {
     CHECK_INPUT(ctx);
     CHECK_INPUT(outValue);
     MEMZERO(outValue, outValueLen);
@@ -177,7 +177,8 @@ parser_error_t render_primitive_integer(parser_context_t *ctx, integer_display_t
     return parser_ok;
 }
 
-parser_error_t render_integer(parser_context_t *ctx, primitive_integer_t *primitive, char *outValue, uint16_t outValueLen) {
+parser_error_t render_integer(parser_context_t *ctx, primitive_integer_t *primitive, char *outValue,
+                              uint16_t outValueLen) {
     CHECK_INPUT(ctx);
     CHECK_INPUT(primitive);
 
diff --git a/app/src/schema_helper.c b/app/src/schema_helper.c
@@ -27,7 +27,8 @@
  * @param found Output: set to true if the index is found, false otherwise.
  * @return parser_error_t Error code indicating success or failure.
  */
-parser_error_t schema_find_index(uint64_t index_leaf, merkle_leaves_indices_t *indices, uint64_t *index_vec, bool *found) {
+parser_error_t schema_find_index(uint64_t index_leaf, merkle_leaves_indices_t *indices, uint64_t *index_vec,
+                                 bool *found) {
     CHECK_INPUT(indices);
     CHECK_INPUT(index_vec);
 
diff --git a/app/src/schema_helper.h b/app/src/schema_helper.h
@@ -22,7 +22,8 @@ extern "C" {
 
 #include "parser_common.h"
 
-parser_error_t schema_find_index(uint64_t index_leaf, merkle_leaves_indices_t *indices, uint64_t *index_vec, bool *found);
+parser_error_t schema_find_index(uint64_t index_leaf, merkle_leaves_indices_t *indices, uint64_t *index_vec,
+                                 bool *found);
 parser_error_t schema_move_leaf_offset(merkle_leaves_data_t *leaves, uint64_t index);
 parser_error_t schema_reset_leaf_offset(merkle_leaves_data_t *leaves);
 parser_error_t get_schema_type(parser_tx_t *txObj, uint32_t index, uint8_t *type);
diff --git a/app/src/schema_proof.c b/app/src/schema_proof.c
@@ -70,7 +70,8 @@ static uint32_t next_smaller_po2(uint32_t n) {
  * @param tree_size The output buffer for the computed tree size.
  * @return parser_error_t Error code indicating the result of the operation.
  */
-parser_error_t compute_tree_size(uint32_t num_right_siblings, uint32_t index_of_last_included_leaf, uint32_t *tree_size) {
+parser_error_t compute_tree_size(uint32_t num_right_siblings, uint32_t index_of_last_included_leaf,
+                                 uint32_t *tree_size) {
     uint32_t index_of_final_node = index_of_last_included_leaf;
     uint32_t mask = 1;
     uint32_t remaining_right_siblings = num_right_siblings;
diff --git a/app/src/schema_reader.c b/app/src/schema_reader.c
@@ -747,7 +747,8 @@ parser_error_t compute_internal_data_hash(parser_tx_t *txObj, uint8_t *internal_
     crypto_sha256_init();
     crypto_sha256_update(txObj->schema.root_type_indices.complete_borsh_data.ptr,
                          txObj->schema.root_type_indices.complete_borsh_data.len);
-    crypto_sha256_update(txObj->schema.chain_data.complete_borsh_data.ptr, txObj->schema.chain_data.complete_borsh_data.len);
+    crypto_sha256_update(txObj->schema.chain_data.complete_borsh_data.ptr,
+                         txObj->schema.chain_data.complete_borsh_data.len);
     crypto_sha256_final(internal_data_hash);
 
     return parser_ok;
diff --git a/app/src/schema_txn_parser.c b/app/src/schema_txn_parser.c
@@ -30,7 +30,8 @@ bool ui_expert_mode = false;
 
 #define NONE_STRING "None"
 
-parser_error_t append_structured_show_as_title(const bytes_t *structured_show_as, uint32_t field_index, bool *remove_title) {
+parser_error_t append_structured_show_as_title(const bytes_t *structured_show_as, uint32_t field_index,
+                                               bool *remove_title) {
     CHECK_INPUT(structured_show_as);
     CHECK_INPUT(remove_title);
 
@@ -45,7 +46,8 @@ parser_error_t append_structured_show_as_title(const bytes_t *structured_show_as
     return parser_ok;
 }
 
-parser_error_t schema_display_integer(parser_context_t *ctx, primitive_integer_t *primitive, parser_context_t *ctx_to_push) {
+parser_error_t schema_display_integer(parser_context_t *ctx, primitive_integer_t *primitive,
+                                      parser_context_t *ctx_to_push) {
     CHECK_INPUT(ctx);
     CHECK_INPUT(primitive);
     CHECK_INPUT(ctx_to_push);
@@ -103,7 +105,8 @@ parser_error_t schema_display_integer(parser_context_t *ctx, primitive_integer_t
                     return parser_unexpected_type;
                 case FIXED_POINT_DISPLAY_FROM_SIBLING_FIELD:
                     // get offset
-                    if (ctx->offset + primitive->display.fixed_point.from_sibling_field.byte_offset >= ctx->buffer.len) {
+                    if (ctx->offset + primitive->display.fixed_point.from_sibling_field.byte_offset >=
+                        ctx->buffer.len) {
                         return parser_unexpected_buffer_end;
                     }
                     len_to_push += primitive->display.fixed_point.from_sibling_field.byte_offset + 1;
@@ -239,7 +242,8 @@ parser_error_t schema_display_struct(parser_context_t *ctx, parser_tx_t *txObj)
         MEMZERO(&named_field, sizeof(named_field_t));
         CHECK_ERROR(read_named_field(&struct_type.named_fields, &named_field));
 
-        bool show_field = should_show_field(&named_field.value, named_field.silent, named_field.is_expert, ui_expert_mode);
+        bool show_field =
+            should_show_field(&named_field.value, named_field.silent, named_field.is_expert, ui_expert_mode);
 
         bool remove_title = false;
         if (show_field) {
diff --git a/app/src/ui_item_buffer.c b/app/src/ui_item_buffer.c
@@ -281,7 +281,8 @@ parser_error_t get_item_buffer_range_length(item_buffer_t *buffer, uint8_t index
     return parser_ok;
 }
 
-parser_error_t get_item_buffer_range(item_buffer_t *buffer, uint8_t index_start, uint8_t index_end, item_buffer_t *output) {
+parser_error_t get_item_buffer_range(item_buffer_t *buffer, uint8_t index_start, uint8_t index_end,
+                                     item_buffer_t *output) {
     CHECK_INPUT(buffer);
     CHECK_INPUT(output);
 
diff --git a/app/src/ui_item_buffer.h b/app/src/ui_item_buffer.h
@@ -28,6 +28,7 @@ parser_error_t get_item_buffer_content(item_buffer_t *buffer, uint8_t index, cha
 parser_error_t get_item_buffer_content_length(item_buffer_t *buffer, uint8_t index, size_t *length);
 parser_error_t get_item_buffer_range_length(item_buffer_t *buffer, uint8_t index_start, uint8_t index_end,
                                             size_t *total_length);
-parser_error_t get_item_buffer_range(item_buffer_t *buffer, uint8_t index_start, uint8_t index_end, item_buffer_t *output);
+parser_error_t get_item_buffer_range(item_buffer_t *buffer, uint8_t index_start, uint8_t index_end,
+                                     item_buffer_t *output);
 parser_error_t remove_first_separator(item_buffer_t *buffer, char *output, uint16_t output_len);
 parser_error_t remove_last_separator(item_buffer_t *buffer, char *output, uint16_t output_len);
diff --git a/app/src/ui_item_manager.c b/app/src/ui_item_manager.c
@@ -96,7 +96,8 @@ parser_error_t create_item_title(uint16_t index_start, uint16_t index_end, char
 
     for (uint16_t i = index_start; i < index_end; i++) {
         uint16_t output_str_len = strlen(output);
-        CHECK_ERROR(get_item_buffer_content(&item_title_buffer, i, output + output_str_len, output_len - output_str_len));
+        CHECK_ERROR(
+            get_item_buffer_content(&item_title_buffer, i, output + output_str_len, output_len - output_str_len));
         if (i < index_end - 1) {
             strncat(output, SEPARATOR_TITLE_DISPLAY, strlen(SEPARATOR_TITLE_DISPLAY));
         }
diff --git a/tests/parser_impl.cpp b/tests/parser_impl.cpp
diff --git a/tests/ui_tests.cpp b/tests/ui_tests.cpp

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ zxerr_t addr_getNumItems(uint8_t *num_items) {`
`34`	`34`	`return zxerr_ok;`
`35`	`35`	`}`
`36`	`36`
`37`		`-zxerr_t addr_getItem(int8_t displayIdx, char outKey, uint16_t outKeyLen, char outVal, uint16_t outValLen, uint8_t pageIdx,`
`38`		`- uint8_t *pageCount) {`
	`37`	`+zxerr_t addr_getItem(int8_t displayIdx, char outKey, uint16_t outKeyLen, char outVal, uint16_t outValLen,`
	`38`	`+ uint8_t pageIdx, uint8_t *pageCount) {`
`39`	`39`	`ZEMU_LOGF(50, "[addr_getItem] %d/%d\n", displayIdx, pageIdx)`
`40`	`40`
`41`	`41`	`switch (displayIdx) {`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ parser_error_t parser_validate(parser_tx_t *txObj);`
`35`	`35`	`parser_error_t parser_getNumItems(const parser_tx_t txObj, uint8_t num_items);`
`36`	`36`
`37`	`37`	`// retrieves a readable output for each field / page`
`38`		`-parser_error_t parser_getItem(const parser_tx_t txObj, uint8_t displayIdx, char outKey, uint16_t outKeyLen, char *outVal,`
`39`		`- uint16_t outValLen, uint8_t pageIdx, uint8_t *pageCount);`
	`38`	`+parser_error_t parser_getItem(const parser_tx_t txObj, uint8_t displayIdx, char outKey, uint16_t outKeyLen,`
	`39`	`+ char outVal, uint16_t outValLen, uint8_t pageIdx, uint8_t pageCount);`
`40`	`40`
`41`	`41`	`#ifdef __cplusplus`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,8 @@ zxerr_t tx_getNumItems(uint8_t *num_items) {`
`85`	`85`	`return zxerr_ok;`
`86`	`86`	`}`
`87`	`87`
`88`		`-zxerr_t tx_getItem(int8_t displayIdx, char outKey, uint16_t outKeyLen, char outVal, uint16_t outValLen, uint8_t pageIdx,`
`89`		`- uint8_t *pageCount) {`
	`88`	`+zxerr_t tx_getItem(int8_t displayIdx, char outKey, uint16_t outKeyLen, char outVal, uint16_t outValLen,`
	`89`	`+ uint8_t pageIdx, uint8_t *pageCount) {`
`90`	`90`	`uint8_t numItems = 0;`
`91`	`91`
`92`	`92`	`CHECK_ZXERR(tx_getNumItems(&numItems))`
Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ zxerr_t crypto_computeAddress(uint8_t *address, uint16_t addressLen, const uint8`
`86`	`86`
`87`	`87`	`uint8_t sha[PK_LEN_25519] = {0};`
`88`	`88`	`CHECK_ZXERR(crypto_sha256_one_shot(sha, sizeof(sha), pubkey, PK_LEN_25519));`
`89`		`- CHECK_ZXERR(`
`90`		`- bech32EncodeFromBytes((char *)address, ADDRESS_MAX_LENGTH, HRP, sha, PUBKEY_SHA_LEN, 1, BECH32_ENCODING_BECH32M));`
	`89`	`+ CHECK_ZXERR(bech32EncodeFromBytes((char *)address, ADDRESS_MAX_LENGTH, HRP, sha, PUBKEY_SHA_LEN, 1,`
	`90`	`+ BECH32_ENCODING_BECH32M));`
`91`	`91`
`92`	`92`	`return zxerr_ok;`
`93`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,8 @@ parser_error_t render_fixed_point(parser_context_t *ctx, fixed_point_display_t d`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`
`156`		`-parser_error_t render_primitive_integer(parser_context_t ctx, integer_display_t display, uint128_t value, char outValue,`
`157`		`- uint16_t outValueLen) {`
	`156`	`+parser_error_t render_primitive_integer(parser_context_t *ctx, integer_display_t display, uint128_t value,`
	`157`	`+ char *outValue, uint16_t outValueLen) {`
`158`	`158`	`CHECK_INPUT(ctx);`
`159`	`159`	`CHECK_INPUT(outValue);`
`160`	`160`	`MEMZERO(outValue, outValueLen);`
`@@ -177,7 +177,8 @@ parser_error_t render_primitive_integer(parser_context_t *ctx, integer_display_t`
`177`	`177`	`return parser_ok;`
`178`	`178`	`}`
`179`	`179`
`180`		`-parser_error_t render_integer(parser_context_t ctx, primitive_integer_t primitive, char *outValue, uint16_t outValueLen) {`
	`180`	`+parser_error_t render_integer(parser_context_t ctx, primitive_integer_t primitive, char *outValue,`
	`181`	`+ uint16_t outValueLen) {`
`181`	`182`	`CHECK_INPUT(ctx);`
`182`	`183`	`CHECK_INPUT(primitive);`
`183`	`184`