fixes

Author: abenso

app/src/render.c

@@ -284,18 +284,11 @@ parser_error_t render_primitive(parser_context_t *ctx, parser_tx_t *txObj, primi
     CHECK_INPUT(txObj);
     CHECK_INPUT(outValue);
 
-    uint16_t primitive_size = sizeof(primitive);
-    print_u16("Primitive size: ", primitive_size);
-
     switch (primitive->type) {
         case PRIMITIVE_INTEGER:
-            primitive_size = sizeof(primitive->integer);
-            print_u16("Primitive size integer_1: ", primitive_size);
             CHECK_ERROR(render_integer(ctx, &primitive->integer, outValue, outValueLen));
             break;
         case PRIMITIVE_BYTE_ARRAY:
-            primitive_size = sizeof(primitive->byte_array);
-            print_u16("Primitive size byte_array: ", primitive_size);
             CHECK_ERROR(render_byte_array(ctx, txObj, &primitive->byte_array, outValue, outValueLen));
             break;
         case PRIMITIVE_BYTE_VEC:

app/src/schema_txn_parser.c

@@ -143,16 +143,12 @@ parser_error_t schema_display_byte_array(parser_context_t *ctx, primitive_byte_a
 parser_error_t schema_display_primitive(parser_context_t *ctx, parser_tx_t *txObj, primitive_t *primitive) {
     CHECK_INPUT(ctx);
 
-    uint16_t primitive_size = sizeof(primitive);
-
     parser_context_t ctx_to_push = {0};
     switch (primitive->type) {
         case PRIMITIVE_INTEGER:
-            primitive_size = sizeof(primitive->integer);
             CHECK_ERROR(schema_display_integer(ctx, &primitive->integer, &ctx_to_push));
             break;
         case PRIMITIVE_BYTE_ARRAY:
-            primitive_size = sizeof(primitive->byte_array);
             CHECK_ERROR(schema_display_byte_array(ctx, &primitive->byte_array, &ctx_to_push));
             break;
         case PRIMITIVE_BYTE_VEC:

app/src/ui_item_buffer.c

@@ -40,7 +40,8 @@ parser_error_t init_item_buffer(item_buffer_t *buffer, const char *initial_data,
     buffer->qty = 0;
     buffer->initialized = true;
     if (initial_data != NULL) {
-        strncpy(buffer->data, initial_data, strlen(initial_data));
+        strncpy(buffer->data, initial_data, sizeof(buffer->data) - 1);
+        buffer->data[sizeof(buffer->data) - 1] = '\0';
         if (get_item_buffer_qty(buffer, &buffer->qty) != parser_ok) {
             buffer->initialized = false;
             return parser_ui_buffer_init_failed;

app/src/ui_item_manager.c

@@ -94,7 +94,7 @@ parser_error_t create_item_title(uint16_t index_start, uint16_t index_end, char
         return parser_ui_item_title_empty;
     }
 
-    for (uint8_t i = index_start; i < index_end; i++) {
+    for (uint16_t i = index_start; i < index_end; i++) {
         uint16_t output_str_len = strlen(output);
         CHECK_ERROR(get_item_buffer_content(&item_title_buffer, i, output + output_str_len, output_len - output_str_len));
         if (i < index_end - 1) {