clean code

Author: abenso

app/src/render.c

@@ -252,4 +252,4 @@ parser_error_t render_primitive(parser_context_t *ctx, parser_tx_t *txObj, primi
     print_u8("render_primitive finished: ", primitive->type);
 
     return parser_ok;
-}
+}

app/src/schema_display.c

@@ -30,9 +30,8 @@ bool ui_expert_mode = false;
 
 #define NONE_STRING "None"
 
-parser_error_t schema_display_integer(parser_context_t *ctx, parser_tx_t *txObj, primitive_integer_t *primitive) {
+parser_error_t schema_display_integer(parser_context_t *ctx, primitive_integer_t *primitive) {
     CHECK_INPUT(ctx);
-    CHECK_INPUT(txObj);
     CHECK_INPUT(primitive);
 
     parser_context_t ctx_bytes = {0};
@@ -109,9 +108,8 @@ parser_error_t schema_display_integer(parser_context_t *ctx, parser_tx_t *txObj,
     return parser_ok;
 }
 
-parser_error_t schema_display_byte_array(parser_context_t *ctx, parser_tx_t *txObj, primitive_byte_array_t *byte_array) {
+parser_error_t schema_display_byte_array(parser_context_t *ctx, primitive_byte_array_t *byte_array) {
     CHECK_INPUT(ctx);
-    CHECK_INPUT(txObj);
     CHECK_INPUT(byte_array);
 
     parser_context_t ctx_bytes = {0};
@@ -128,9 +126,8 @@ parser_error_t schema_display_byte_array(parser_context_t *ctx, parser_tx_t *txO
     return parser_ok;
 }
 
-parser_error_t schema_display_primitive(parser_context_t *ctx, parser_tx_t *txObj, primitive_t *primitive) {
+parser_error_t schema_display_primitive(parser_context_t *ctx, primitive_t *primitive) {
     CHECK_INPUT(ctx);
-    CHECK_INPUT(txObj);
 
     uint16_t primitive_size = sizeof(primitive);
     print_u16("Primitive size: ", primitive_size);
@@ -141,12 +138,12 @@ parser_error_t schema_display_primitive(parser_context_t *ctx, parser_tx_t *txOb
         case PRIMITIVE_INTEGER:
             primitive_size = sizeof(primitive->integer);
             print_u16("Primitive size integer_0: ", primitive_size);
-            CHECK_ERROR(schema_display_integer(ctx, txObj, &primitive->integer));
+            CHECK_ERROR(schema_display_integer(ctx, &primitive->integer));
             break;
         case PRIMITIVE_BYTE_ARRAY:
             primitive_size = sizeof(primitive->byte_array);
             print_u16("Primitive size byte_array: ", primitive_size);
-            CHECK_ERROR(schema_display_byte_array(ctx, txObj, &primitive->byte_array));
+            CHECK_ERROR(schema_display_byte_array(ctx, &primitive->byte_array));
             break;
         case PRIMITIVE_BYTE_VEC:
             // TODO: Implement me
@@ -254,7 +251,7 @@ parser_error_t schema_display_struct(parser_context_t *ctx, parser_tx_t *txObj)
                     CHECK_ERROR(schema_display_generic_by_index(ctx, txObj, named_field.value.data.by_index));
                     break;
                 case LINK_IMMEDIATE:
-                    CHECK_ERROR(schema_display_primitive(ctx, txObj, &named_field.value.data.immediate));
+                    CHECK_ERROR(schema_display_primitive(ctx, &named_field.value.data.immediate));
                     break;
                 default:
                     print_string("schema_display_struct IMPLEMENT ME 1");
@@ -323,7 +320,7 @@ parser_error_t schema_display_tuple(parser_context_t *ctx, parser_tx_t *txObj) {
                     CHECK_ERROR(schema_display_generic_by_index(ctx, txObj, unnamed_field.value.data.by_index));
                     break;
                 case LINK_IMMEDIATE:
-                    CHECK_ERROR(schema_display_primitive(ctx, txObj, &unnamed_field.value.data.immediate));
+                    CHECK_ERROR(schema_display_primitive(ctx, &unnamed_field.value.data.immediate));
                     break;
                 default:
                     print_string("Tuple field is not a link by index\n");
@@ -375,7 +372,7 @@ parser_error_t schema_display_option(parser_context_t *ctx, parser_tx_t *txObj)
             CHECK_ERROR(schema_display_generic_by_index(ctx, txObj, option_type.value.data.by_index));
             break;
         case LINK_IMMEDIATE:
-            CHECK_ERROR(schema_display_primitive(ctx, txObj, &option_type.value.data.immediate));
+            CHECK_ERROR(schema_display_primitive(ctx, &option_type.value.data.immediate));
             break;
         default:
             print_string("Option field is not a link by index\n");
@@ -406,7 +403,7 @@ parser_error_t schema_display_array(parser_context_t *ctx, parser_tx_t *txObj) {
                 }
                 break;
             case LINK_IMMEDIATE: {
-                CHECK_ERROR(schema_display_primitive(ctx, txObj, &array_type.value.data.immediate));
+                CHECK_ERROR(schema_display_primitive(ctx, &array_type.value.data.immediate));
                 if (!is_data_context_empty()) {
                     CHECK_ERROR(push_item(txObj));
                     CHECK_ERROR(remove_last_item_title());
@@ -447,7 +444,7 @@ parser_error_t schema_display_vec(parser_context_t *ctx, parser_tx_t *txObj) {
                 char index_str[12];
                 snprintf(index_str, sizeof(index_str), "%d", i);
                 CHECK_ERROR(append_item_title(index_str, strlen(index_str)));
-                CHECK_ERROR(schema_display_primitive(ctx, txObj, &vec_type.value.data.immediate));
+                CHECK_ERROR(schema_display_primitive(ctx, &vec_type.value.data.immediate));
                 if (!is_data_context_empty()) {
                     CHECK_ERROR(push_item(txObj));
                     CHECK_ERROR(remove_last_item_title());
@@ -529,7 +526,5 @@ parser_error_t schema_parser_transaction(parser_context_t *ctx, parser_tx_t *txO
 
     txObj->unsigned_transaction_raw.buffer.len = ctx->offset - offset_mem_txn;
 
-    // CHECK_ERROR(test_schema_create_device_items());
-
     return parser_ok;
 }