Skip to content

Commit b26d8a2

Browse files
0xPxtabenso
andauthored
Use only original output directories (#191)
* Use only original output directories * Bump version --------- Co-authored-by: abenso <andresbenso@gmail.com>
1 parent 4abbe96 commit b26d8a2

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

dockerized_build.mk

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ TESTS_JS_DIR?=
2323
LEDGER_SRC=$(CURDIR)/app
2424
FUZZ_COVERAGE_DIR=$(CURDIR)/fuzz/coverage
2525
DOCKER_APP_SRC=/app
26-
DOCKER_APP_BIN=$(DOCKER_APP_SRC)/app/bin/app.elf
26+
# Note: BIN_DIR is now build/<TARGET>/bin, but this variable is kept for reference
27+
# The actual path varies by target: build/nanox/bin, build/nanos2/bin, etc.
28+
DOCKER_APP_BIN=$(DOCKER_APP_SRC)/app/build/$(TARGET)/bin/app.elf
2729

2830
DOCKER_BOLOS_SDKS = NANOS_SDK
2931
DOCKER_BOLOS_SDKX = NANOX_SDK

include/zxversion.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@
1616
#pragma once
1717

1818
#define ZXLIB_MAJOR 39
19-
#define ZXLIB_MINOR 0
19+
#define ZXLIB_MINOR 1
2020
#define ZXLIB_PATCH 0

makefiles/Makefile.installer_script

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#*******************************************************************************
22
# Ledger App
3-
# (c) 2018 - 2023 Zondax AG
3+
# (c) 2018 - 2024 Zondax AG
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
66
# you may not use this file except in compliance with the License.
@@ -15,6 +15,11 @@
1515
# limitations under the License.
1616
#*******************************************************************************
1717

18+
# BIN_DIR is defined by the SDK in Makefile.target (included via Makefile.standard_app)
19+
# Path structure: build/<TARGET>/bin (e.g., build/nanox/bin, build/stax/bin)
20+
# This fallback ensures compatibility if BIN_DIR is not yet defined
21+
BIN_DIR ?= $(CURDIR)/build/$(TARGET)/bin
22+
1823
all: default
1924
@echo "#!/usr/bin/env bash" > $(OUTPUT_INSTALLER)
2025
@echo "APPNAME=\"${APPNAME}\"" >> $(OUTPUT_INSTALLER)
@@ -23,10 +28,10 @@ all: default
2328
@echo "LOAD_PARAMS=($$(echo "${APP_LOAD_PARAMS}" | sed -e "s|"${APPNAME}"|\""${APPNAME}"\"|"))" >> $(OUTPUT_INSTALLER)
2429
@echo "DELETE_PARAMS=($$(echo "${COMMON_DELETE_PARAMS}" | sed -e "s|"${APPNAME}"|\""${APPNAME}"\"|"))" >> $(OUTPUT_INSTALLER)
2530
@echo "APPHEX=\"" >> $(OUTPUT_INSTALLER)
26-
@cat $(CURDIR)/bin/app.hex >> $(OUTPUT_INSTALLER)
31+
@cat $(BIN_DIR)/app.hex >> $(OUTPUT_INSTALLER)
2732
@echo "\"" >> $(OUTPUT_INSTALLER)
2833
@cat $(CURDIR)/../deps/ledger-zxlib/scripts/template.sh >> $(OUTPUT_INSTALLER)
2934
@chmod +x $(OUTPUT_INSTALLER)
30-
@cp $(CURDIR)/bin/* $(CURDIR)/output
35+
@cp $(BIN_DIR)/* $(CURDIR)/output
3136
@cp $(CURDIR)/output/app.elf ${OUTPUT_ELF}
3237
@rm $(CURDIR)/output/app.elf

0 commit comments

Comments
 (0)