feat: Add container pooling for 60-80% faster test execution (#549)

* feat: modernize Zemu codebase to Zondax standards (#547)

* modernize

* refactor: migrate to biome and standardize code style across project

* chore: update biome lint command and add fix script alias

* style: standardize quotes to single quotes and fix formatting

* refactor: replace forEach loops with for...of and remove unnecessary async keywords

* refactor: replace forEach loops with for...of and remove unnecessary async declarations

* ci: update workflow commands and disable coverage in ci-ts pipeline

* temporarily disable docker

* Modernize codebase (#548)

* activate testing in ci

* ci: remove frozen lockfile in CI workflow

* feat: implement container pooling system for device emulation

* fix: address CodeRabbit review comments

- Fix YAML linting issues in GitHub workflow files
  - Remove trailing spaces in ci-ts.yaml
  - Add missing newlines at end of YAML files
- Fix typo: settingsNavnavLeftButton → settingsNavLeftButton
- Organize imports in containerPool.ts (external packages first)
- Remove unused model variable in cleanup() method
- Apply automated code formatting improvements

* fix: address additional CodeRabbit review comments

- Fix missing parentheses in tests/minapp/index.ts toString() call
- Add error handling to gRPC exchange promise chain
- Remove async modifier from globalsetup.ts (no await needed)
- Add race condition protection for pool initialization
- Document DEV_CERT_PRIVATE_KEY as development-only test key

* fix: resolve remaining CI issues and CodeRabbit comments

- Fix trailing spaces in .github/dependabot.yml
- Add missing await to async operations in tests/pullImageKillOld.ts
- Wrap async calls in IIFE to prevent CI hanging on cleanup

This should resolve the hanging CI build and address the remaining
CodeRabbit linting issues.

Author: jleni

.eslintrc.json

@@ -1,25 +1,25 @@
-# Basic dependabot.yml file with
-# minimum configuration for two package managers
-
 version: 2
 updates:
-  # Enable version updates for npm
   - package-ecosystem: "npm"
-    # Look for `package.json` and `lock` files in the `root` directory
     directory: "/"
-    # Check the npm registry for updates every day (weekdays)
     schedule:
       interval: "daily"
-    target-branch: dev
+    commit-message:
+      prefix: "deps"
+    open-pull-requests-limit: 5
+    target-branch: "main"
+    groups:
+      all:
+        patterns: ["*"]
+    ignore:
+      # Ignore major version updates for stability
+      - dependency-name: "*"
+        update-types: ["version-update:semver-major"]
 
-  # Enable version updates for GitHub Actions
-  - package-ecosystem: 'github-actions'
-    directory: '/'
+  - package-ecosystem: "github-actions"
+    directory: "/"
     schedule:
-      interval: 'daily'
-      time: '11:00'
+      interval: "daily"
     commit-message:
-      prefix: 'chore'
-      prefix-development: 'chore'
-      include: 'scope'
-    target-branch: dev
+      prefix: "ci"
+    target-branch: "main"

.github/dependabot.yml

@@ -0,0 +1,47 @@
+name: CI-ts
+
+on:
+  push:
+    branches: [main, dev]
+  pull_request:
+    branches: [main, dev]
+  schedule:
+    - cron: "0 0 * * *" # Daily at midnight UTC
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.head.ref || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  ts-checks:
+    uses: zondax/_workflows/.github/workflows/_checks-ts.yaml@main
+    with:
+      package_manager: pnpm
+      node_version: "22"
+      enable_tests: false  # Disable tests here since they need Docker
+      enable_coverage: false
+      test_command: "test"
+      lint_command: "check"
+      format_command: "check"
+
+  test-with-docker:
+    runs-on: ubuntu-latest
+    needs: ts-checks
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 8
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+          cache: 'pnpm'
+      - name: Install dependencies
+        run: pnpm install
+      - name: Run tests with Docker
+        run: pnpm test
+        env:
+          DISPLAY: :99

.github/workflows/ci-ts.yaml

@@ -1,55 +1,24 @@
-name: Publish package
+name: Publish NPM Package
 
 on:
   release:
-    types:
-      - created
+    types: [created]
+  push:
     tags:
-      - "v[0-9]+(\\.[0-9]+)*"
+      - "v[0-9]+"
+      - "v[0-9]+.[0-9]+"
+      - "v[0-9]+.[0-9]+.[0-9]+"
+      - "v[0-9]+.[0-9]+.[0-9]+-*"
 
-jobs:
-  build-test:
-    name: Build and Test
-    timeout-minutes: 5
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          submodules: true
-      - name: Install node
-        uses: actions/setup-node@v4
-      - run: npm install -g yarn
-      - run: yarn install
-      - run: yarn build
-      - run: yarn test
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: false
 
-  publish:
-    timeout-minutes: 5
-    runs-on: ubuntu-latest
-    needs: [build-test]
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          submodules: true
-      - name: Install node
-        uses: actions/setup-node@v4
-        with:
-          registry-url: "https://registry.npmjs.org"
-          scope: "@zondax"
-      - run: npm install -g yarn
-      - run: yarn install
-      - run: yarn build
-      - run: mv README-npm README.md
-      - name: Get latest release version number
-        id: get_version
-        run: echo "version=${GITHUB_REF##*/}" >> $GITHUB_OUTPUT
-      - name: Show version
-        run: echo ${{ steps.get_version.outputs.version }}
-      - name: Update tag
-        run: npm --no-git-tag-version version ${{ steps.get_version.outputs.version }}
-      - name: Publish package
-        run: npm publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_PUBLISH_AUTO }}
+jobs:
+  publish-npm:
+    uses: zondax/_workflows/.github/workflows/_publish-npm.yaml@main
+    with:
+      timeout_minutes: 10
+      dry_run: false
+    secrets:
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN_PUBLISH_AUTO }}

.github/workflows/main.yml

@@ -173,3 +173,5 @@ dist
 
 # Finder (MacOS) folder config
 .DS_Store
+tests/snapshots-tmp/
+

.github/workflows/publish.yml

@@ -0,0 +1,31 @@
+[tools]
+node = "22"
+pnpm = "latest"
+
+[env]
+# Ensure pnpm uses the correct Node.js version
+NODE_ENV = "development"
+
+[tasks.install]
+description = "Install dependencies"
+run = "pnpm install"
+
+[tasks.build]
+description = "Build the project"
+run = "pnpm build"
+
+[tasks.test]
+description = "Run tests"
+run = "pnpm test"
+
+[tasks.check]
+description = "Run linting and formatting checks"
+run = "pnpm check"
+
+[tasks.dev]
+description = "Development setup"
+run = [
+  "pnpm install",
+  "pnpm check",
+  "pnpm build"
+]

.gitignore

@@ -0,0 +1 @@
+22