Make the transport proxy throw exceptions on every sw except 0x9000 (#566)

Author: 0xPxt

package.json

@@ -42,6 +42,7 @@
     "@grpc/grpc-js": "^1.13.4",
     "@grpc/proto-loader": "^0.7.15",
     "@ledgerhq/hw-transport-http": "^6.30.8",
+    "@ledgerhq/errors": "^6.23.0",
     "axios": "^1.11.0",
     "axios-retry": "^4.5.0",
     "dockerode": "^4.0.7",

pnpm-lock.yaml

@@ -15,6 +15,7 @@
  ******************************************************************************* */
 
 import { resolve } from 'node:path'
+import { TransportStatusError } from '@ledgerhq/errors'
 import type Transport from '@ledgerhq/hw-transport'
 import HttpTransport from '@ledgerhq/hw-transport-http'
 import axios, { type AxiosResponse } from 'axios'
@@ -66,6 +67,10 @@ import {
 } from './types'
 import { isTouchDevice, zondaxToggleBlindSigning, zondaxToggleExpertMode, zondaxTouchEnableSpecialMode } from './zondax'
 
+enum ApduError {
+  NoError = 0x9000,
+}
+
 export default class Zemu {
   public startOptions!: IStartOptions
 
@@ -458,6 +463,11 @@ export default class Zemu {
             try {
               self.lastTransportError = null // Clear previous error
               const result = await target.send(cla, ins, p1, p2, data, statusList)
+              const sw = result.readUInt16BE(result.length - 2)
+
+              if (sw !== ApduError.NoError) {
+                throw new TransportStatusError(sw)
+              }
               return result
             } catch (error) {
               // Store the error for later checks

src/Zemu.ts

@@ -29,13 +29,16 @@ describe('Error Handling', () => {
       const validINS = 0x00
       const p1 = 0x00
       const p2 = 0x00
+      const data = Buffer.from([])
+      // Provide a statusList to make sure zemu throws an exception even on accepted status words
+      const statusList = [0x9000, 0x6e00]
 
       // Start timer to measure how long the error takes
       const startTime = Date.now()
 
       try {
         // This should fail with CLA_NOT_SUPPORTED (0x6E00)
-        await transport.send(invalidCLA, validINS, p1, p2)
+        await transport.send(invalidCLA, validINS, p1, p2, data, statusList)
 
         // If we get here, the test failed - we expected an error
         expect.fail('Expected transport.send to throw an error')