Linter fixes

Author: raynaudoe

connections/data_source.go

@@ -52,24 +52,28 @@ func WithRetryDelay(delay time.Duration) SourceOption {
 }
 
 func WithPostgresDB(dbConn *gorm.DB) SourceOption {
+	checkPointer(dbConn)
 	return func(w *DataSource) {
 		w.DatabasePostgres = dbConn
 	}
 }
 
 func WithMongoDB(dbConn *mongo.Client) SourceOption {
+	checkPointer(dbConn)
 	return func(w *DataSource) {
 		w.DatabaseMongo = dbConn
 	}
 }
 
 func WithRosettaClient(client *client.APIClient) SourceOption {
+	checkPointer(client)
 	return func(w *DataSource) {
 		w.RosettaClient = client
 	}
 }
 
 func WithNodeClient(node interface{}) SourceOption {
+	checkPointer(node)
 	return func(w *DataSource) {
 		w.NodeClient = node
 	}
@@ -84,3 +88,9 @@ func WithDataStore(cfg ds.DataStoreConfig) SourceOption {
 		w.DataStore = storeClient
 	}
 }
+
+func checkPointer(p interface{}) {
+	if p == nil {
+		panic("Pointer cannot be null!")
+	}
+}

connections/database/graphql/graphql.go

@@ -26,32 +26,32 @@ type GraphqlSubscriptionClient struct {
 	connected bool
 }
 
-func NewGraphqlQueryClient(host string, token string) GraphqlClient {
+func NewGraphqlQueryClient(host string, token string) *GraphqlClient {
 	transport := http.DefaultTransport
 	if token != "" {
 		transport = database.AuthHeaderTransport{Transport: http.DefaultTransport, Token: token}
 	}
 
 	customHttpClient := http.Client{Transport: transport}
-	return GraphqlClient{
+	return &GraphqlClient{
 		Host:   host,
 		Client: graphql.NewClient(host, &customHttpClient),
 	}
 }
 
-func (c GraphqlClient) Connect() error {
+func (c *GraphqlClient) Connect() error {
 	return nil
 }
 
-func NewGraphqlSubscriptionClient(host string, token string) (error, GraphqlSubscriptionClient) {
+func NewGraphqlSubscriptionClient(host string, token string) (error, *GraphqlSubscriptionClient) {
 	client := graphql.NewSubscriptionClient(host).
 		WithConnectionParams(map[string]interface{}{
 			"headers": map[string]string{
 				"x-hasura-admin-secret": token,
 			},
 		}).OnError(onClientError)
 
-	subClient := GraphqlSubscriptionClient{
+	subClient := &GraphqlSubscriptionClient{
 		Client:    client,
 		errChan:   make(chan error),
 		readyChan: make(chan bool),
@@ -64,13 +64,13 @@ func NewGraphqlSubscriptionClient(host string, token string) (error, GraphqlSubs
 	return nil, subClient
 }
 
-func (c GraphqlSubscriptionClient) onClientConnected() {
+func (c *GraphqlSubscriptionClient) onClientConnected() {
 	zap.S().Infof("Graphql client connected")
 	c.connected = true
 	c.readyChan <- true
 }
 
-func (c GraphqlSubscriptionClient) onClientDisconnected() {
+func (c *GraphqlSubscriptionClient) onClientDisconnected() {
 	zap.S().Warnf("Graphql client disconnected")
 	c.connected = false
 	c.readyChan <- false
@@ -81,7 +81,7 @@ func onClientError(sc *graphql.SubscriptionClient, err error) error {
 	return err
 }
 
-func (c GraphqlSubscriptionClient) Subscribe(query interface{}, handler func(message *json.RawMessage, err error) error) error {
+func (c *GraphqlSubscriptionClient) Subscribe(query interface{}, handler func(message *json.RawMessage, err error) error) error {
 	id, err := c.Client.Subscribe(query, nil, handler)
 	if err != nil {
 		return err
@@ -90,15 +90,15 @@ func (c GraphqlSubscriptionClient) Subscribe(query interface{}, handler func(mes
 	return nil
 }
 
-func (c GraphqlSubscriptionClient) Unsubscribe() error {
+func (c *GraphqlSubscriptionClient) Unsubscribe() error {
 	err := c.Client.Unsubscribe(c.Id)
 	if err != nil {
 		return err
 	}
 	return nil
 }
 
-func (c GraphqlSubscriptionClient) Start() error {
+func (c *GraphqlSubscriptionClient) Start() error {
 	go func() {
 		err := c.Client.Run()
 		if err != nil {
@@ -118,10 +118,10 @@ func (c GraphqlSubscriptionClient) Start() error {
 	}
 }
 
-func (c GraphqlSubscriptionClient) Stop() error {
+func (c *GraphqlSubscriptionClient) Stop() error {
 	return c.Client.Close()
 }
 
-func (c GraphqlSubscriptionClient) GetState() bool {
+func (c *GraphqlSubscriptionClient) GetState() bool {
 	return c.connected
 }

workers/workQueue/dispatcher.go

@@ -21,7 +21,7 @@ type DispatcherConfig struct {
 	JobsTopic string
 }
 
-func NewJobDispatcher() JobDispatcher {
+func NewJobDispatcher() *JobDispatcher {
 	d := JobDispatcher{
 		retryTimeout:   DefaultRetryTimeout,
 		jobPool:        NewJobPool(),
@@ -31,14 +31,14 @@ func NewJobDispatcher() JobDispatcher {
 		EmptyQueueChan: make(chan bool),
 	}
 
-	return d
+	return &d
 }
 
-func (j JobDispatcher) SetRetryTimeout(timeout time.Duration) {
+func (j *JobDispatcher) SetRetryTimeout(timeout time.Duration) {
 	j.retryTimeout = timeout
 }
 
-func (j JobDispatcher) BuildWorkers(count int, constructor WorkerConstructor) {
+func (j *JobDispatcher) BuildWorkers(count int, constructor WorkerConstructor) {
 	for i := 0; i < count; i++ {
 		workerId := fmt.Sprintf("worker.%d", i)
 		worker := constructor(workerId, j.workerChan)
@@ -47,7 +47,7 @@ func (j JobDispatcher) BuildWorkers(count int, constructor WorkerConstructor) {
 }
 
 // TODO listen for incoming jobs on JobsTopic
-func (j JobDispatcher) Start() {
+func (j *JobDispatcher) Start() {
 	j.dispatch()
 	for {
 		work := j.jobPool.GetNewJob()
@@ -62,11 +62,11 @@ func (j JobDispatcher) Start() {
 	}
 }
 
-func (j JobDispatcher) EnqueueWork(w Work) {
+func (j *JobDispatcher) EnqueueWork(w Work) {
 	j.jobPool.EnqueueJob(w)
 }
 
-func (j JobDispatcher) dispatch() {
+func (j *JobDispatcher) dispatch() {
 	go func() {
 		for {
 			select {