gap-analysis.md

Gap Analysis: EGO Review Guidelines vs Plugin Coverage

Date: 2026-02-25 Method: Every MUST requirement from requirements-reference.md was checked against the plugin's Tier 1 pattern rules (rules/patterns.yaml), Tier 2 scripts (skills/ego-lint/scripts/), and Tier 3 checklists (skills/ego-review/references/).

---

Legend

• Covered: An automated check (Tier 1 or Tier 2) directly enforces this requirement.
• Partial: A check exists but only catches some cases or uses heuristics that can miss violations.
• Tier 3 Only: Covered by a review checklist read by Claude during ego-review, but no automated check.
• Uncovered: No automated check and no checklist item addresses this requirement.

---

Section 1: Initialization and Lifecycle

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST NOT create objects during initialization (constructor/import time)	MUST	Partial	R-QUAL-08 (check-quality.py constructor-resources)	Only checks constructor bodies for known bad patterns (getSettings, connect, timeout_add, DBusProxy). Does NOT detect GObject creation (e.g., new St.Widget(), new Gio.Settings()) in constructors. Does not check module-level code (import-time side effects).
MUST NOT connect signals during initialization	MUST	Partial	R-QUAL-08 (check-quality.py constructor-resources)	Checks for .connect() in constructors, but skips widget subclass constructors (by design). Does not check module-level signal connections.
MUST NOT add main loop sources during initialization	MUST	Partial	R-QUAL-08 (check-quality.py constructor-resources)	Checks for timeout_add in constructors. Does not check module-level timeout_add/idle_add.
MUST NOT modify GNOME Shell during initialization	MUST	Covered	R-INIT-01 (check-init.py)	Detects Shell global access (Main.panel, Main.overview, etc.) at module scope and in constructors.
All GObject classes disallowed during init	MUST	Covered	R-INIT-01 (check-init.py), R-QUAL-08 (check-quality.py)	check-init.py detects GObject constructors (new St., new Gio., new GLib., new Clutter.) at module scope and in constructors via expanded regex.

Section 2: Object and Resource Cleanup

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Objects/widgets created MUST be destroyed in disable()	MUST	Partial	R-LIFE-01 (signal balance), R-LIFE-02 (untracked timeouts), R-LIFE-09 (keybinding), check-lifecycle.py	Heuristic checks for signal balance and timeout tracking. No general "widget created in enable() but not destroyed in disable()" check.
All dynamically stored memory MUST be cleared in disable()	MUST	Partial	lifecycle-checklist.md, check-lifecycle.py destroy-no-null	Checklist covers nulling references. Automated check warns when .destroy() is not followed by = null on the same variable. Does not cover all memory clearing scenarios.
If run_dispose() is used, MUST include comment explaining why	MUST (if used)	Covered	R-SEC-06 (pattern: .run_dispose(), R-QUAL-21 (check-quality.py run_dispose-comment)	Detects run_dispose() usage AND verifies a comment exists on the same or preceding line explaining the need.

Section 3: Signal Management

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Any signal connections MUST be disconnected in disable()	MUST	Partial	R-LIFE-01 (check-lifecycle.py signal-balance)	Heuristic balance check (warns if connects > disconnects + 2). Does not trace individual signals to verify each one is disconnected.
Handler IDs MUST be stored for later disconnection	MUST	Partial	R-LIFE-01 (indirect)	The signal balance check implicitly catches the worst cases, but unstored handler IDs from .connect() are not directly flagged.

Section 4: Main Loop Sources

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
All main loop sources MUST be removed in disable()	MUST	Covered	R-LIFE-02 (check-lifecycle.py untracked-timeout), R-LIFE-12 (check-lifecycle.py source-remove-verify)	Checks if return values are assigned AND verifies GLib.Source.remove() is called in disable() for stored IDs.
Sources MUST be removed even if callback returns GLib.SOURCE_REMOVE	MUST	Tier 3 Only	lifecycle-checklist.md	Checklist mentions this. No automated verification.

Section 5: Library and Import Restrictions

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST NOT import Gdk in Shell process	MUST	Covered	R-IMPORT-02, check-imports.sh	Checks gi://Gdk in extension.js and lib/**/*.js.
MUST NOT import Gtk in Shell process	MUST	Covered	R-IMPORT-01, check-imports.sh	Checks gi://Gtk in extension.js and lib/**/*.js.
MUST NOT import Adw in Shell process	MUST	Covered	R-IMPORT-03, check-imports.sh	Checks gi://Adw in extension.js and lib/**/*.js.
MUST NOT import Clutter in preferences	MUST	Covered	R-IMPORT-04, check-imports.sh	Checks gi://Clutter in prefs.js.
MUST NOT import Meta in preferences	MUST	Covered	R-IMPORT-05, check-imports.sh	Checks gi://Meta in prefs.js.
MUST NOT import St in preferences	MUST	Covered	R-IMPORT-06, check-imports.sh	Checks gi://St in prefs.js.
MUST NOT import Shell in preferences	MUST	Covered	R-IMPORT-07, check-imports.sh	Checks gi://Shell in prefs.js.

Section 6: Deprecated Modules

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST NOT import ByteArray	MUST	Covered	R-DEPR-03, ego-lint.sh no-deprecated-modules	Both pattern rule and inline check.
MUST NOT import Lang	MUST	Covered	R-DEPR-02, ego-lint.sh no-deprecated-modules	Both pattern rule and inline check.
MUST NOT import Mainloop	MUST	Covered	R-DEPR-01, ego-lint.sh no-deprecated-modules	Both pattern rule and inline check.
MUST NOT use imports.misc.extensionUtils	MUST	Covered	R-DEPR-05	Pattern matches ExtensionUtils.

Section 7: Code Quality and Readability

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Code MUST NOT be minified	MUST	Covered	R-FILE-06, ego-lint.sh minified-js	Checks for lines > 500 chars and webpack boilerplate.
Code MUST NOT be obfuscated	MUST	Partial	R-FILE-06 (minified-js)	Minification check catches some obfuscation (long lines). No specific check for obfuscation techniques (encoded strings, variable mangling without long lines).
TypeScript MUST be transpiled to well-formatted JavaScript	MUST	Partial	R-FILE-06	Would catch poorly-transpiled TS (minified output). Well-formatted but clearly machine-generated TS output is not flagged.
MUST NOT print excessively to log	MUST	Covered	R-LOG-01 (console.log), R-QUAL-13 (debug volume), R-QUAL-17 (logging volume), ego-lint.sh no-console-log	console.log is hard FAIL. Excessive console.debug/warn/error volumes are WARN.
Code MUST be formatted in a way that can be easily reviewed	MUST	Partial	R-FILE-06 (minified), R-QUAL-10 (code volume), R-QUAL-12 (file complexity)	Catches minification and excessive size. No check for poor formatting (inconsistent indentation, no line breaks).

Section 8: AI-Generated Code

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Extensions MUST NOT be submitted if primarily AI-generated	MUST	Partial	R-SLOP-01 through R-SLOP-30, R-QUAL-01 through R-QUAL-28, ai-slop-checklist.md (46 items)	Multiple heuristic signals (try-catch density, hallucinated APIs, typeof super, comment density, impossible state, pendulum pattern, null check density, spread copies, instanceof Error, empty destroy overrides, custom loggers, dir.get_path, repeated getSettings, version string comparison). Tier 3 checklist has 46 detailed items. Inherently hard to fully automate.
Developers MUST be able to justify and explain submitted code	MUST	Tier 3 Only	ai-slop-checklist.md	Semantic requirement; only addressable during human/AI code review.

Section 9: Metadata Requirements

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
uuid must be present	MUST	Covered	R-META-01 (check-metadata.py)
uuid format: only alphanumeric + . _ - @	MUST	Covered	R-META-03 (check-metadata.py)
uuid must contain @	MUST	Covered	R-META-13 (check-metadata.py)
MUST NOT use gnome.org as namespace	MUST	Covered	R-META-04 (check-metadata.py)
Directory name MUST match UUID	MUST	Covered	R-META-02 (check-metadata.py)
name must be present	MUST	Covered	R-META-05 (check-metadata.py)
description must be present	MUST	Covered	R-META-06 (check-metadata.py)
shell-version must be array	MUST	Covered	R-META-07 (check-metadata.py)
shell-version MUST contain only stable releases	MUST	Partial	R-META-17 (future-shell-version), R-META-23 (dev-limit)	Warns on future versions and multiple dev releases. Does NOT validate that entries are actual released GNOME versions (e.g., would not reject "99" or "37").
MUST NOT claim support for future versions	MUST	Partial	R-META-17 (check-metadata.py)	Issues WARN (not FAIL) for versions > current stable. Guidelines say this is a hard reject.
url field required for EGO	MUST	Partial	R-META-22 (check-metadata.py)	Issues WARN, not FAIL. Guidelines say MUST for EGO submission.
session-modes MUST be dropped if only ["user"]	MUST	Partial	R-META-09 (check-metadata.py)	Issues WARN, not FAIL. Guidelines explicitly call this a hard reject.
donations MUST only contain valid keys	MUST	Covered	R-META-18 (check-metadata.py)	FAIL on invalid keys.
donations MUST be dropped if not used	MUST	Covered	R-META-24 (check-metadata.py)	FAIL on empty donations.
version-name format validation	MUST	Covered	R-META-20 (check-metadata.py)	Validates 1-16 char regex.

Section 10: GSettings Schema Requirements

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Schema ID MUST use org.gnome.shell.extensions as base	MUST	Covered	R-SCHEMA-02, R-META-10, check-schema.sh	Validated in both metadata and schema XML.
Schema path MUST use /org/gnome/shell/extensions/ as base	MUST	Covered	R-SCHEMA-03, check-schema.sh	Validates path prefix and trailing slash.
Schema XML file MUST be included if settings-schema declared	MUST	Covered	R-SCHEMA-01, check-schema.sh	FAIL if metadata declares schema but no XML found.
Schema XML filename MUST follow <schema-id>.gschema.xml	MUST	Partial	R-SCHEMA-05, check-schema.sh	Issues WARN, not FAIL. Guidelines say MUST.

Section 11: Packaging and File Requirements

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Extension MUST contain extension.js	MUST	Covered	R-FILE-01, ego-lint.sh file-structure/extension.js
Extension MUST contain metadata.json	MUST	Covered	R-FILE-02, ego-lint.sh file-structure/metadata.json
MUST NOT include binary executables or libraries	MUST	Covered	R-FILE-04, R-PKG-13, ego-lint.sh no-binary-files	Checks file extensions + ELF magic bytes.

Section 12: Security and Privacy

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Clipboard access MUST be declared in description	MUST	Covered	quality/clipboard-disclosure (check-quality.py)	Detects St.Clipboard and verifies metadata description mentions clipboard. R-SEC-07 removed (was redundant).
MUST NOT share clipboard data with third parties without explicit user interaction	MUST	Tier 3 Only	security-checklist.md	Requires semantic review of clipboard + network code flow.
MUST NOT ship with default keyboard shortcuts for clipboard interaction	MUST	Covered	R-SEC-16 (check-lifecycle.py clipboard-keybinding)	Cross-references St.Clipboard and addKeybinding in same file.
MUST NOT use telemetry tools to track users	MUST	Covered	R-SEC-08 (pattern: analytics/telemetry/trackEvent/etc.)	Pattern-based detection of common telemetry identifiers.
MUST NOT share user data online	MUST	Tier 3 Only	security-checklist.md	Requires semantic analysis of network requests and data payloads.

Section 13: Subprocess and Script Requirements

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Privileged subprocess MUST use pkexec (not sudo directly)	MUST	Covered	R-SEC-04 (sudo detection, blocking), R-SEC-20 (pkexec advisory)	R-SEC-04 now only flags sudo (blocking). R-SEC-20 flags pkexec as advisory for reviewer scrutiny. Split enforces pkexec-only policy.
Privileged subprocess MUST NOT be user-writable executable or script	MUST	Covered	R-SEC-18 (check-lifecycle.py pkexec-user-writable)	Checks pkexec target paths for user-writable locations (/home/, /tmp/, ./, ../).
Scripts MUST be written in GJS unless absolutely necessary	MUST	Covered	ego-lint.sh non-gjs-scripts	FAIL for non-GJS scripts without pkexec justification; WARN with pkexec (privileged helper exception).
MUST NOT include binary executables or libraries	MUST	Covered	R-FILE-04, ego-lint.sh no-binary-files
Scripts MUST be distributed under OSI-approved license	MUST	Tier 3 Only	licensing-checklist.md	Requires manual license review of included scripts.
MUST NOT use synchronous subprocess calls in Shell process	MUST	Covered	R-SEC-14 (pattern: sync subprocess), R-DEPR-08 (upgraded to blocking)	Detects spawn_sync, GLib.spawn_command_line_sync, and other synchronous subprocess patterns. Upgraded to FAIL severity as sync calls block the compositor.

Section 14: Session Modes

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Using unlock-dialog MUST be necessary for correct operation	MUST	Tier 3 Only	lifecycle-checklist.md	Requires semantic understanding of why lock screen access is needed.
All keyboard event signals MUST be disconnected in lock screen mode	MUST	Covered	R-LIFE-11 (check-lifecycle.py lockscreen-signals)	Detects keyboard signals (key-press-event, key-release-event, captured-event) without session mode guards when unlock-dialog is declared.
disable() function MUST include comment explaining why unlock-dialog is used	MUST	Covered	R-LIFE-14 (check-lifecycle.py)	Warns when unlock-dialog declared but disable() has no explanatory comment.
Extensions MUST NOT disable selectively	MUST	Covered	R-LIFE-13 (check-lifecycle.py)	Detects if (...) return; in disable() that skips cleanup.
session-modes field MUST be dropped if only using user	MUST	Partial	R-META-09 (check-metadata.py)	Issues WARN, not FAIL. Should be FAIL per guidelines.

Section 15: Licensing and Attribution

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST be distributed under terms compatible with GPL-2.0-or-later	MUST	Partial	R-FILE-03, ego-lint.sh license	Checks for LICENSE/COPYING file existence (WARN if missing). Does NOT validate license content/compatibility.
Code from other extensions MUST include original author attribution	MUST	Tier 3 Only	licensing-checklist.md (L2)	Requires semantic analysis to detect borrowed code.
Attribution MUST be in distributed files (not just repo)	MUST	Tier 3 Only	licensing-checklist.md (L2)	Requires semantic review.

Section 16: Content and Code of Conduct

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST NOT violate GNOME Code of Conduct	MUST	Tier 3 Only	licensing-checklist.md (L5)	Requires semantic content review. Not automatable.
MUST NOT promote political agendas	MUST	Tier 3 Only	licensing-checklist.md (L4)	Requires semantic content review. Not automatable.
MUST NOT include copyrighted content without permission	MUST	Tier 3 Only	licensing-checklist.md (L3)	Requires asset review. Not automatable.
MUST NOT include trademarked content without permission	MUST	Tier 3 Only	licensing-checklist.md (L3)	Requires asset review. Not automatable.

Section 17: Functionality Requirements

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Extensions that are fundamentally broken MUST be rejected	MUST	Uncovered	--	Requires runtime testing. Not feasible for static analysis.
Extensions with no purpose or functionality MUST be rejected	MUST	Uncovered	--	Requires semantic understanding of extension purpose.

Section 21: Preferences (prefs.js)

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
MUST extend ExtensionPreferences class	MUST	Partial	R-PREFS-02 (check-prefs.py default-export)	Checks for export default class but does NOT verify it extends ExtensionPreferences.
MUST implement fillPreferencesWindow() or getPreferencesWidget()	MUST	Covered	R-PREFS-01 (check-prefs.py)	FAIL if neither method is present. Detects dual-prefs pattern conflict.
MUST use GTK4 and Adwaita (not GTK3)	MUST	Partial	R-PREFS-04 (patterns.yaml), R-PREFS-05 (check-prefs.py)	R-PREFS-04 flags raw GTK widgets (Gtk.Box, Gtk.Label, etc.) instead of Adwaita equivalents. R-PREFS-05 detects GObject memory leaks. Does not detect all GTK3-specific patterns (e.g., Gtk.init(null), Gtk.Box.pack_start).
MUST NOT import Shell, Clutter, Meta, St in prefs	MUST	Covered	R-IMPORT-04 through R-IMPORT-07, check-imports.sh

Section 22: ESModules Migration (GNOME 45+)

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Extension and ExtensionPreferences MUST be default exports	MUST	Covered	R-FILE-07 (check-lifecycle.py), R-PREFS-02 (check-prefs.py)	Checks both extension.js and prefs.js for export default class.
ESM extensions cannot support pre-45 versions	Constraint	Covered	R-META-25 (check-metadata.py esm-version-floor)	FAIL if ESM imports detected with pre-45 shell-version.

Section 24: Monkey-Patching and InjectionManager

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
All monkey patches MUST be restored in disable()	MUST	Covered	Enhanced R-LIFE-10 (check-lifecycle.py)	Detects InjectionManager without .clear() in disable(), and direct prototype.method = assignments without restoration.

Section 26: Network Access and Data Sharing

Guideline Requirement	Severity	Currently Covered?	By Which Rule/Check?	Gap Notes
Content accessed/served MUST NOT violate Code of Conduct	MUST	Tier 3 Only	security-checklist.md	Requires semantic review.
Clipboard data MUST NOT be shared with third parties	MUST	Tier 3 Only	security-checklist.md	Requires analysis of data flow between clipboard and network code.
User data MUST NOT be shared online	MUST	Tier 3 Only	security-checklist.md	Requires semantic analysis of outbound data.

---

Summary: Critical Uncovered MUST Requirements

These MUST requirements have no automated check (not even a partial heuristic):

#	Requirement	Section	Impact	Recommendation
1	MUST NOT ship with default keyboard shortcuts for clipboard interaction	S12	Medium	Covered — R-SEC-16 in check-lifecycle.py
2	Privileged subprocess MUST NOT be user-writable	S13	High	Covered — R-SEC-18 in check-lifecycle.py (pkexec-user-writable)
3	Keyboard event signals MUST be disconnected in lock screen mode	S14	High	Covered — R-LIFE-11 in check-lifecycle.py (lockscreen-signals)
4	disable() MUST include comment explaining unlock-dialog usage	S14	Medium	Covered — R-LIFE-14 in check-lifecycle.py
5	Extensions MUST NOT disable selectively	S14	Medium	Covered — R-LIFE-13 in check-lifecycle.py
6	All monkey patches MUST be restored in disable()	S24	High	Covered — Enhanced R-LIFE-10 in check-lifecycle.py
7	Fundamentally broken / no-purpose extensions	S17	Low	Not feasible for static analysis; inherently a runtime/semantic check

Summary: Severity Mismatches (WARN should be FAIL)

These requirements are correctly detected but the severity level is too low:

Requirement	Current Severity	Correct Severity	Rule	Status
session-modes: ["user"] is redundant	WARN FAIL	FAIL (hard reject)	R-META-09	Fixed
Future shell-version entries	WARN FAIL	FAIL (hard reject)	R-META-17	Fixed
Missing url field in metadata	WARN FAIL	FAIL (for EGO)	R-META-22	Fixed
Schema filename convention mismatch	WARN FAIL	FAIL	R-SCHEMA-05 (check-schema.sh)	Fixed

Summary: Covered but Weak (Partial) Checks

These requirements have checks that catch some but not all violations:

Requirement	Weakness	Improvement	Status
No resource creation in constructors (R-QUAL-08)	Only checks 5 specific patterns; misses arbitrary GObject creation	Expand pattern list: new St., new Gio., new GLib., new Clutter.	Fixed (check-init.py expanded regex)
Signal disconnect balance (R-LIFE-01)	Heuristic tolerance of +2 allows small leaks	Consider tighter threshold or per-signal tracking	Open
Timeout source removal in disable (R-LIFE-02)	Only checks if return value is stored, not if Source.remove is called	Add disable() body scan for matching Source.remove calls	Fixed (R-LIFE-12)
AI-generated code detection (R-SLOP-*)	Pattern-based; misses novel AI patterns	Inherent limitation; Tier 3 checklist compensates	Open (inherent)
Code obfuscation (R-FILE-06)	Only catches minification (long lines); not variable mangling or encoding	Add checks for high entropy variable names or base64-encoded strings	Open
run_dispose comment requirement	Detects usage but not comment	Add lookahead for comment on preceding/same line	Done (R-QUAL-21)
Clipboard disclosure verification	Detects clipboard usage; does not verify description text	Cross-reference with metadata.json description content	Done (quality/clipboard-disclosure; R-SEC-07 removed as redundant)
License file validation (R-FILE-03)	Checks existence only; not content	Parse LICENSE file for GPL-compatible license identifiers (SPDX)	Fixed (GPL-compatibility scanning)
Prefs extends ExtensionPreferences (R-PREFS-02)	Checks export default class but not the extends clause	Regex for export default class \w+ extends ExtensionPreferences	Fixed (R-PREFS-02 strengthened)
Prefs method requirement	Detects dual-pattern conflict; does not fail when neither method present	Add FAIL if prefs.js has no fillPreferencesWindow and no getPreferencesWidget	Done (prefs/missing-prefs-method)

---

Priority Recommendations

P0: Fix severity mismatches (quick wins, no new code needed) -- DONE

1. R-META-09 (session-modes: ["user"]): Change WARN to FAIL Done
2. R-META-17 (future shell-version): Change WARN to FAIL Done
3. R-META-22 (missing url): Change WARN to FAIL Done

P1: Add high-impact missing checks -- DONE

4. InjectionManager cleanup check -- if InjectionManager or overrideMethod found, verify .clear() in disable() -- Done (R-LIFE-10)
5. Constructor GObject creation -- expand R-QUAL-08 patterns to include new St., new Gio., new Clutter., new GLib. Done (check-init.py)
6. GTK3 in prefs.js -- add patterns for GTK3-specific APIs Done (R-PREFS-04)
7. Keyboard signals in unlock-dialog -- if unlock-dialog declared, check for key event signal cleanup Done (R-LIFE-11)

P2: Strengthen existing partial checks -- DONE

8. Timeout removal verification -- verify GLib.Source.remove() in disable() body for stored timeout IDs Done (R-LIFE-12)
9. License content parsing -- basic SPDX identifier detection in LICENSE/COPYING files Done (GPL-compatibility scanning)
10. Prefs ExtensionPreferences extends check -- verify extends clause, not just default export Done (R-PREFS-02 strengthened)
11. Clipboard disclosure cross-reference -- check metadata description for clipboard disclosure when St.Clipboard detected Done (R-QUAL-22)
12. run_dispose comment check -- verify adjacent comment when run_dispose detected Done (R-QUAL-21)

---

Known False Positives and Noise Reduction

These are known false positives and high-noise warnings identified by running ego-lint against hara-hachi-bu, an 11-module extension used as the regression baseline. Each item includes the root cause and a suggested improvement.

Rule / Check	Description	Impact	Suggested Fix
R-PREFS-04b (GTK widget spam)	Every new Gtk.Label(), Gtk.Button(), etc. fires WARN even inside Adw containers. No Adw replacement exists for these widgets.	~43 warnings (48% of output)	Whitelist GTK widgets with no Adw equivalent, or deduplicate to one summary warning
R-PREFS-04 (Gtk.ListBox)	Gtk.ListBox flagged as blocking, but is valid inside Adw.PreferencesGroup for dynamic lists	1 false FAIL	Downgrade to advisory, or suppress when Adw.PreferencesGroup present in same file
R-SEC-20 (pkexec repetition)	Every pkexec string fires WARN across JS, SH, and packaging scripts	~10 identical warnings	Deduplicate to one summary, or correlate with polkit policy presence
quality/module-state	Cache variables (_cachedProfiles, _queueDepth) flagged despite having explicit resetCache() / destroy() cleanup	Low count, misleading	Check for reset/cleanup function that nulls the flagged variables
quality/mock-in-production	MockDevice.js flagged but explicitly excluded from package.sh	2 warnings	Cross-reference with package exclusion list
quality/constructor-resources	.connect() in Adw.ActionRow subclass constructors flagged despite being standard GTK widget construction	~3 false positives	Expand widget subclass exemption to cover Adw.* classes
quality/gettext-pattern	GLib.dgettext() flagged in lib modules where this.gettext() is not available	1 warning (5 locations)	Only flag in extension.js/prefs.js; lib modules correctly use GLib.dgettext()
quality/logging-volume	91 console.* calls across 11 modules (1 per 84 lines) flagged as excessive; threshold of 30 is too low for large extensions	1 warning	Scale threshold by code volume (e.g., 1 call per 100 non-blank lines, minimum 30)
async/missing-cancellable	null cancellable flagged when function uses callback-based cancellation (isCancelled parameter) instead of Gio.Cancellable	5 warnings	Suppress when function signature includes cancellation callback parameter
quality/private-api	quickSettings._indicators flagged with no suppression mechanism; no public API exists for indicator reordering	11 warnings	Support inline // ego-lint-ignore: quality/private-api suppression comments

Estimated impact of fixing the top 2 items (R-PREFS-04b + R-SEC-20): ~53 fewer warnings out of 90 total (59% noise reduction).

---

New Coverage Added (2026-02-26)

The following areas are now covered through Tier 3 review checklists:

Area	Coverage	Where
Accessibility	7 checklist items (A1-A7): accessible-role, label-actor, Atk.StateType sync, keyboard navigation, focus order, color independence, focus chain	code-quality-checklist.md
Notification/dialog lifecycle	MessageTray.Source destroy signal, dialog lifecycle states, stale reference detection	lifecycle-checklist.md
Search provider contract	id/appInfo/canLaunchSearch contract, register/unregister in enable/disable, createIcon scaling	lifecycle-checklist.md
Translation best practices	gettext domain setup, ngettext for plurals, no string concatenation for translated strings	code-quality-checklist.md

New Coverage Added (2026-02-26) — Quality Optimization

Area	New Rules/Checks	Where
Selective disable (R-LIFE-13)	Detects if (...) return; in disable() that skips cleanup	check-lifecycle.py
unlock-dialog comment (R-LIFE-14)	Warns when unlock-dialog declared but disable() has no explanatory comment	check-lifecycle.py
Clipboard + keybinding (R-SEC-16)	Cross-references St.Clipboard and addKeybinding in same file	check-lifecycle.py
Prototype override (enhanced R-LIFE-10)	Detects direct prototype.method = assignments without restoration	check-lifecycle.py
Prefs method existence	Warns when prefs.js has neither fillPreferencesWindow nor getPreferencesWidget	check-prefs.py
run_dispose comment (R-QUAL-21)	Warns when run_dispose() lacks explanatory comment	check-quality.py
Clipboard disclosure (R-QUAL-22)	Cross-references St.Clipboard with metadata description	check-quality.py
CSS shell class override	Warns when stylesheet overrides known Shell theme classes at top level	check-css.py
Gio._promisify placement (R-INIT-02)	Warns when Gio._promisify() is inside enable() instead of module scope	check-init.py
Hallucinated APIs (R-SLOP-24/25/26)	new Gio.Settings(), Main.extensionManager.enable/disable, Shell.ActionMode.ALL	patterns.yaml
Translation anti-pattern (R-I18N-01)	Template literal inside gettext _() breaks xgettext	patterns.yaml
/tmp path security (R-SEC-17)	Hardcoded /tmp paths instead of XDG dirs	patterns.yaml
GNOME 49 compat (R-VER49-06/07)	Clutter.DragAction, Clutter.SwipeAction removed	patterns.yaml

New Coverage Added (2026-02-26) — Batch 1-3 Rules

Area	New Rules/Checks	Where
Compiled schemas in zip (R-PKG-12)	FAIL for gschemas.compiled in zip when targeting GNOME 45+	check-package.sh
Soup.Session abort (R-LIFE-15)	WARN when Soup.Session created without abort() in disable()	check-lifecycle.py
Network disclosure (R-SEC-19)	WARN when HTTP/Soup usage detected without metadata description disclosure	check-quality.py
Prefs memory leak (R-PREFS-05)	WARN for GObject instances stored as class properties without cleanup	check-prefs.py
Empty destroy override (R-SLOP-29)	Advisory for destroy() { super.destroy(); } — GObject chains automatically	patterns.yaml
dir.get_path() anti-pattern (R-QUAL-25)	Advisory: use this.path instead of this.dir.get_path()	patterns.yaml
Custom Logger class (R-QUAL-26)	Advisory: use console.debug/warn/error instead	patterns.yaml
GNOME 50 compat (R-VER50-01/02/03/04)	Blocking: releaseKeyboard, holdKeyboard, show-restart-message, restart signal removed	patterns.yaml

---

New Coverage Added (2026-02-28) — Disclosures, Polkit, Schema Usage, Accessibility

Area	New Rules/Checks	Where
Disclosure matrix (R-DISC-01 through R-DISC-05)	WARN when clipboard/network/pkexec/private-API/file-IO usage detected without metadata description disclosure	check-disclosures.py (migrated from check-quality.py)
Polkit action ID cross-reference (R-POLKIT-01 through R-POLKIT-03)	FAIL on action ID mismatch between .policy and .rules; WARN on non-standard prefix; WARN on missing helper scripts	check-polkit.py
Schema key usage (R-SCHEMA-10, R-SCHEMA-11)	WARN for unused schema keys; FAIL for undefined keys referenced in code	check-schema-usage.py
Accessibility (R-A11Y-01, R-A11Y-02)	WARN for icon-only St.Button without accessible_name; WARN for St.Widget subclass without accessible_role	check-accessibility.py
Code metrics	[METRIC] output: js-files, total-lines, largest-file, css-lines, schema-keys	ego-lint.sh compute_metrics()
Resource graph summary	--summary flag for human-readable resource balance output	build-resource-graph.py

Gaps closed:

• Polkit action ID validation (previously in "Known Limitations")
• Schema key usage cross-reference (new capability)
• Consolidated disclosure checks (clipboard + network migrated, 3 new capabilities added)

---

Rejection Case Studies

Real-world EGO rejections that informed the plugin's detection rules:

Search Light (May 2024) -- Lifecycle Violations

Rejection reason: Signals connected in enable() were not fully disconnected in disable(). Search provider was registered but not unregistered, leading to crashes when the extension was disabled mid-search.

Relevant rules: R-LIFE-01 (signal-balance), lifecycle-checklist.md (search provider cleanup)

Blur my Shell (March 2024) -- Init-Time Violations

Rejection reason: GObject creation (new Gio.Settings()) detected in the extension constructor rather than in enable(). Module-level code was creating Shell modifications at import time.

Relevant rules: R-INIT-01 (check-init.py), R-QUAL-08 (constructor-resources)

Wechsel (April 2024) -- Sync Subprocess, Unnecessary Metadata

Rejection reason: Used GLib.spawn_command_line_sync() to invoke external commands, blocking the compositor. Also included unnecessary metadata fields that were not part of the specification.

Relevant rules: R-SEC-14 (sync subprocess pattern), R-DEPR-08 (blocking subprocess upgraded to FAIL), check-metadata.py (unknown field detection)

Power Tracker (September 2024) -- Missing URL

Rejection reason: Missing url field in metadata.json. EGO requires this field for all submissions to provide users with a link to the extension's source code or homepage.

Relevant rules: R-META-22 (missing url, now FAIL)

Open Bar (February 2024) -- Orphaned Signals, Missing Timeout Cleanup

Rejection reason: Multiple signal connections in helper modules were never disconnected because the cleanup code only covered the main extension file. Timeouts created in a utility module were not tracked or removed in disable().

Relevant rules: R-LIFE-01 (signal-balance), R-LIFE-02 (untracked-timeout), R-LIFE-12 (source-remove-verify), check-resources.py (cross-file orphan detection)