fix(ego-lint): expand R-SLOP-24 guard for system schema identifiers (#139)

## Summary

- Expand R-SLOP-24 guard-pattern to recognize bare system schema
substrings (`desktop.`, `shell.app-switcher`) and `_SCHEMA` constant
names
- Add test fixture `system-schema-bare@test` with three suppression
cases (bare `desktop.interface`, `_SCHEMA` constant, bare
`shell.app-switcher`)
- Update rules-reference.md Guard documentation
- Reclassify dash-to-panel annotation from `fp` to `resolved`

Closes #138

## Test plan

- [x] `bash tests/run-tests.sh` — 742 passed, 0 failed
- [x] `ego-lint system-schema-bare@test` — no R-SLOP-24 warnings
- [x] `ego-lint system-gsettings@test` — no regression
- [x] `ego-lint system-gsettings-multiline@test` — no regression

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

field-tests/annotations/dash-to-panel.yaml

@@ -72,8 +72,8 @@ findings:
     notes: "File I/O not disclosed"
   # WARNs — False Positives
   - id: "R-SLOP-24::new Gio.Settings for system schemas"
-    classification: fp
-    notes: "5 hits — desktop.interface, desktop.notifications, shell.app-switcher, KEYBINDINGS_SCHEMA. Correct API for system schemas."
+    classification: resolved
+    notes: "5 hits — desktop.interface, desktop.notifications, shell.app-switcher, KEYBINDINGS_SCHEMA. Already suppressed by existing guard-window-forward: 5 mechanism. PR #139 adds additional coverage for edge cases (enumerated _SCHEMA constants, string-anchored desktop. guard)."
   - id: "R-SLOP-01::JSDoc despite provenance score 4"
     classification: expected
     notes: "5 hits — suppressed by provenance post-filter (score 4 >= 3 threshold). Fixed in deferred approach."

rules/patterns.yaml

@@ -694,7 +694,7 @@
   message: "new Gio.Settings() is incorrect in GNOME 45+; use this.getSettings() from Extension base class"
   category: ai-slop
   fix: "Use this.getSettings() in Extension subclass or this.getSettings() in ExtensionPreferences"
-  guard-pattern: "schema.*org\\.gnome\\.(?!shell\\.extensions\\.)|KEYBINDINGS_SCHEMA"
+  guard-pattern: "schema.*org\\.gnome\\.(?!shell\\.extensions\\.)|['\"]desktop\\.|shell\\.app-switcher|(?:KEYBINDINGS|NOTIFICATIONS|DESKTOP|INTERFACE|WM|MUTTER|APP_SWITCHER)_SCHEMA"
   guard-window-forward: 5
   exclude-dirs: ["service"]
 

skills/ego-lint/references/rules-reference.md

@@ -2233,7 +2233,7 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: `new Gio.Settings()` should not be used in GNOME 45+ extensions.
 - **Rationale**: The `Extension` base class provides `this.getSettings()` which uses the correct schema path automatically. Manually constructing `Gio.Settings` requires specifying the schema ID and may use the wrong compiled schema path.
 - **Fix**: Use `this.getSettings()` in the Extension subclass, or pass a schema ID: `this.getSettings('org.gnome.shell.extensions.my-ext')`.
-- **Guard**: Suppressed when `schema.*org.gnome.` (excluding `shell.extensions.`) or `KEYBINDINGS_SCHEMA` appears on the match line or within a 5-line forward window. Also skipped in `service/` directories.
+- **Guard**: Suppressed when `schema.*org.gnome.` (excluding `shell.extensions.`), string-literal-anchored system schema substrings (`'desktop.` or `"desktop.`), bare `shell.app-switcher`, or enumerated system-schema constants (`KEYBINDINGS_SCHEMA`, `NOTIFICATIONS_SCHEMA`, `DESKTOP_SCHEMA`, `INTERFACE_SCHEMA`, `WM_SCHEMA`, `MUTTER_SCHEMA`, `APP_SWITCHER_SCHEMA`) appear on the match line or within a 5-line forward window. The `desktop.` anchor requires a quote prefix to avoid matching property-access contexts like `this.desktop.theme`. Also skipped in `service/` directories.
 
 ### R-SLOP-25: Main.extensionManager.enable/disable
 - **Severity**: advisory

tests/assertions/dash-to-panel-fixes.sh

@@ -50,3 +50,12 @@ echo "=== system-gsettings-deep ==="
 run_lint "system-gsettings-deep@test"
 assert_output_not_contains "R-SLOP-24 suppressed for deep multiline system schema" "\[WARN\].*R-SLOP-24"
 echo ""
+
+# --- system-schema-bare (R-SLOP-24 guard for bare system schema identifiers) ---
+echo "=== system-schema-bare ==="
+run_lint "system-schema-bare@test"
+assert_output_not_contains "R-SLOP-24 suppressed for bare desktop schema" "\[WARN\].*R-SLOP-24.*desktop\.interface"
+assert_output_not_contains "R-SLOP-24 suppressed for NOTIFICATIONS_SCHEMA constant" "\[WARN\].*R-SLOP-24.*NOTIFICATIONS_SCHEMA"
+assert_output_not_contains "R-SLOP-24 suppressed for shell.app-switcher" "\[WARN\].*R-SLOP-24.*app-switcher"
+assert_output_contains "R-SLOP-24 still fires for extension-owned schema" "\[WARN\].*R-SLOP-24"
+echo ""

tests/fixtures/system-schema-bare@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/system-schema-bare@test/extension.js

@@ -0,0 +1,35 @@
+import Gio from 'gi://Gio';
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+
+const NOTIFICATIONS_SCHEMA = 'org.gnome.desktop.notifications';
+
+export default class BareSchemaExtension extends Extension {
+    enable() {
+        // Bare system schema substring — should NOT trigger R-SLOP-24
+        this._iface = new Gio.Settings({
+            schema_id: 'desktop.interface',
+        });
+
+        // _SCHEMA constant — should NOT trigger R-SLOP-24
+        this._notif = new Gio.Settings({
+            schema_id: NOTIFICATIONS_SCHEMA,
+        });
+
+        // Bare shell system schema — should NOT trigger R-SLOP-24
+        this._switcher = new Gio.Settings({
+            schema_id: 'shell.app-switcher',
+        });
+
+        // Extension-owned schema — SHOULD trigger R-SLOP-24
+        this._own = new Gio.Settings({
+            schema_id: 'org.gnome.shell.extensions.myext',
+        });
+    }
+
+    disable() {
+        this._iface = null;
+        this._notif = null;
+        this._switcher = null;
+        this._own = null;
+    }
+}

tests/fixtures/system-schema-bare@test/metadata.json

@@ -0,0 +1,7 @@
+{
+    "uuid": "system-schema-bare@test",
+    "name": "Bare System Schema Test",
+    "description": "Tests R-SLOP-24 guard for system schema identifiers without org.gnome prefix",
+    "shell-version": ["48"],
+    "url": "https://example.com"
+}