fix(ego-lint): detect compiled TypeScript and suppress noisy rules (#52)

## Summary

Extensions compiled from TypeScript via esbuild/tsc produce artifacts
that trigger multiple ego-lint rules inappropriately:

- **R-DEPR-09** (`var` declarations): esbuild emits `var` for hoisted
helpers — not a code quality issue
- **R-SLOP-38** (verbose parameter names): TypeScript verbose signatures
survive compilation
- **resource-tracking/no-destroy-method**: compiled output fragments
classes across files; cleanup is handled by parent class hierarchies the
static analyzer can't follow

This adds early detection of esbuild/tsc transpiler markers
(`__defProp`, `__decorateClass`, `__publicField`) and suppresses these
noisy rules when detected.

### Changes

- **`ego-lint.sh`**: New compiled TypeScript detection section between
minified-js and CSS checks. Scans JS files for esbuild helper patterns,
sets `EGO_LINT_COMPILED_TS=1` env var for sub-scripts
- **`apply-patterns.py`**: New `skip-if-compiled` rule field — when
`true` and compiled TS detected, rule is skipped with SKIP status
- **`rules/patterns.yaml`**: Added `skip-if-compiled: true` to R-DEPR-09
and R-SLOP-38
- **`check-resources.py`**: Suppresses `no-destroy-method` findings when
compiled TS detected (other resource orphan checks still run)
- **Test fixture**: `compiled-ts-extension@test` with esbuild-style
helpers, `var` declarations, verbose identifiers, and a helper class
without destroy method

## Test plan

- [x] New fixture triggers detection and verifies all three suppressions
- [x] Full test suite passes: 565 passed, 0 failed (was 558)
- [x] Non-compiled fixtures still get `[PASS] compiled-typescript` (no
false positives)
- [ ] Field test with `--no-fetch` to verify tiling-shell noise
reduction

Closes #40

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

rules/README.md

@@ -216,6 +216,20 @@ This skips matches inside `//` single-line comments and `/* */` block comments (
 - Deprecated API names mentioned in migration comments
 - Commented-out legacy code that hasn't been removed
 
+### Compiled TypeScript Suppression (`skip-if-compiled`)
+
+When a rule flags artifacts produced by JavaScript transpilers (e.g., esbuild), use `skip-if-compiled: true` to suppress it for compiled extensions. ego-lint detects esbuild output by scanning for transpiler helper functions (`__defProp`, `__decorateClass`, `__publicField`). When detected, rules with this field are emitted as SKIP instead of WARN/FAIL.
+
+```yaml
+- id: R-DEPR-09
+  pattern: "^\\s*var\\s+\\w"
+  severity: advisory
+  message: "Use const/let instead of var"
+  skip-if-compiled: true
+```
+
+esbuild emits `var` for hoisted helpers and verbose parameter names from TypeScript signatures — these are build artifacts, not author choices. Only use this field for rules where compiled output is a known false-positive source.
+
 ### Fix Version Gating (`fix-min-version`)
 
 When a deprecation rule suggests a fix that only works on newer GNOME versions, use `fix-min-version` to suppress the fix text for extensions whose minimum shell-version is below the threshold. The warning still fires (developers should know about deprecations), but the fix suggestion is omitted when applying it would break backward compatibility.

rules/patterns.yaml

@@ -181,6 +181,7 @@
   message: "Use const/let instead of var; var has function scope and causes bugs in closures"
   category: deprecated
   fix: "Replace var with const (preferred) or let (when reassignment needed)."
+  skip-if-compiled: true
 
 - id: R-DEPR-10
   pattern: "\\bimports\\.format\\b"
@@ -607,6 +608,7 @@
   category: ai-slop
   fix: "Shorten parameter names to be concise but clear (e.g., currentBatteryThresholdValue → threshold)"
   guard-pattern: "\\w{25,}\\s*="
+  skip-if-compiled: true
 
 - id: R-SLOP-40
   pattern: "new\\s+Promise\\s*\\(\\s*\\(\\s*resolve\\s*,\\s*reject\\s*\\)"

skills/ego-lint/references/rules-reference.md

@@ -383,6 +383,7 @@ import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
 - **Rule**: Extension code should use `const` or `let` instead of `var`.
 - **Rationale**: `var` has function scope rather than block scope, which causes subtle bugs in closures and loops. Modern JavaScript uses `const` (preferred) and `let` (when reassignment is needed). EGO reviewers view `var` usage as a sign of outdated or AI-generated code.
 - **Fix**: Replace `var` with `const` (preferred) or `let` (when reassignment is needed).
+- **Note**: Suppressed (`skip-if-compiled`) for extensions compiled from TypeScript via esbuild, where `var` is emitted for transpiler helper functions.
 
 ### R-DEPR-04-legacy: Legacy imports.* syntax (pre-GNOME 45)
 - **Severity**: advisory
@@ -2448,6 +2449,7 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rationale**: AI-generated code tends to use excessively descriptive camelCase names like `currentBatteryThresholdValue` or `updatedNotificationMessage`. Human-written GNOME code favors concise names (`threshold`, `message`). The lowercase-start filter avoids false positives on PascalCase class names and UPPER_SNAKE constants. Threshold raised from 20 to 25 to avoid FPs on standard Clutter API names (e.g., `brightnessContrastEffect` at 24 chars).
 - **Fix**: Shorten parameter/argument names to be concise but clear.
 - **Tested by**: `tests/fixtures/slop-long-params@test/`
+- **Note**: Suppressed (`skip-if-compiled`) for extensions compiled from TypeScript via esbuild, where verbose parameter names from TypeScript signatures survive compilation.
 
 ### R-SLOP-40: Manual Promise wrapper
 - **Severity**: advisory

skills/ego-lint/scripts/apply-patterns.py

@@ -266,6 +266,7 @@ def main():
     rules = parse_rules(rules_file)
     shell_versions = _get_shell_versions(ext_dir)
     min_shell = min(shell_versions) if shell_versions else None
+    is_compiled_ts = os.environ.get('EGO_LINT_COMPILED_TS') == '1'
 
     for rule in rules:
         rid = rule.get('id', '?')
@@ -280,6 +281,11 @@ def main():
             print(f"SKIP|{rid}|Not applicable for declared shell-version(s)")
             continue
 
+        # Compiled TypeScript gating: skip rules that flag transpiler artifacts
+        if is_compiled_ts and rule.get('skip-if-compiled', '') == 'true':
+            print(f"SKIP|{rid}|Not applicable for compiled TypeScript")
+            continue
+
         if isinstance(scopes, str):
             scopes = [scopes]
 

skills/ego-lint/scripts/check-css.py

@@ -21,13 +21,31 @@ def result(status, check, detail):
 
 # Known GNOME Shell theme classes that are OK to target
 KNOWN_SHELL_CLASSES = {
+    # Panel
     'panel', 'panel-button', 'system-status-icon',
+    # Popup menu
     'popup-menu', 'popup-menu-item', 'popup-separator-menu-item',
     'popup-sub-menu', 'popup-menu-section',
+    'popup-menu-content', 'popup-menu-arrow', 'popup-menu-boxpointer',
+    'popup-menu-icon', 'popup-menu-ornament',
+    'popup-inactive-menu-item', 'popup-ornamented-menu-item',
+    # Quick settings
     'quick-toggle', 'quick-settings', 'quick-settings-item',
-    'message', 'message-list', 'notification',
-    'overview', 'workspace', 'search-entry',
+    'quick-settings-grid', 'quick-menu-toggle', 'quick-toggle-menu',
+    'quick-slider',
+    # Notifications / messages
+    'message', 'message-list', 'notification', 'notification-banner',
+    # Calendar / date
+    'calendar', 'events-button',
+    # Overview / workspace
+    'overview', 'workspace', 'workspace-background',
+    'workspace-thumbnails',
+    # Search
+    'search-entry',
+    # Dash / app grid
     'app-well-icon', 'dash', 'show-apps',
+    # OSD / other
+    'osd-window', 'slider',
 }
 
 
@@ -118,12 +136,19 @@ def check_shell_class_override(ext_dir):
             continue
         # A top-level match: the first class selector on the line is a known
         # shell class (no preceding class/id/element selector that would scope it).
-        # e.g. ".panel-button { ..." or ".panel-button.foo { ..."
-        # but NOT ".my-extension .panel-button { ..."
-        m = re.match(r'^\.([\w-]+)', stripped)
+        # e.g. ".panel-button { ..." — bare shell class override
+        # but NOT ".my-extension .panel-button { ..." (descendant scoping)
+        # and NOT ".panel-button.my-ext-class { ..." (compound scoping)
+        m = re.match(r'^\.([\w-]+)(.*)', stripped)
         if m:
             cls = m.group(1)
+            rest = m.group(2)
             if cls in KNOWN_SHELL_CLASSES:
+                # Skip compound selectors where shell class is paired with
+                # a non-shell class (e.g. .quick-menu-toggle.my-ext-toggle)
+                compound = re.match(r'^\.([\w-]+)', rest)
+                if compound and compound.group(1) not in KNOWN_SHELL_CLASSES:
+                    continue
                 overrides.append(cls)
 
     if overrides:

skills/ego-lint/scripts/check-resources.py

@@ -124,19 +124,27 @@ def main():
     depth = summary.get('ownership_depth', 0)
     orphan_count = summary.get('orphan_count', len(orphans))
 
+    # Compiled TypeScript: suppress no-destroy-method findings (transpiler
+    # fragments classes across files; cleanup is handled by parent hierarchies)
+    is_compiled_ts = os.environ.get('EGO_LINT_COMPILED_TS') == '1'
+
     # Emit per-orphan warnings
+    emitted_count = 0
     for orphan in orphans:
         check_id, detail = classify_orphan(orphan)
+        if is_compiled_ts and check_id == 'resource-tracking/no-destroy-method':
+            continue
         result('WARN', check_id, detail)
+        emitted_count += 1
 
     # Emit summary line
-    if orphan_count == 0:
+    if emitted_count == 0:
         result('PASS', 'resource-tracking/ownership',
                f'{files_scanned} files scanned, depth {depth}, 0 orphans')
     else:
         result('WARN', 'resource-tracking/ownership',
                f'{files_scanned} files scanned, depth {depth}, '
-               f'{orphan_count} orphan{"s" if orphan_count != 1 else ""} detected')
+               f'{emitted_count} orphan{"s" if emitted_count != 1 else ""} detected')
 
 
 if __name__ == '__main__':

skills/ego-lint/scripts/ego-lint.sh

@@ -463,6 +463,31 @@ else
     print_result "PASS" "minified-js" "No minified or bundled JavaScript detected"
 fi
 
+# ---------------------------------------------------------------------------
+# Compiled TypeScript detection
+# ---------------------------------------------------------------------------
+# esbuild emits helper functions (var __defProp, __decorateClass, etc.)
+# that are definitive markers of transpiled output. When detected, noisy rules
+# that flag transpiler artifacts (var declarations, verbose identifiers) are
+# suppressed, and resource-tracking/no-destroy-method is skipped.
+# Note: these markers are esbuild-specific. Plain tsc emits different helpers
+# (__decorate, __metadata, __awaiter) — add those if tsc-only extensions appear.
+
+COMPILED_TS=false
+while IFS= read -r -d '' f; do
+    if grep -qE 'var __defProp|__decorateClass|__publicField' "$f" 2>/dev/null; then
+        COMPILED_TS=true
+        break
+    fi
+done < <(find "$EXT_DIR" -name '*.js' -not -path '*/node_modules/*' -not -path '*/.git/*' -print0 2>/dev/null)
+
+if [[ "$COMPILED_TS" == true ]]; then
+    export EGO_LINT_COMPILED_TS=1
+    print_result "WARN" "compiled-typescript" "Extension appears compiled from TypeScript — some lint checks adjusted"
+else
+    print_result "PASS" "compiled-typescript" "No transpiler artifacts detected"
+fi
+
 # ---------------------------------------------------------------------------
 # CSS scoping check (delegated to check-css.py)
 # ---------------------------------------------------------------------------

tests/assertions/compiled-typescript.sh

@@ -0,0 +1,13 @@
+# Compiled TypeScript detection assertions
+# Sourced by run-tests.sh — uses run_lint, assert_output_contains, assert_exit_code, etc.
+
+# --- compiled-ts-extension (with esbuild markers) ---
+echo "=== compiled-ts-extension ==="
+run_lint "compiled-ts-extension@test"
+assert_exit_code "exits with 0 (no blocking issues)" 0
+assert_output_contains "detects compiled TypeScript" "\[WARN\].*compiled-typescript.*compiled from TypeScript"
+assert_output_contains "R-DEPR-09 skipped for compiled TS" "\[SKIP\].*R-DEPR-09.*compiled TypeScript"
+assert_output_contains "R-SLOP-38 skipped for compiled TS" "\[SKIP\].*R-SLOP-38.*compiled TypeScript"
+assert_output_not_contains "no-destroy-method suppressed" "resource-tracking/no-destroy-method"
+assert_output_contains "resource tracking still runs" "resource-tracking/ownership"
+echo ""

tests/fixtures/compiled-ts-extension@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/compiled-ts-extension@test/extension.js

@@ -0,0 +1,30 @@
+// esbuild transpiler output helpers
+var __defProp = Object.defineProperty;
+var __decorateClass = (decorators, target, key, kind) => {
+  var result = kind > 1 ? void 0 : kind ? __defProp(target, key) : target;
+  return result;
+};
+
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+
+var TilingShellExtension = class extends Extension {
+  enable() {
+    this._settings = this.getSettings();
+    this._handlerId = global.display.connect(
+      'window-created',
+      (display, currentlyActiveWindowParameter) => {
+        this._onWindowCreated(currentlyActiveWindowParameter);
+      }
+    );
+  }
+
+  disable() {
+    global.display.disconnect(this._handlerId);
+    this._handlerId = null;
+    this._settings = null;
+  }
+
+  _onWindowCreated(currentlyActiveWindowParameter) {
+    log(currentlyActiveWindowParameter);
+  }
+};