fix(ego-lint): expand CSS shell-class list from GNOME Shell SCSS source (#57)

## Summary

- Cross-referenced `KNOWN_SHELL_CLASSES` in `check-css.py` against GNOME
Shell's canonical SCSS widget files to add 13 missing shell classes
across 6 categories
- Added compound selector detection to `check_shell_class_override` to
avoid false positives on `.shell-class.my-ext-class` patterns
- Added test fixture and assertions for the new classes

### Classes added

| Category | Classes | SCSS Source |
|----------|---------|-------------|
| Panel | `panel-status-indicators-box`, `clock-display` | `_panel.scss`
|
| Popup menu | `popup-status-menu-item`, `panel-menu`, `background-menu`
| `_popovers.scss`, `popupMenu.js` |
| Overview | `window-picker`, `window-caption`, `window-close` |
`_window-picker.scss` |
| Dash / app grid | `dash-background`, `overview-icon`, `icon-grid`,
`app-folder` | `_dash.scss`, `_app-grid.scss` |
| Dialogs | `modal-dialog` | `_dialogs.scss` |
| Also from prior commit | `popup-menu-content`, `popup-menu-arrow`,
`popup-menu-boxpointer`, `popup-menu-icon`, `popup-menu-ornament`,
`popup-inactive-menu-item`, `popup-ornamented-menu-item`,
`quick-settings-grid`, `quick-menu-toggle`, `quick-toggle-menu`,
`quick-slider`, `notification-banner`, `calendar`, `events-button`,
`workspace-background`, `workspace-thumbnails`, `osd-window`, `slider` |
various |

### Note on issue scope

`.popup-menu-container` and `.popup-menu-box` (mentioned in #44) are
**not** standard GNOME Shell theme classes. They are custom classes the
media-controls extension adds to its own widgets
(`PanelButton.js:178,232`). Adding them to `KNOWN_SHELL_CLASSES` would
create false positives for extensions using these as their own class
names. The field test report was mistaken about their origin.

## Test plan

- [x] `bash tests/run-tests.sh` — all assertions pass
- [x] Fixture `css-shell-classes-extra@test` verifies new overrides
detected and compound selectors exempted
- [x] Added fixture coverage for panel (`panel-status-indicators-box`)
and window-picker (`window-caption`) categories

Closes #44

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/scripts/check-css.py

@@ -21,30 +21,36 @@ def result(status, check, detail):
 
 # Known GNOME Shell theme classes that are OK to target
 KNOWN_SHELL_CLASSES = {
-    # Panel
+    # Panel (_panel.scss)
     'panel', 'panel-button', 'system-status-icon',
-    # Popup menu
+    'panel-status-indicators-box', 'clock-display',
+    # Popup menu (_popovers.scss + popupMenu.js)
     'popup-menu', 'popup-menu-item', 'popup-separator-menu-item',
     'popup-sub-menu', 'popup-menu-section',
     'popup-menu-content', 'popup-menu-arrow', 'popup-menu-boxpointer',
     'popup-menu-icon', 'popup-menu-ornament',
     'popup-inactive-menu-item', 'popup-ornamented-menu-item',
-    # Quick settings
+    'popup-status-menu-item', 'panel-menu', 'background-menu',
+    # Quick settings (_quick-settings.scss)
     'quick-toggle', 'quick-settings', 'quick-settings-item',
     'quick-settings-grid', 'quick-menu-toggle', 'quick-toggle-menu',
     'quick-slider',
-    # Notifications / messages
+    # Notifications / messages (_notifications.scss, _message-list.scss)
     'message', 'message-list', 'notification', 'notification-banner',
-    # Calendar / date
+    # Calendar / date (_calendar.scss)
     'calendar', 'events-button',
-    # Overview / workspace
+    # Overview / workspace (_overview.scss, _window-picker.scss)
     'overview', 'workspace', 'workspace-background',
-    'workspace-thumbnails',
-    # Search
+    'workspace-thumbnails', 'window-picker', 'window-caption',
+    'window-close',
+    # Search (_search-entry.scss)
     'search-entry',
-    # Dash / app grid
+    # Dash / app grid (_dash.scss, _app-grid.scss)
     'app-well-icon', 'dash', 'show-apps',
-    # OSD / other
+    'dash-background', 'overview-icon', 'icon-grid', 'app-folder',
+    # Dialogs (_dialogs.scss)
+    'modal-dialog',
+    # OSD / other (_osd.scss, _slider.scss)
     'osd-window', 'slider',
 }
 

tests/fixtures/css-shell-classes-extra@test/stylesheet.css

@@ -19,6 +19,31 @@
     height: 20px;
 }
 
+/* Dialog class — should trigger shell-class-override */
+.modal-dialog {
+    border-radius: 12px;
+}
+
+/* Popup context menu — should trigger shell-class-override */
+.background-menu {
+    opacity: 0.9;
+}
+
+/* Dash class — should trigger shell-class-override */
+.dash-background {
+    background: transparent;
+}
+
+/* Panel class — should trigger shell-class-override */
+.panel-status-indicators-box {
+    spacing: 6px;
+}
+
+/* Window picker class — should trigger shell-class-override */
+.window-caption {
+    font-size: 11pt;
+}
+
 /* Scoped usage — should NOT trigger shell-class-override */
 .my-extension .popup-menu-arrow {
     color: red;

tests/run-tests.sh

@@ -601,6 +601,11 @@ assert_output_contains "detects popup-menu-boxpointer override" "css/shell-class
 assert_output_contains "detects notification-banner override" "css/shell-class-override.*notification-banner"
 assert_output_contains "detects osd-window override" "css/shell-class-override.*osd-window"
 assert_output_contains "detects slider override" "css/shell-class-override.*slider"
+assert_output_contains "detects modal-dialog override" "css/shell-class-override.*modal-dialog"
+assert_output_contains "detects background-menu override" "css/shell-class-override.*background-menu"
+assert_output_contains "detects dash-background override" "css/shell-class-override.*dash-background"
+assert_output_contains "detects panel-status-indicators-box override" "css/shell-class-override.*panel-status-indicators-box"
+assert_output_contains "detects window-caption override" "css/shell-class-override.*window-caption"
 assert_output_not_contains "no unscoped-class FP on new shell classes" "css/unscoped-class"
 assert_output_not_contains "compound selector not flagged" "css/shell-class-override.*quick-settings-grid"
 echo ""