refactor(ego-lint): unify service/ path filtering and document exclusions

Replace 6 inline string-based service/ filters in check-lifecycle.py with
a shared _skip_non_lifecycle() helper using component-based path matching
(consistent with check-quality.py). The string approach ('/service/' in path)
could false-match paths like myservice-backup/. Add scope exclusion notes
to R-LIFE-02, R-LIFE-06, and R-QUAL-04 in rules-reference.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/references/rules-reference.md

@@ -941,6 +941,7 @@ Heuristic rules that detect code patterns commonly seen in AI-generated or over-
 - **Rule**: Extension code should avoid declaring mutable variables (`let` or `var`) at module scope (outside any class or function).
 - **Rationale**: Module-level mutable state persists across enable/disable cycles, leading to subtle bugs. GNOME Shell extensions should keep all mutable state inside the `Extension` class instance, which is created fresh on each enable cycle.
 - **Fix**: Move mutable state into the Extension class as instance properties. Use `const` for module-level declarations that are truly constant (imports, enums, configuration).
+- **Scope exclusion**: Files in `service/` are excluded (daemon processes have different lifecycle — no enable/disable).
 
 ### R-QUAL-05: Empty catch blocks
 - **Severity**: advisory
@@ -1187,6 +1188,7 @@ disable() {
 - **Rule**: `timeout_add` or `idle_add` call whose return value is not stored.
 - **Rationale**: Without the source ID, the timeout cannot be removed in disable(), causing callbacks after extension teardown.
 - **Fix**: Store the return value: `this._timeoutId = GLib.timeout_add(...)` and call `GLib.Source.remove(this._timeoutId)` in disable().
+- **Scope exclusion**: Files in `service/` are excluded (daemon processes have different lifecycle — no enable/disable).
 - **Tested by**: `tests/fixtures/lifecycle-basic@test/`
 
 #### Example
@@ -1280,6 +1282,7 @@ export default class MyExtension extends Extension {
 - **Rule**: Callbacks passed to `GLib.timeout_add()` or `GLib.idle_add()` should explicitly return `GLib.SOURCE_REMOVE` or `GLib.SOURCE_CONTINUE`.
 - **Rationale**: If a timeout callback does not return `GLib.SOURCE_REMOVE` (or `false`), the default return value of `undefined` is falsy and the timeout is removed — but this is implicit and confusing. If the intent is to repeat, forgetting `SOURCE_CONTINUE` silently breaks the timer. Explicit return values make the intent clear and are expected by EGO reviewers.
 - **Fix**: Add `return GLib.SOURCE_REMOVE;` for one-shot timeouts or `return GLib.SOURCE_CONTINUE;` for repeating timeouts at the end of the callback.
+- **Scope exclusion**: Files in `service/` are excluded (daemon processes have different lifecycle — no enable/disable).
 
 ### R-LIFE-07: D-Bus proxy without signal disconnect
 - **Severity**: advisory

skills/ego-lint/scripts/check-lifecycle.py

@@ -42,6 +42,17 @@
 import sys
 
 
+# Directories without enable()/disable() lifecycle
+_NON_LIFECYCLE_DIRS = frozenset({'service'})
+
+
+def _skip_non_lifecycle(filepath, ext_dir):
+    """Return True if filepath is inside a non-lifecycle directory."""
+    rel = os.path.relpath(filepath, ext_dir)
+    parts = rel.replace(os.sep, '/').split('/')
+    return any(p in _NON_LIFECYCLE_DIRS for p in parts)
+
+
 def result(status, check, detail):
     print(f"{status}|{check}|{detail}")
 
@@ -171,9 +182,7 @@ def check_untracked_timeouts(ext_dir):
     if not js_files:
         return
 
-    # Skip service/ directory (different lifecycle — no enable/disable)
-    js_files = [f for f in js_files
-                if '/service/' not in f.replace(os.sep, '/')]
+    js_files = [f for f in js_files if not _skip_non_lifecycle(f, ext_dir)]
 
     untracked = []
     for filepath in js_files:
@@ -258,9 +267,7 @@ def check_timeout_return_value(ext_dir):
     if not js_files:
         return
 
-    # Skip service/ directory (different lifecycle)
-    js_files = [f for f in js_files
-                if '/service/' not in f.replace(os.sep, '/')]
+    js_files = [f for f in js_files if not _skip_non_lifecycle(f, ext_dir)]
 
     missing = []
     for filepath in js_files:
@@ -1233,9 +1240,7 @@ def check_gsettings_signal_leak(ext_dir):
     if not js_files:
         return
 
-    # Skip service/ directory (different lifecycle)
-    js_files = [f for f in js_files
-                if '/service/' not in f.replace(os.sep, '/')]
+    js_files = [f for f in js_files if not _skip_non_lifecycle(f, ext_dir)]
     if not js_files:
         return
 
@@ -1325,9 +1330,7 @@ def check_dbus_signal_leak(ext_dir):
     if not js_files:
         return
 
-    # Skip service/ directory (different lifecycle)
-    js_files = [f for f in js_files
-                if '/service/' not in f.replace(os.sep, '/')]
+    js_files = [f for f in js_files if not _skip_non_lifecycle(f, ext_dir)]
     if not js_files:
         return
 
@@ -1436,8 +1439,7 @@ def check_module_scope_state(ext_dir):
     if not files:
         return
 
-    # Skip service/ directory (different lifecycle model)
-    files = [f for f in files if '/service/' not in f.replace(os.sep, '/')]
+    files = [f for f in files if not _skip_non_lifecycle(f, ext_dir)]
 
     MODULE_STATE_RE = re.compile(
         r'(?:const|let|var)\s+(\w+)\s*=\s*new\s+(Map|Set)\s*\(')
@@ -1504,8 +1506,7 @@ def check_module_scope_prototype(ext_dir):
     if not files:
         return
 
-    # Skip service/ directory (different lifecycle model)
-    files = [f for f in files if '/service/' not in f.replace(os.sep, '/')]
+    files = [f for f in files if not _skip_non_lifecycle(f, ext_dir)]
 
     PROTO_ASSIGN = re.compile(r'([\w.]+\.prototype\.\w+)\s*=(?!=)')
     PROTO_OBJ_ASSIGN = re.compile(