Skip to content

Commit 3df9657

Browse files
ZviBaratzclaude
andcommitted
feat(ego-simulate): add ESLint errors as rejection reason #23
Fixes #2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 74885f8 commit 3df9657

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

skills/ego-simulate/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: ego-simulate
33
description: >-
44
Simulate an EGO review submission — produces a readiness report based on
55
published review criteria. Triages the extension in reviewer order, applies
6-
a 22-reason rejection taxonomy with weighted scoring, and generates a
6+
a 23-reason rejection taxonomy with weighted scoring, and generates a
77
structured report with a pass/fail verdict. Use before EGO submission to
88
assess review readiness.
99
---
@@ -63,7 +63,7 @@ monologue style: "I see X but Y is missing" or "This looks clean."
6363

6464
Read `references/rejection-taxonomy.md` before scoring.
6565

66-
Apply the 22-reason rejection taxonomy. For each reason:
66+
Apply the 23-reason rejection taxonomy. For each reason:
6767
- Check whether the extension triggers it
6868
- If triggered, record the weight and the specific evidence (file:line)
6969
- Each reason contributes its weight ONCE regardless of occurrence count
@@ -112,7 +112,7 @@ monologue. What did they notice first? What's their gut feeling?]
112112

113113
Read these reference documents before generating the report:
114114
- `references/reviewer-persona.md` — How reviewers triage submissions
115-
- `references/rejection-taxonomy.md`22 rejection reasons with weights
115+
- `references/rejection-taxonomy.md`23 rejection reasons with weights
116116
- `references/approved-examples.md` — Idiomatic patterns reviewers like
117117

118118
## Important

skills/ego-simulate/references/rejection-taxonomy.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# EGO Rejection Taxonomy
22

3-
22 common rejection reasons weighted by severity. Use these weights to compute
3+
23 common rejection reasons weighted by severity. Use these weights to compute
44
a simulation score.
55

66
## Weight 10 — Hard Blockers (automatic rejection)
@@ -34,6 +34,7 @@ a simulation score.
3434
| 15 | Import segregation | GTK in `extension.js` or Shell modules in `prefs.js` |
3535
| 16 | InjectionManager leak | `new InjectionManager()` without `.clear()` in disable |
3636
| 17 | Mock/test code shipped | `MockDevice.js`, test files in production package |
37+
| 23 | ESLint errors | Code that fails ESLint with errors (undefined references, syntax errors, missing imports) |
3738

3839
## Weight 3 — Style/Quality
3940

@@ -67,3 +68,5 @@ a simulation score.
6768
the rejection threshold
6869
- Hard blockers are independently sufficient for rejection
6970
- When multiple reasons in the same weight class trigger, sum all their weights
71+
- ego-lint runs ESLint as part of its automated checks. If ESLint reports
72+
errors (not warnings), reason #23 is triggered with weight 5.

0 commit comments

Comments
 (0)