fix(ego-lint): sync check-resources.py reason strings with build-resource-graph.py

build-resource-graph.py changed its reason strings when adding onDestroy()
support, but check-resources.py still matched the old substrings. This
caused orphan classification for no-destroy-method and destroy-not-called
to silently fall through to the generic type-based routing.

Also strengthens the on-destroy-cleanup test with a positive assertion
that resource tracking actually ran, preventing vacuous negative passes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/scripts/check-resources.py

@@ -52,13 +52,13 @@ def classify_orphan(orphan):
     file_path = orphan.get('file', '')
     line = orphan.get('line', '?')
 
-    # Case 1: No destroy/disable method at all
-    if 'no destroy()/disable() method' in reason:
+    # Case 1: No cleanup method at all (destroy/disable/onDestroy)
+    if 'no cleanup method' in reason:
         detail = f"{file_path}:{line} — {reason}"
         return 'resource-tracking/no-destroy-method', detail
 
-    # Case 2: Parent doesn't call destroy
-    if 'parent does not call destroy()' in reason:
+    # Case 2: Parent doesn't call cleanup method
+    if 'parent does not call cleanup method' in reason:
         detail = f"{file_path}:{line} — {reason}"
         return 'resource-tracking/destroy-not-called', detail
 

tests/run-tests.sh

@@ -609,7 +609,8 @@ echo ""
 echo "=== on-destroy-cleanup ==="
 run_lint "on-destroy-cleanup@test"
 assert_exit_code "exits with 0 (no blocking issues)" 0
-assert_output_not_contains "onDestroy recognized as cleanup method" "\[WARN\].*resource-tracking/no-destroy-method.*widget"
+assert_output_not_contains "no no-destroy-method for widget with onDestroy" "\[WARN\].*resource-tracking/no-destroy-method.*widget"
+assert_output_contains "resource tracking ran" "(PASS|WARN|FAIL).*resource-tracking"
 echo ""
 
 # Extended assertion files (auto-sourced from assertions/ directory)