fix(ego-lint): add version-compat suppression and calibrate severities (#69)

## Summary

- Add `replacement-pattern` to R-VER49-02 (`Clutter.ClickGesture`),
R-VER46-05 (`ExtensionState.ACTIVE`), R-VER48-02 (`global.compositor`) —
files containing both old and new APIs are recognized as intentional
backward-compat, not errors
- Downgrade R-VER48-07 to advisory (CSS can't have runtime guards,
consistent with R-VER48-04/04b/06)
- Downgrade `non-gjs-scripts` to WARN (EGO allows when justified, per
R-PKG-14)
- Downgrade `future-shell-version` to WARN (EGO allows preemptive
declarations; dev-limit check stays FAIL)
- Update test assertions to match new severities

Expected field test impact: 56 → 44 FAILs across 10 extensions.

Closes #68

## Test plan

- [x] `bash tests/run-tests.sh` — 603 passed, 0 failed
- [ ] `bash scripts/field-test-runner.sh --no-fetch` — verify FAIL count
drops
- [ ] Verify media-controls R-VER49-02 no longer FAIL
- [ ] Verify dash-to-panel R-VER48-02 and R-VER46-05 no longer FAIL
- [ ] Verify just-perfection R-VER48-07 appears as WARN

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

rules/patterns.yaml

@@ -871,6 +871,7 @@
   category: version-compat
   fix: "Use ACTIVE, INACTIVE, ENABLING, DISABLING instead"
   min-version: 46
+  replacement-pattern: "ExtensionState.ACTIVE"
 
 - id: R-VER46-06
   pattern: "\\bBlurEffect[^;]*\\.sigma\\b|\\bBlurEffect\\s*\\(\\s*\\{[^}]*sigma"
@@ -926,6 +927,7 @@
   min-version: 48
   guard-pattern: "if\\s*\\(\\s*Meta\\.disable_unredirect|PACKAGE_VERSION.*['\"]4[89]|PACKAGE_VERSION.*['\"][5-9]"
   guard-window: 10
+  replacement-pattern: "global.compositor"
 
 - id: R-VER48-03
   pattern: "\\bCursorTracker\\.get_for_display\\b"
@@ -978,7 +980,7 @@
 - id: R-VER48-07
   pattern: "quick-menu-toggle"
   scope: ["*.css"]
-  severity: blocking
+  severity: advisory
   message: "CSS class .quick-menu-toggle renamed to .quick-toggle-has-menu in GNOME 48"
   category: version-compat
   fix: "Replace .quick-menu-toggle with .quick-toggle-has-menu"
@@ -1006,6 +1008,7 @@
   fix: "Use new Clutter.ClickGesture() instead"
   min-version: 49
   guard-pattern: "\\|\\|\\s*Clutter\\.Click(Gesture|Action)|if\\s*\\(\\s*Clutter\\.ClickAction"
+  replacement-pattern: "Clutter.ClickGesture"
 
 - id: R-VER49-03
   pattern: "\\bClutter\\.TapAction\\b"

skills/ego-lint/references/rules-reference.md

@@ -1777,6 +1777,7 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: Extension code must not use the old `ExtensionState` enum values (`ENABLED`, `DISABLED`, `INITIALIZED`, `DEACTIVATING`, `ACTIVATING`) when targeting GNOME 46+.
 - **Rationale**: The `ExtensionState` enum values were renamed in GNOME 46 to better reflect their meaning: `ENABLED` became `ACTIVE`, `DISABLED` became `INACTIVE`, `ACTIVATING` became `ENABLING`, and `DEACTIVATING` became `DISABLING`.
 - **Fix**: Replace `ExtensionState.ENABLED` with `ExtensionState.ACTIVE`, `DISABLED` with `INACTIVE`, `ACTIVATING` with `ENABLING`, and `DEACTIVATING` with `DISABLING`.
+- **Suppressed when**: File also contains `ExtensionState.ACTIVE` (backward-compat shim)
 
 ### GNOME 47 (R-VER47)
 
@@ -1802,6 +1803,8 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: Extension code must not call `Meta.disable_unredirect_for_display()`, `Meta.enable_unredirect_for_display()`, `Meta.get_window_actors()`, `Meta.get_window_group_for_display()`, or `Meta.get_top_window_group_for_display()` when targeting GNOME 48+.
 - **Rationale**: These display management functions were moved from the `Meta` namespace to `Meta.Compositor` in GNOME 48. They are now accessible via `global.compositor`.
 - **Fix**: Access these functions via `global.compositor` instead of `Meta` directly. For example, replace `Meta.get_window_actors()` with `global.compositor.get_window_actors()`.
+- **Guard**: Suppressed when `if (Meta.disable_unredirect` or `PACKAGE_VERSION >= '48'` appears within 10 lines
+- **Suppressed when**: File also contains `global.compositor` (backward-compat shim)
 
 ### R-VER48-03: CursorTracker.get_for_display changed
 - **Severity**: blocking
@@ -1877,6 +1880,8 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: `Clutter.ClickAction` was removed in GNOME 49.
 - **Rationale**: Replaced by the gesture-based input API.
 - **Fix**: Use `new Clutter.ClickGesture()` instead.
+- **Guard**: Suppressed when `|| Clutter.Click(Gesture|Action)` or `if (Clutter.ClickAction` appears on the same line
+- **Suppressed when**: File also contains `Clutter.ClickGesture` (backward-compat shim)
 
 ### R-VER49-03: Clutter.TapAction removed
 - **Severity**: blocking
@@ -2273,7 +2278,7 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 ## GNOME 48/49 Version-Gated Rules (New)
 
 ### R-VER48-07: QuickMenuToggle CSS class rename
-- **Severity**: blocking
+- **Severity**: advisory
 - **Checked by**: apply-patterns.py (min-version: 48)
 - **Rule**: The CSS class `.quick-menu-toggle` was renamed to `.quick-toggle-has-menu` in GNOME 48.
 - **Rationale**: Extensions targeting GNOME 48+ that use the old class name will have broken styling.

skills/ego-lint/scripts/check-metadata.py

@@ -262,7 +262,7 @@ def main():
         for v in sv:
             try:
                 if int(v) > CURRENT_STABLE:
-                    result("FAIL", "metadata/future-shell-version",
+                    result("WARN", "metadata/future-shell-version",
                            f"shell-version '{v}' is newer than current stable ({CURRENT_STABLE})")
             except ValueError:
                 pass

skills/ego-lint/scripts/ego-lint.sh

@@ -371,7 +371,7 @@ if [[ -n "$non_gjs_scripts" ]]; then
     if [[ "$has_pkexec" == true ]]; then
         print_result "PASS" "non-gjs-scripts" "Found $hit_count non-GJS script(s) — pkexec helper detected, scripts support privileged operations"
     else
-        print_result "FAIL" "non-gjs-scripts" "Found $hit_count non-GJS script(s) — scripts MUST be written in GJS; no pkexec/privileged helper justification found"
+        print_result "WARN" "non-gjs-scripts" "Found $hit_count non-GJS script(s) — scripts MUST be written in GJS; no pkexec/privileged helper justification found"
     fi
 else
     print_result "PASS" "non-gjs-scripts" "No non-GJS scripts found"

tests/assertions/version-compat.sh

@@ -5,7 +5,7 @@
 echo "=== gnome48-css-compat ==="
 run_lint "gnome48-css-compat@test"
 assert_exit_code "exits with 1 (has failures)" 1
-assert_output_contains "detects quick-menu-toggle CSS rename" "\[FAIL\].*R-VER48-07"
+assert_output_contains "detects quick-menu-toggle CSS rename" "\[WARN\].*R-VER48-07"
 echo ""
 
 # --- gnome49-maximize ---

tests/run-tests.sh

@@ -286,7 +286,7 @@ echo "=== metadata-polish ==="
 run_lint "metadata-polish@test"
 assert_exit_code "exits with 1 (has failures)" 1
 assert_output_contains "warns on missing gettext-domain" "\[WARN\].*metadata/missing-gettext-domain"
-assert_output_contains "fails on future shell-version" "\[FAIL\].*metadata/future-shell-version"
+assert_output_contains "warns on future shell-version" "\[WARN\].*metadata/future-shell-version"
 echo ""
 
 # --- clipboard-access ---
@@ -524,8 +524,8 @@ echo ""
 # --- non-gjs-scripts ---
 echo "=== non-gjs-scripts ==="
 run_lint "non-gjs-scripts@test"
-assert_exit_code "exits with 1 (has failures)" 1
-assert_output_contains "fails on non-GJS scripts (no pkexec)" "\[FAIL\].*non-gjs-scripts"
+assert_exit_code "exits with 0 (warnings only)" 0
+assert_output_contains "warns on non-GJS scripts (no pkexec)" "\[WARN\].*non-gjs-scripts"
 echo ""
 
 # --- logging-volume ---