fix(ego-lint): reduce Tiling Shell false positives (#22)

## Summary

- **R-VER49-08/11 ternary guard**: Same-line `get_maximized ?`
suppresses maximize/unmaximize flags warnings — these are intentional
version-compat shims
- **Minified JS threshold**: Require 3+ lines >500 chars instead of 1 —
single long lines in compiled TypeScript are not minification

Closes #16

## Test plan

- [x] Updated fixture: `gnome49-compat@test` with ternary
maximize/unmaximize methods
- [x] Updated fixture: `minified-js@test` with 3 long lines (still
triggers)
- [x] Assertions verify: R-VER49-08/11 suppressed with ternary guard,
minified-js still detected
- [x] `bash tests/run-tests.sh` passes (512 assertions)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

rules/patterns.yaml

@@ -1057,6 +1057,8 @@
   category: version-compat
   fix: "Call window.set_maximize_flags(flags) then window.maximize()"
   min-version: 49
+  guard-pattern: "get_maximized\\s*\\?"
+  guard-window: 1
 
 - id: R-VER49-09
   pattern: "\\bAppMenuButton\\b"
@@ -1084,6 +1086,8 @@
   category: version-compat
   min-version: 49
   fix: "Call unmaximize() without the MaximizeFlags parameter"
+  guard-pattern: "get_maximized\\s*\\?"
+  guard-window: 1
 
 # --- GNOME 50 migration (version-gated) ---
 # GNOME 50 removed X11 support and associated APIs.

skills/ego-lint/references/rules-reference.md

@@ -2230,7 +2230,8 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: `maximize()` lost the `MaximizeFlags` parameter in GNOME 49.
 - **Rationale**: Passing `MaximizeFlags` to `maximize()` will throw in GNOME 49.
 - **Fix**: Call `window.set_maximize_flags(flags)` first, then `window.maximize()`.
-- **Tested by**: `tests/fixtures/gnome49-maximize@test/`
+- **Guard**: Suppressed when `get_maximized ?` appears on the same line (ternary version-compat pattern).
+- **Tested by**: `tests/fixtures/gnome49-compat@test/`
 
 ### R-VER49-09: AppMenuButton removal
 - **Severity**: blocking
@@ -2556,6 +2557,7 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 - **Rule**: `MaximizeFlags` parameter was removed from `unmaximize()` in GNOME 49.
 - **Rationale**: The `unmaximize()` method no longer accepts a flags parameter.
 - **Fix**: Call `unmaximize()` without the `MaximizeFlags` parameter.
+- **Guard**: Suppressed when `get_maximized ?` appears on the same line (ternary version-compat pattern).
 
 ---
 

skills/ego-lint/scripts/ego-lint.sh

@@ -421,9 +421,12 @@ for f in "$EXT_DIR"/*.js; do
         continue
     fi
 
-    # Check for any line > 500 chars (strong minification signal)
-    if awk 'length > 500 { found=1; exit } END { exit !found }' "$f" 2>/dev/null; then
-        minified_files+="  $rel_path (lines > 500 chars)"$'\n'
+    # Check for lines > 500 chars — need 3+ such lines to flag as minified.
+    # A single long line (e.g., keyboard constant chain) in an otherwise
+    # readable file is not minification.
+    long_line_count=$(awk 'length > 500 { n++ } END { print n+0 }' "$f" 2>/dev/null || true)
+    if [[ "$long_line_count" -ge 3 ]]; then
+        minified_files+="  $rel_path ($long_line_count lines > 500 chars)"$'\n'
     fi
 done
 if [[ -d "$EXT_DIR/lib" ]]; then
@@ -433,8 +436,9 @@ if [[ -d "$EXT_DIR/lib" ]]; then
             minified_files+="  $rel_path (webpack bundle)"$'\n'
             continue
         fi
-        if awk 'length > 500 { found=1; exit } END { exit !found }' "$f" 2>/dev/null; then
-            minified_files+="  $rel_path (lines > 500 chars)"$'\n'
+        long_line_count=$(awk 'length > 500 { n++ } END { print n+0 }' "$f" 2>/dev/null || true)
+        if [[ "$long_line_count" -ge 3 ]]; then
+            minified_files+="  $rel_path ($long_line_count lines > 500 chars)"$'\n'
         fi
     done < <(find "$EXT_DIR/lib" -name '*.js' -print0 2>/dev/null)
 fi

tests/fixtures/gnome49-compat@test/extension.js

@@ -9,6 +9,15 @@ export default class Gnome49Test extends Extension {
         this._tap = new Clutter.TapAction();
     }
 
+    // Ternary version-compat guard: should NOT trigger R-VER49-08/11
+    _maximizeCompat(window) {
+        window.get_maximized ? window.maximize(Meta.MaximizeFlags.BOTH) : window.maximize();
+    }
+
+    _unmaximizeCompat(window) {
+        window.get_maximized ? window.unmaximize(Meta.MaximizeFlags.BOTH) : window.unmaximize();
+    }
+
     disable() {
         this._click = null;
         this._tap = null;

tests/fixtures/minified-boundary@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/minified-boundary@test/extension.js

@@ -0,0 +1,7 @@
+{
+    "uuid": "minified-boundary@test",
+    "name": "Minified Boundary Test",
+    "description": "Tests that 2 long lines do not trigger minified-js detection",
+    "shell-version": ["48"],
+    "url": "https://example.com"
+}

tests/fixtures/minified-boundary@test/metadata.json

@@ -191,6 +191,12 @@ assert_exit_code "exits with 1 (has failures)" 1
 assert_output_contains "fails on minified JS" "\[FAIL\].*minified-js"
 echo ""
 
+# --- minified-boundary (2 long lines — below threshold) ---
+echo "=== minified-boundary ==="
+run_lint "minified-boundary@test"
+assert_output_not_contains "no minified-js with only 2 long lines" "\[FAIL\].*minified-js"
+echo ""
+
 # --- init-time-safety ---
 echo "=== init-time-safety ==="
 run_lint "init-time-safety@test"
@@ -428,6 +434,8 @@ assert_exit_code "exits with 1 (has failures)" 1
 assert_output_contains "fails on Meta.Rectangle" "\[FAIL\].*R-VER49-01"
 assert_output_contains "fails on Clutter.ClickAction" "\[FAIL\].*R-VER49-02"
 assert_output_contains "fails on Clutter.TapAction" "\[FAIL\].*R-VER49-03"
+assert_output_not_contains "no R-VER49-08 with ternary guard" "\[FAIL\].*R-VER49-08"
+assert_output_not_contains "no R-VER49-11 with ternary guard" "\[FAIL\].*R-VER49-11"
 echo ""
 
 # --- gnome46-extras ---