Merge branch 'main' into fix/tiling-shell-calibration

Author: ZviBaratz

skills/ego-lint/references/rules-reference.md

@@ -1130,10 +1130,10 @@ Rules for extension lifecycle management: enable/disable hooks, signal cleanup,
 ### R-LIFE-01: Signal Balance
 - **Severity**: advisory
 - **Checked by**: check-lifecycle.py
-- **Rule**: Detects imbalance between manual `.connect()` and `.disconnect()` calls (threshold: >2 imbalance). Recognizes `connectObject()`, `connectSmart()`, and `SignalTracker`/`SignalManager` as auto-cleanup patterns.
+- **Rule**: Detects imbalance between manual `.connect()` and `.disconnect()` calls (threshold: >2 imbalance). Recognizes `connectObject()`, `connectSmart()`, and `SignalTracker`/`SignalManager` as auto-cleanup patterns. Excludes: non-signal `.connect()` calls (no string-literal first argument), `'destroy'` signal connections (inherently self-cleaning), and signals on local/ephemeral variables (no `this` reference — garbage collected with scope).
 - **Rationale**: Unmatched signal connections are the #1 cause of extension rejections. Leaked signals cause memory leaks and crash loops.
 - **Fix**: For each `.connect()` call, ensure a matching `.disconnect()` in disable/destroy. Consider using `connectObject()` or a custom signal tracker for automatic cleanup.
-- **Tested by**: `tests/fixtures/lifecycle-basic@test/`, `tests/fixtures/signal-smart-connect@test/`
+- **Tested by**: `tests/fixtures/lifecycle-basic@test/`, `tests/fixtures/signal-smart-connect@test/`, `tests/fixtures/signal-non-gobject@test/`, `tests/fixtures/signal-destroy-connect@test/`, `tests/fixtures/signal-local-variable@test/`
 
 #### Example
 

skills/ego-lint/scripts/check-lifecycle.py

@@ -123,8 +123,13 @@ def check_signal_balance(ext_dir):
                 connect_objects += 1
             elif re.search(r'\.connectSmart\s*\(', line):
                 smart_connects += 1
-            elif re.search(r'\.connect\s*\(', line) and not re.search(r'\.disconnect', line):
-                pure_connects += 1
+            elif re.search(r"\.connect\s*\(\s*['\"]", line) and not re.search(r'\.disconnect', line):
+                if re.search(r"\.connect\s*\(\s*['\"]destroy['\"]", line):
+                    pass  # 'destroy' signal — inherently self-cleaning
+                elif not re.search(r'this[._]', line):
+                    pass  # local variable signal — inherently scoped
+                else:
+                    pure_connects += 1
             if re.search(r'\.disconnectObject\s*\(', line):
                 pass  # auto-cleanup
             elif re.search(r'\.disconnectSmart\s*\(', line):

tests/assertions/signal-balance-fp.sh

@@ -0,0 +1,23 @@
+# --- signal-non-gobject (Sub-issue A: non-signal .connect() not counted) ---
+echo "=== signal-non-gobject ==="
+run_lint "signal-non-gobject@test"
+assert_exit_code "exits with 0 (no failures)" 0
+assert_output_contains "signal balance OK" "\[PASS\].*lifecycle/signal-balance"
+assert_output_not_contains "no signal imbalance warning" "\[WARN\].*lifecycle/signal-balance"
+echo ""
+
+# --- signal-destroy-connect (Sub-issue B: destroy signal not counted) ---
+echo "=== signal-destroy-connect ==="
+run_lint "signal-destroy-connect@test"
+assert_exit_code "exits with 0 (no failures)" 0
+assert_output_contains "signal balance OK" "\[PASS\].*lifecycle/signal-balance"
+assert_output_not_contains "no signal imbalance warning" "\[WARN\].*lifecycle/signal-balance"
+echo ""
+
+# --- signal-local-variable (Sub-issue C: local-variable signal not counted) ---
+echo "=== signal-local-variable ==="
+run_lint "signal-local-variable@test"
+assert_exit_code "exits with 0 (no failures)" 0
+assert_output_contains "signal balance OK" "\[PASS\].*lifecycle/signal-balance"
+assert_output_not_contains "no signal imbalance warning" "\[WARN\].*lifecycle/signal-balance"
+echo ""

tests/fixtures/signal-destroy-connect@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/signal-destroy-connect@test/extension.js

@@ -0,0 +1,28 @@
+import * as Main from 'resource:///org/gnome/shell/ui/main.js';
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+
+export default class DestroySignalExtension extends Extension {
+    enable() {
+        this._settings = this.getSettings();
+        this._settingsId = this._settings.connect('changed::key', () => {});
+
+        // 'destroy' signal — self-cleaning, no disconnect needed
+        this._button = new St.Button();
+        this._button.connect('destroy', () => {
+            this._button = null;
+        });
+
+        // Another destroy signal on a different widget
+        this._icon = new St.Icon();
+        this._icon.connect('destroy', () => {
+            this._icon = null;
+        });
+    }
+
+    disable() {
+        this._settings.disconnect(this._settingsId);
+        this._settings = null;
+        this._button?.destroy();
+        this._icon?.destroy();
+    }
+}

tests/fixtures/signal-destroy-connect@test/metadata.json

@@ -0,0 +1,7 @@
+{
+    "uuid": "signal-destroy-connect@test",
+    "name": "Destroy Signal Connect Test",
+    "description": "Tests that destroy signal connections are not counted in signal balance",
+    "shell-version": ["48"],
+    "url": "https://github.com/test/signal-destroy-connect"
+}

tests/fixtures/signal-local-variable@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/signal-local-variable@test/extension.js

@@ -0,0 +1,26 @@
+import * as Main from 'resource:///org/gnome/shell/ui/main.js';
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+
+export default class LocalVariableSignalExtension extends Extension {
+    enable() {
+        this._settings = this.getSettings();
+        this._settingsId = this._settings.connect('changed::key', () => {});
+    }
+
+    _showNotification(text) {
+        // Ephemeral local variable — signal is garbage collected with it
+        let notification = new MessageTray.Notification(this._source, text);
+        notification.connect('activated', () => {
+            Main.extensionManager.openExtensionPrefs(this.uuid);
+        });
+
+        // Another ephemeral local signal
+        let dialog = new ModalDialog.ModalDialog();
+        dialog.connect('opened', () => log('dialog opened'));
+    }
+
+    disable() {
+        this._settings.disconnect(this._settingsId);
+        this._settings = null;
+    }
+}

tests/fixtures/signal-local-variable@test/metadata.json

@@ -0,0 +1,7 @@
+{
+    "uuid": "signal-local-variable@test",
+    "name": "Local Variable Signal Test",
+    "description": "Tests that signals on local/ephemeral variables are not counted in signal balance",
+    "shell-version": ["48"],
+    "url": "https://github.com/test/signal-local-variable"
+}

tests/fixtures/signal-non-gobject@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later