fix(ego-lint): narrow R-LIFE-25 auto-cleanup to D-Bus-specific disconnectSignal (#65)

## Summary

- R-LIFE-25 produced 0 lint hits because the auto-cleanup suppression
matched GObject signal mechanisms (`connectObject`, `disconnectObject`,
`SignalTracker`, `connectSmart`) which are irrelevant for D-Bus proxy
signals
- Every real-world extension using `connectObject` for widget/settings
signals had all `connectSignal` leak warnings suppressed
- Fix narrows auto-cleanup detection to only recognize
`disconnectSignal()` — the only valid D-Bus signal cleanup mechanism
- Adds `dbus-signal-mixed-cleanup@test` fixture testing the exact
false-negative scenario
- Updates `dbus-signal-auto-cleanup@test` fixture to use
`disconnectSignal` instead of `connectObject`

Closes #63

## Test plan

- [x] `dbus-signal-leak@test` → FAIL (bare connectSignal, no cleanup)
- [x] `dbus-signal-auto-cleanup@test` → PASS (has `disconnectSignal`)
- [x] `dbus-signal-mixed-cleanup@test` → FAIL (GObject cleanup doesn't
count for D-Bus)
- [x] Full test suite: 601 passed, 0 failed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/references/rules-reference.md

@@ -2070,12 +2070,12 @@ Rules for APIs removed or changed in specific GNOME Shell versions. These rules
 ### R-LIFE-25: D-Bus proxy signal leak (connectSignal without disconnectSignal)
 - **Severity**: blocking
 - **Checked by**: check-lifecycle.py
-- **Rule**: `proxy.connectSignal('...')` calls where the return value is not stored (no `=` or `.push()` before `.connectSignal` on the line) and no auto-cleanup mechanism (`disconnectObject`, `connectObject`, `SignalTracker`, `connectSmart`) is present in the extension.
+- **Rule**: `proxy.connectSignal('...')` calls where the return value is not stored (no `=` or `.push()` before `.connectSignal` on the line) and no `disconnectSignal()` call is present in the extension. GObject cleanup mechanisms (`connectObject`, `disconnectObject`, `SignalTracker`, `connectSmart`) do NOT clean up D-Bus proxy signals and are not considered valid cleanup.
 - **Rationale**: Without a stored signal ID, there is no way to call `proxy.disconnectSignal(id)` later. These D-Bus signal handlers accumulate across enable/disable cycles, causing duplicate callbacks and memory leaks. This is distinct from GObject `.connect()` — `connectSignal()` is specific to `Gio.DBusProxy` for subscribing to D-Bus signals (e.g., `PropertiesChanged`, `NameOwnerChanged`).
-- **Fix**: Store the return value and call `proxy.disconnectSignal(id)` in `disable()`, or use `connectObject()`/`disconnectObject()` for auto-cleanup.
+- **Fix**: Store the return value and call `proxy.disconnectSignal(id)` in `disable()`.
 - **Scope exclusions**: prefs.js (manages own lifecycle), `service/` directory (daemon lifecycle).
 - **Known limitations**: Multi-line `.connectSignal(\n'...'` calls are not detected (per-line scanning).
-- **Tested by**: `tests/fixtures/dbus-signal-leak@test/`, `tests/fixtures/dbus-signal-auto-cleanup@test/`, `tests/fixtures/dbus-signal-array-storage@test/`
+- **Tested by**: `tests/fixtures/dbus-signal-leak@test/`, `tests/fixtures/dbus-signal-auto-cleanup@test/`, `tests/fixtures/dbus-signal-array-storage@test/`, `tests/fixtures/dbus-signal-mixed-cleanup@test/`
 
 ### R-LIFE-26: Module-scope mutable state not cleared in disable()
 - **Severity**: advisory

skills/ego-lint/scripts/check-lifecycle.py

@@ -1286,17 +1286,16 @@ def check_dbus_signal_leak(ext_dir):
         return
 
     bare_connects = []
-    has_auto_cleanup = False
+    has_dbus_disconnect = False
 
     for filepath in js_files:
         content = strip_comments(read_file(filepath))
         rel = os.path.relpath(filepath, ext_dir)
 
-        # Extension-wide auto-cleanup detection
-        if (re.search(r'\.disconnectObject\s*\(', content) or
-                re.search(r'\.connectObject\s*\(', content) or
-                re.search(r'\b(SignalTracker|SignalManager|connectSmart|disconnectSmart)\b', content)):
-            has_auto_cleanup = True
+        # D-Bus-specific cleanup detection: only disconnectSignal counts
+        # (connectObject/disconnectObject manage GObject signals, not D-Bus signals)
+        if re.search(r'\.disconnectSignal\s*\(', content):
+            has_dbus_disconnect = True
 
         prev_stripped = ''
         for lineno, line in enumerate(content.splitlines(), 1):
@@ -1325,16 +1324,16 @@ def check_dbus_signal_leak(ext_dir):
             bare_connects.append(f"{rel}:{lineno}")
             prev_stripped = stripped
 
-    if bare_connects and not has_auto_cleanup:
+    if bare_connects and not has_dbus_disconnect:
         count = len(bare_connects)
         locs = ', '.join(bare_connects[:5])
         suffix = f' (and {count - 5} more)' if count > 5 else ''
         result("FAIL", "lifecycle/dbus-signal-leak",
                f"{count} bare proxy.connectSignal() without stored ID "
-               f"and no disconnectObject/connectObject cleanup: {locs}{suffix}")
+               f"and no disconnectSignal() cleanup: {locs}{suffix}")
     elif bare_connects:
         result("PASS", "lifecycle/dbus-signal-leak",
-               "Bare connectSignal() found but auto-cleanup mechanism present")
+               "Bare connectSignal() found but disconnectSignal() cleanup present")
     # If no bare connectSignal calls, skip silently
 
 

tests/assertions/dbus-signal-leak.sh

@@ -20,3 +20,10 @@ run_lint "dbus-signal-array-storage@test"
 assert_exit_code "exits with 0 (array storage is not bare connect)" 0
 assert_output_not_contains "no dbus-signal-leak FP on array storage" "\[FAIL\].*lifecycle/dbus-signal-leak"
 echo ""
+
+echo "=== dbus-signal-mixed-cleanup ==="
+run_lint "dbus-signal-mixed-cleanup@test"
+assert_exit_code "exits with 1 (has failures)" 1
+assert_output_contains "fails despite GObject cleanup" "\[FAIL\].*lifecycle/dbus-signal-leak"
+assert_output_not_contains "no false auto-cleanup pass" "\[PASS\].*lifecycle/dbus-signal-leak"
+echo ""

tests/fixtures/dbus-signal-auto-cleanup@test/extension.js

@@ -9,15 +9,13 @@ export default class DbusAutoCleanupExtension extends Extension {
             'org.mpris.MediaPlayer2.Player', null);
         this._proxy.connectSignal('PropertiesChanged', () => this._onProps());
 
-        this._settings = this.getSettings();
-        this._settings.connectObject('changed::mode', () => {}, this);
+        this._seekedId = this._proxy.connectSignal('Seeked', () => {});
     }
 
     _onProps() {}
 
     disable() {
-        this._settings.disconnectObject(this);
+        this._proxy.disconnectSignal(this._seekedId);
         this._proxy = null;
-        this._settings = null;
     }
 }

tests/fixtures/dbus-signal-mixed-cleanup@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/dbus-signal-mixed-cleanup@test/extension.js

@@ -0,0 +1,23 @@
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+import Gio from 'gi://Gio';
+
+export default class DbusMixedCleanupExtension extends Extension {
+    enable() {
+        this._proxy = Gio.DBusProxy.new_for_bus_sync(
+            Gio.BusType.SESSION, 0, null,
+            'org.mpris.MediaPlayer2', '/org/mpris/MediaPlayer2',
+            'org.mpris.MediaPlayer2.Player', null);
+        this._proxy.connectSignal('PropertiesChanged', () => this._onProps());
+
+        this._settings = this.getSettings();
+        this._settings.connectObject('changed::mode', () => {}, this);
+    }
+
+    _onProps() {}
+
+    disable() {
+        this._settings.disconnectObject(this);
+        this._proxy = null;
+        this._settings = null;
+    }
+}

tests/fixtures/dbus-signal-mixed-cleanup@test/metadata.json

@@ -0,0 +1,7 @@
+{
+  "uuid": "dbus-signal-mixed-cleanup@test",
+  "name": "D-Bus Signal Mixed Cleanup Test",
+  "shell-version": ["45"],
+  "description": "Fixture for R-LIFE-25: bare connectSignal with GObject-only cleanup",
+  "url": "https://example.com"
+}