Merge branch 'main' into fix/check-schema-enum-id-fp

Author: ZviBaratz

field-tests/annotations/blur-my-shell.yaml

@@ -15,16 +15,16 @@ findings:
   - id: "R-VER47-01::Clutter.Color"
     classification: borderline
     notes: "appfolders.js has ternary runtime guard (Clutter.Color ? ... : Cogl.Color), but file crashes before reaching this code due to Tweener import"
-  # WARNs — False Positives
+  # WARNs — Resolved False Positives (fixed 2026-03-12)
   - id: "resource-tracking/destroy-not-called::disable() not recognized"
-    classification: fp
-    notes: "63 hits — components use .disable() not .destroy() as cleanup. Resource graph only recognizes destroy()."
+    classification: resolved
+    notes: "63→0 hits — fixed by multi-parent ownership + Case 2 stored_as=None filter (PR #143). Finding no longer emitted."
   - id: "quality/constructor-resources::pipeline instances"
-    classification: fp
-    notes: "17 hits — mostly FP, pipeline instances managed via parent lifecycle"
+    classification: resolved
+    notes: "17→1 hits — fixed by src/preferences path exclusion. Remaining hit (settings.js:304) is TP, annotated separately."
   - id: "resource-tracking/no-destroy-method::utility classes"
-    classification: fp
-    notes: "10 hits — utility classes use disconnect_all(), remove() instead"
+    classification: resolved
+    notes: "10→0 hits — fixed by destroy_\\w+ recognition + multi-parent ownership (PR #143). Finding no longer emitted."
   - id: "R-SLOP-38::descriptive identifier"
     classification: resolved
     notes: "dash_not_already_destroyed is descriptive, not AI verbosity. Fixed: guard-pattern."

field-tests/annotations/gsconnect.yaml

@@ -45,8 +45,8 @@ findings:
     classification: resolved
     notes: "52 hits — same as above. Fixed: provenance post-filter. Finding no longer emitted."
   - id: "R-SLOP-24::new Gio.Settings in service/"
-    classification: borderline
-    notes: "20 hits — many in service/ daemon where Extension class is unavailable"
+    classification: resolved
+    notes: "20→8 hits — service/ excluded from R-SLOP-24 via exclude-dirs. Remaining hits in extension code are TP."
   - id: "quality/constructor-resources::service/ui widgets"
     classification: borderline
     notes: "28 hits — many in service/ui/ (daemon GTK widgets, not extension lifecycle)"
@@ -63,8 +63,8 @@ findings:
     classification: tp
     notes: "6 instances — needs justification comments"
   - id: "R-QUAL-32::unnecessary version specifier"
-    classification: borderline
-    notes: "7 hits — version specifiers correct for standalone daemon scripts"
+    classification: resolved
+    notes: "7→0 hits — service/ excluded from R-QUAL-32 via exclude-dirs. Finding no longer emitted."
   # Resolved in 03-08 — service/ directory exempted (PR #88)
   - id: "lifecycle/prototype-override::service/ exempted"
     classification: resolved
@@ -154,21 +154,23 @@ findings:
   - id: "R-SEC-03::Use HTTPS instead of HTTP for network requests"
     classification: borderline
     notes: "3 of 4 hits are HTTP URLs in comments (reference links); 1 is legitimate protocol scheme fallback in code"
+  # Resolved by service/ exclusion (2026-03-18)
   - id: "R-SLOP-24::new Gio.Settings() is incorrect in GNOME 45+; use this.getSettings() from Extension base class"
-    classification: borderline
-    notes: "Many in service/ daemon where Extension base class is unavailable"
+    classification: resolved
+    notes: "Service/ findings excluded. Remaining 8 hits in extension code are TP (already counted in R-SLOP-24 annotation above)."
   - id: "R-SLOP-43::Underscore-prefixed export — private convention conflicts with public export"
-    classification: borderline
-    notes: "Exports in service/ code (_getDeviceType, _configureSocket) — internal API naming convention for daemon"
+    classification: resolved
+    notes: "2→0 service/ hits — excluded via exclude-dirs. Finding no longer emitted."
   - id: "R-QUAL-32::Unnecessary ?version= in gi:// import — this library does not require a version specifier"
-    classification: borderline
-    notes: "Version specifiers correct for standalone daemon scripts that need explicit versioning"
+    classification: resolved
+    notes: "7→0 service/ hits — excluded via exclude-dirs. Finding no longer emitted."
   - id: "quality/module-state::Module-level mutable state at service/nativeMessagingHost.js, service/backends/lan.js — ensure reset in both enable() and disable()"
-    classification: borderline
-    notes: "Both files in service/ daemon context — module state less relevant outside shell extension lifecycle"
+    classification: resolved
+    notes: "2→0 service/ hits — excluded from check_module_state(). Finding no longer emitted."
   - id: "quality/repeated-settings::20 getSettings()/Gio.Settings instances across extension files (extension.js, extension.js, shell/input.js, utils/setup.js, service/daemon.js) — store a single instance and pass via dependency injection"
-    classification: borderline
-    notes: "Includes service/ daemon files where Extension.getSettings() is unavailable — count inflated by daemon context"
+    classification: resolved
+    notes: "20→8 instances — service/ excluded from count. Superseded by updated 8-instance finding."
+  # Remaining borderlines (service/ exclusion doesn't apply)
   - id: "resource-tracking/orphan-gsettings::service/manager.js — this._settings created but not cleaned up in destroy()"
     classification: borderline
     notes: "service/manager.js is daemon code — GSettings cleanup less critical in standalone process"
@@ -178,6 +180,13 @@ findings:
   - id: "resource-tracking/ownership::64 files scanned, depth 2, 8 orphans detected"
     classification: borderline
     notes: "Orphan count includes service/ daemon files — reduced from 13 to 8 after destroy_\\w+ recognition + multi-parent ownership + Case 2 stored_as filter"
+  # New findings from service/ exclusion (2026-03-18) — updated detail strings
+  - id: "quality/repeated-settings::8 getSettings()/Gio.Settings instances across extension files (extension.js, extension.js, shell/input.js, utils/setup.js) — store a single instance and pass via dependency injection"
+    classification: tp
+    notes: "8 instances in extension code (service/ excluded) — valid advisory for reducing redundant settings access"
+  - id: "lifecycle/timeout-return-value::timeout_add/idle_add callback missing SOURCE_REMOVE/SOURCE_CONTINUE: shell/tooltip.js, shell/tooltip.js, service/ui/messaging.js"
+    classification: tp
+    notes: "Timer callbacks in shell/ should return SOURCE_REMOVE/SOURCE_CONTINUE — valid advisory"
 
   # FAIL findings — True Positives
   - id: "license::No LICENSE or COPYING file — should use GPL-compatible license"

field-tests/annotations/hara-hachi-bu.yaml

@@ -50,8 +50,11 @@ findings:
     classification: tp
     notes: "Correct advisory, deduplicated to 1 per file"
   - id: "metadata/shell-version-current::GNOME 49 not in shell-version"
+    classification: resolved
+    notes: "Extension updated to include GNOME 49/50 — finding no longer emitted"
+  - id: "metadata/future-shell-version::shell-version '50' is newer than current stable (49)"
     classification: expected
-    notes: "Intentional — GNOME 49 not yet tested"
+    notes: "Extension declares GNOME 50 support ahead of release"
   - id: "quality/private-api::private API with justification"
     classification: tp
     notes: "Disclosed in metadata — correct advisory"
@@ -72,54 +75,55 @@ findings:
   - id: "R-DEPR-04-legacy::Not applicable for declared shell-version(s)"
     classification: expected
     notes: "Version-gated skip — not applicable for declared shell-version"
+  # R-VER49-* and R-VER50-* — resolved (extension now declares GNOME 49/50, checks apply and PASS)
   - id: "R-VER49-01::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-02::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-03::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-04::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-05::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-06::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-07::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-08::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-09::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-10::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER49-11::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 49"
+    classification: resolved
+    notes: "Extension updated to target GNOME 49 — check now applies and passes"
   - id: "R-VER50-01::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 50"
+    classification: resolved
+    notes: "Extension updated to target GNOME 50 — check now applies and passes"
   - id: "R-VER50-02::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 50"
+    classification: resolved
+    notes: "Extension updated to target GNOME 50 — check now applies and passes"
   - id: "R-VER50-03::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 50"
+    classification: resolved
+    notes: "Extension updated to target GNOME 50 — check now applies and passes"
   - id: "R-VER50-04::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 50"
+    classification: resolved
+    notes: "Extension updated to target GNOME 50 — check now applies and passes"
   - id: "R-VER50-05::Not applicable for declared shell-version(s)"
-    classification: expected
-    notes: "Version-gated skip — extension does not target GNOME 50"
+    classification: resolved
+    notes: "Extension updated to target GNOME 50 — check now applies and passes"
   # SKIP findings — static analysis limitations
   - id: "schema-usage/unused-key::Dynamic key access detected — cannot verify statically"
     classification: expected
@@ -150,8 +154,8 @@ findings:
     classification: expected
     notes: "Optional tooling — ESLint config error is an environment issue"
   - id: "metadata/shell-version-current::shell-version does not include GNOME 49"
-    classification: expected
-    notes: "Intentional — GNOME 49 not yet tested"
+    classification: resolved
+    notes: "Extension updated to include GNOME 49 — finding no longer emitted"
   - id: "quality/private-api::lib/quickSettingsPanel.js, lib/quickSettingsPanel.js, lib/quickSettingsPanel.js, lib/quickSettingsPanel.js, lib/quickSettingsPanel.js (+6 more): quickSettings private API access — requires reviewer justification and version pinning"
     classification: tp
     notes: "Private API access is real — disclosed in metadata"

field-tests/baselines/appindicator.json

@@ -1,8 +1,8 @@
 {
   "name": "appindicator",
   "uuid": "appindicatorsupport@rgcjonas.gmail.com",
-  "timestamp": "2026-03-12T10:58:10.872002+00:00",
-  "ego_lint_version": "1a58b06",
+  "timestamp": "2026-03-18T20:53:15.167124+00:00",
+  "ego_lint_version": "e74c508",
   "ego_approved": true,
   "exit_code": 1,
   "counts": {

field-tests/baselines/blur-my-shell.json

@@ -1,8 +1,8 @@
 {
   "name": "blur-my-shell",
   "uuid": "blur-my-shell@aunetx",
-  "timestamp": "2026-03-12T19:22:51.358363+00:00",
-  "ego_lint_version": "a7e0a2c",
+  "timestamp": "2026-03-18T20:53:17.277909+00:00",
+  "ego_lint_version": "e74c508",
   "ego_approved": true,
   "exit_code": 1,
   "counts": {

field-tests/baselines/clipboard-indicator.json

@@ -1,8 +1,8 @@
 {
   "name": "clipboard-indicator",
   "uuid": "clipboard-indicator@tudmotu.com",
-  "timestamp": "2026-03-12T10:58:11.682237+00:00",
-  "ego_lint_version": "1a58b06",
+  "timestamp": "2026-03-18T20:53:15.993144+00:00",
+  "ego_lint_version": "e74c508",
   "ego_approved": true,
   "exit_code": 1,
   "counts": {

field-tests/baselines/dash-to-panel.json

@@ -1,8 +1,8 @@
 {
   "name": "dash-to-panel",
   "uuid": "dash-to-panel@jderose9.github.com",
-  "timestamp": "2026-03-12T10:58:14.418773+00:00",
-  "ego_lint_version": "1a58b06",
+  "timestamp": "2026-03-18T20:53:18.848154+00:00",
+  "ego_lint_version": "e74c508",
   "ego_approved": true,
   "exit_code": 1,
   "counts": {