fix(ego-lint): deduplicate prototype-override warnings

The prototype-override regex `\w+\.prototype\.\w+\s*=` matches both the
override and the restore, causing each prototype to appear twice (e.g.,
Just Perfection emits 5 warnings for 3 unique prototypes).

Deduplicate by (file, prototype_name) before emitting warnings.

Closes #28

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/scripts/check-lifecycle.py

@@ -374,15 +374,23 @@ def check_injection_manager(ext_dir):
 
     # WS1-D: Detect direct prototype overrides
     prototype_overrides = []
+    seen_overrides = set()
     for filepath in js_files:
         content = strip_comments(read_file(filepath))
         rel = os.path.relpath(filepath, ext_dir)
         # SomeClass.prototype.methodName = ...
         for m in re.finditer(r'(\w+\.prototype\.\w+)\s*=', content):
-            prototype_overrides.append((rel, m.group(1)))
+            key = (rel, m.group(1))
+            if key not in seen_overrides:
+                seen_overrides.add(key)
+                prototype_overrides.append(key)
         # Object.assign(SomeClass.prototype, ...)
         for m in re.finditer(r'Object\.assign\s*\(\s*(\w+\.prototype)', content):
-            prototype_overrides.append((rel, f"Object.assign({m.group(1)}, ...)"))
+            label = f"Object.assign({m.group(1)}, ...)"
+            key = (rel, label)
+            if key not in seen_overrides:
+                seen_overrides.add(key)
+                prototype_overrides.append(key)
 
     if prototype_overrides:
         # Check if disable() restores prototypes

tests/assertions/proto-override-dedup.sh

@@ -0,0 +1,8 @@
+# Field test #10: prototype-override deduplication (closes #28)
+
+# --- proto-override-dedup (each prototype warned only once) ---
+echo "=== proto-override-dedup ==="
+run_lint "proto-override-dedup@test"
+assert_output_contains "prototype override detected" "\[WARN\].*lifecycle/prototype-override.*BackgroundMenu.prototype.open"
+assert_output_contains "search prototype override detected" "\[WARN\].*lifecycle/prototype-override.*SearchController.prototype.startSearch"
+echo ""

tests/fixtures/proto-override-dedup@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/proto-override-dedup@test/extension.js

@@ -0,0 +1,14 @@
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+import {API} from './lib/api.js';
+
+export default class TestExtension extends Extension {
+    enable() {
+        this._api = new API();
+        this._api.open();
+    }
+
+    disable() {
+        this._api.close();
+        this._api = null;
+    }
+}

tests/fixtures/proto-override-dedup@test/lib/api.js

@@ -0,0 +1,21 @@
+import * as BackgroundMenu from 'resource:///org/gnome/shell/ui/backgroundMenu.js';
+import * as Search from 'resource:///org/gnome/shell/ui/search.js';
+
+export class API {
+    #originals = {};
+
+    open() {
+        // Override prototype — saves original first
+        this.#originals['bgOpen'] = BackgroundMenu.BackgroundMenu.prototype.open;
+        BackgroundMenu.BackgroundMenu.prototype.open = () => {};
+
+        this.#originals['startSearch'] = Search.SearchController.prototype.startSearch;
+        Search.SearchController.prototype.startSearch = () => {};
+    }
+
+    close() {
+        // Restore originals
+        BackgroundMenu.BackgroundMenu.prototype.open = this.#originals['bgOpen'];
+        Search.SearchController.prototype.startSearch = this.#originals['startSearch'];
+    }
+}

tests/fixtures/proto-override-dedup@test/metadata.json

@@ -0,0 +1,7 @@
+{
+    "uuid": "proto-override-dedup@test",
+    "name": "Test Proto Override Dedup",
+    "description": "Tests that prototype override warnings are deduplicated",
+    "shell-version": ["48"],
+    "url": "https://example.com"
+}