Skip to content

Commit c0466a7

Browse files
ZviBaratzclaude
andcommitted
fix(ego-review): add NOT-a-signal exception to ai-slop item #4
The `_destroyed + _initializing` pattern was falsely flagged as BLOCKING during ego-simulate runs. The `_initializing` flag serving as a re-entrancy guard is legitimate — the red flag targets `_pendingDestroy` coordination, not simple re-entrancy prevention. Closes #1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent e170c1d commit c0466a7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

skills/ego-review/references/ai-slop-checklist.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ Over-engineered async teardown with multiple coordinating state flags.
9090

9191
- **Red flag:** Both `_pendingDestroy` and `_initializing` flags used together,
9292
or elaborate state machines for initialization/destruction sequencing
93+
- **NOT a signal:** `_destroyed` combined with `_initializing` where
94+
`_initializing` only serves as a re-entrancy guard (prevents `enable()`
95+
from starting a parallel init while the first is in-flight). The red flag
96+
targets additional deferred-cleanup flags like `_pendingDestroy` that
97+
coordinate between enable/disable beyond the standard `_destroyed` check.
9398
- **Acceptable:** Simple `_destroyed` flag checked at async resume points
9499
(see the [lifecycle checklist](lifecycle-checklist.md#the-_destroyed-flag-pattern))
95100

0 commit comments

Comments
 (0)