fix(ego-lint): fix ARROW_FN_DEF regex and test assertions

The arrow function exemption in check-init.py never fired due to
Python implicit string concatenation producing `=(?:` instead of
`=\s*(?:` — missing whitespace match between assignment and params.

Also fix test assertions: swap descriptions to match their patterns,
and replace vacuous `getMonitors` pattern (source content never
appears in ego-lint output) with `extension.js:8` (actual line number).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

skills/ego-lint/scripts/check-init.py

@@ -64,7 +64,7 @@ def is_skip_line(line):
 # Arrow function definitions: the body after => is lazy (not executed at
 # module scope).  Detect `const fn = (...) => expr` patterns.
 ARROW_FN_DEF = re.compile(
-    r'(?:const|let|var)\s+\w+\s*='   # variable assignment
+    r'(?:const|let|var)\s+\w+\s*=\s*'   # variable assignment
     r'(?:\([^)]*\)|\w+)'                 # parameter list or single param
     r'\s*=>'                              # arrow
 )

tests/run-tests.sh

@@ -196,8 +196,8 @@ echo "=== init-time-safety ==="
 run_lint "init-time-safety@test"
 assert_exit_code "exits with 1 (has module-scope violation)" 1
 assert_output_contains "fails on module-scope Main access" "\[FAIL\].*init/shell-modification"
-assert_output_not_contains "no FP on arrow function definition" "init/shell-modification.*helper.js"
-assert_output_not_contains "no FP on helper constructor" "init/shell-modification.*getMonitors"
+assert_output_not_contains "no FP on helper constructor" "init/shell-modification.*helper.js"
+assert_output_not_contains "no FP on arrow function definition" "init/shell-modification.*extension.js:8"
 echo ""
 
 # --- lifecycle-imbalance ---