fix(ego-lint): add replacement-pattern to R-VER rules for version-compat suppression (#84)

## Summary

- Add file-level `replacement-pattern` to 4 version-compat rules
(R-VER44-02, R-VER46-04, R-VER49-08, R-VER49-11) to suppress findings
when the replacement API is present in the same file
- Skip 3 rules where the replacement API is too common for file-level
suppression (R-VER46-01, R-VER46-02, R-VER46-07)
- Add test fixture `ver-replacement-compat@test` with 4 assertions
verifying suppression

### Rules updated

| Rule | Deprecated API | replacement-pattern | Rationale |
|------|---|---|---|
| R-VER44-02 | `Meta.later_remove` | `get_laters` | New API path
`get_laters().removeLater()` |
| R-VER46-04 | `Gio.UnixInputStream` | `GioUnix` | New module name |
| R-VER49-08 | `maximize(MaximizeFlags)` | `set_maximize_flags` | New
API for flag setting |
| R-VER49-11 | `unmaximize(MaximizeFlags)` | `set_maximize_flags` | Same
new API |

### Rules skipped (replacement API too common)

| Rule | Why |
|------|-----|
| R-VER46-01 `.add_actor()` | `add_child` ubiquitous in extensions |
| R-VER46-02 `.remove_actor()` | `remove_child` ubiquitous in extensions
|
| R-VER46-07 `Clutter.Container` | No specific replacement;
`Clutter.Actor` everywhere |

## Test plan

- [x] `bash tests/run-tests.sh` — 607 passed, 0 failed
- [x] New `ver-replacement-compat@test` fixture verifies all 4 rules
suppressed when replacement API present
- [x] Existing `gnome46-compat`, `gnome48-compat`, `gnome49-compat`
fixtures still FAIL correctly (no replacement APIs in those files)

Closes #74

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: ZviBaratz

rules/patterns.yaml

@@ -812,6 +812,7 @@
   category: version-compat
   fix: "Use global.compositor.get_laters().addLater(Meta.LaterType.BEFORE_REDRAW, callback)"
   min-version: 44
+  replacement-pattern: "get_laters"
 
 - id: R-VER44-02
   pattern: "\\bMeta\\.later_remove\\b"
@@ -823,6 +824,7 @@
   min-version: 44
   guard-pattern: "if\\s*\\(\\s*global\\.compositor\\s*\\)"
   guard-window: 7
+  replacement-pattern: "get_laters"
 
 - id: R-VER46-01
   pattern: "\\.add_actor\\s*\\("
@@ -862,6 +864,7 @@
   fix: "Import GioUnix from 'gi://GioUnix' and use GioUnix.InputStream"
   min-version: 46
   guard-pattern: "\\bGioUnix\\b"
+  replacement-pattern: "GioUnix"
 
 - id: R-VER46-05
   pattern: "\\bExtensionState\\.(ENABLED|DISABLED|INITIALIZED|DEACTIVATING|ACTIVATING)\\b"
@@ -1065,6 +1068,7 @@
   min-version: 49
   guard-pattern: "get_maximized\\s*\\?"
   guard-window: 1
+  replacement-pattern: "set_maximize_flags"
 
 - id: R-VER49-09
   pattern: "\\bAppMenuButton\\b"
@@ -1094,6 +1098,7 @@
   fix: "Call unmaximize() without the MaximizeFlags parameter"
   guard-pattern: "get_maximized\\s*\\?"
   guard-window: 1
+  replacement-pattern: "set_maximize_flags"
 
 # --- GNOME 50 migration (version-gated) ---
 # GNOME 50 removed X11 support and associated APIs.

tests/fixtures/ver-replacement-compat@test/LICENSE

@@ -0,0 +1 @@
+SPDX-License-Identifier: GPL-2.0-or-later

tests/fixtures/ver-replacement-compat@test/extension.js

@@ -0,0 +1,42 @@
+import {Extension} from 'resource:///org/gnome/shell/extensions/extension.js';
+import Meta from 'gi://Meta';
+import Gio from 'gi://Gio';
+
+let GioUnix;
+try {
+    GioUnix = (await import('gi://GioUnix')).default;
+} catch {
+    // fallback for GNOME < 46
+}
+
+export default class VersionReplacementCompat extends Extension {
+    enable() {
+        // R-VER44-01: old API (suppressed — file contains "get_laters")
+        this._laterId = Meta.later_add(Meta.LaterType.BEFORE_REDRAW, () => {});
+
+        // R-VER44-02: old API (suppressed — file contains "get_laters")
+        Meta.later_remove(this._laterId);
+
+        // R-VER46-04: old API (suppressed — file contains "GioUnix")
+        this._stream = new Gio.UnixInputStream({fd: 0});
+
+        // R-VER49-08: old API (suppressed — file contains "set_maximize_flags")
+        this._win.maximize(Meta.MaximizeFlags.BOTH);
+
+        // R-VER49-11: old API (suppressed — file contains "set_maximize_flags")
+        this._win.unmaximize(Meta.MaximizeFlags.BOTH);
+    }
+
+    _newApi() {
+        // Replacement APIs present in file for version-compat
+        const laters = global.compositor.get_laters();
+        laters.removeLater(this._laterId);
+        this._win.set_maximize_flags(Meta.MaximizeFlags.BOTH);
+        this._win.maximize();
+    }
+
+    disable() {
+        this._stream = null;
+        this._win = null;
+    }
+}

tests/fixtures/ver-replacement-compat@test/metadata.json

@@ -0,0 +1,7 @@
+{
+  "uuid": "ver-replacement-compat@test",
+  "name": "Version Replacement Compat Test",
+  "description": "Tests replacement-pattern suppression for version-compat code",
+  "shell-version": ["49"],
+  "url": ""
+}

tests/run-tests.sh

@@ -453,6 +453,16 @@ assert_output_not_contains "no R-VER49-08 with ternary guard" "\[FAIL\].*R-VER49
 assert_output_not_contains "no R-VER49-11 with ternary guard" "\[FAIL\].*R-VER49-11"
 echo ""
 
+# --- ver-replacement-compat ---
+echo "=== ver-replacement-compat ==="
+run_lint "ver-replacement-compat@test"
+assert_output_not_contains "no R-VER44-01 with replacement-pattern" "\[FAIL\].*R-VER44-01"
+assert_output_not_contains "no R-VER44-02 with replacement-pattern" "\[FAIL\].*R-VER44-02"
+assert_output_not_contains "no R-VER46-04 with replacement-pattern" "\[FAIL\].*R-VER46-04"
+assert_output_not_contains "no R-VER49-08 with replacement-pattern" "\[FAIL\].*R-VER49-08"
+assert_output_not_contains "no R-VER49-11 with replacement-pattern" "\[FAIL\].*R-VER49-11"
+echo ""
+
 # --- gnome46-extras ---
 echo "=== gnome46-extras ==="
 run_lint "gnome46-extras@test"