Wrong "cosntruction" tag applied to road

[paaspaas00]

Hi @dabreegster, thanks for this amazing tool!

I nothiced something wierd.
See https://a-b-street.github.io/osm2streets/index.html#17.9/43.618265/12.67281

It marks the road segment as "construction" (orange one)

But it isn't:

and the "construction" property is indeed nowhere to be found in the overpass response:

It's this segment here:
https://www.openstreetmap.org/way/104155746#map=19/43.618578/12.672512

I guess is some bug in osm2streets

[paaspaas00]

it could be due to this #89

[dabreegster]

Yep, it's due to the access=permit. Muv plumbs through the more detailed access info (expand the "Full Muv JSON"). I reckon we could modify

osm2streets/osm2lanes/src/algorithm.rs

Line 218 in 79ed2bb

fn access_level_allowed(access: AccessLevel) -> bool {

to allow permit.

It definitely doesn't make sense to mark private/permit-only roads as under construction, but it is also strange to not represent access restrictions visually. What do you think?

[paaspaas00]

It could be marked with some other color or something like striped red/white oblique lines (or maybe this can be used for roads in construction and use orange for access restrictions? In case, different shades of orange for different levels of access?)

[dabreegster]

Since we already treat access=discouraged,permissive,private,etc as regular, I've just added permit as an allowed case here. It'll take much more work to rethink the appropriate level of detail for access restrictions in osm2streets. Originally osm2streets was primarily serving a traffic simulator and router (which would need to then model if a particular user has the right permit or not), but now it's mostly just used for visualization.