test: add and refine private-methods fixture tests

Add 5 new fixtures (does-not-flag-non-reserved-prefix, zero-private-methods,
multiple-collisions, cross-method-private-calls, similar-prefixes), simplify
multiple-private-methods, and rename static-async-private-method to
static-private-method.

Made-with: Cursor

Author: a-chabot

packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/cross-method-private-calls/actual.js

@@ -0,0 +1,9 @@
+import { LightningElement } from 'lwc';
+export default class Test extends LightningElement {
+    #helper() {
+        return 42;
+    }
+    #caller() {
+        return this.#helper() + 1;
+    }
+}

…s/static-async-private-method/error.json …ds/cross-method-private-calls/error.jsonpackages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/static-async-private-method/error.json renamed to packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/cross-method-private-calls/error.json packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/static-async-private-method/error.json renamed to packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/cross-method-private-calls/error.json

@@ -1,13 +1,11 @@
 import _tmpl from "./test.html";
 import { LightningElement, registerComponent as _registerComponent } from 'lwc';
 class Test extends LightningElement {
-  static async #fetchData(url) {
-    const response = await fetch(url);
-    return response.json();
+  #helper() {
+    return 42;
   }
-  async connectedCallback() {
-    const data = await Test.#fetchData('/api/data');
-    console.log(data);
+  #caller() {
+    return this.#helper() + 1;
   }
   /*LWC compiler vX.X.X*/
 }

…/static-async-private-method/expected.js …s/cross-method-private-calls/expected.jspackages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/static-async-private-method/expected.js renamed to packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/cross-method-private-calls/expected.js packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/static-async-private-method/expected.js renamed to packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/cross-method-private-calls/expected.js

@@ -0,0 +1,12 @@
+import { LightningElement } from 'lwc';
+export default class Test extends LightningElement {
+    #privateMethod() {
+        return 1;
+    }
+    normalPublicMethod() {
+        return 2;
+    }
+    _underscoreMethod() {
+        return 3;
+    }
+}

packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/does-not-flag-non-reserved-prefix/actual.js

@@ -0,0 +1,20 @@
+import _tmpl from "./test.html";
+import { LightningElement, registerComponent as _registerComponent } from 'lwc';
+class Test extends LightningElement {
+  #privateMethod() {
+    return 1;
+  }
+  normalPublicMethod() {
+    return 2;
+  }
+  _underscoreMethod() {
+    return 3;
+  }
+  /*LWC compiler vX.X.X*/
+}
+const __lwc_component_class_internal = _registerComponent(Test, {
+  tmpl: _tmpl,
+  sel: "lwc-test",
+  apiVersion: 9999999
+});
+export default __lwc_component_class_internal;

packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/does-not-flag-non-reserved-prefix/error.json

@@ -0,0 +1,9 @@
+import { LightningElement } from 'lwc';
+export default class Test extends LightningElement {
+    __lwc_component_class_internal_private_collisionA() {
+        return 1;
+    }
+    __lwc_component_class_internal_private_collisionB() {
+        return 2;
+    }
+}

packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/does-not-flag-non-reserved-prefix/expected.js

@@ -0,0 +1,3 @@
+{
+    "message": "Method '__lwc_component_class_internal_private_collisionA' cannot start with reserved prefix `__lwc_`. Please rename this function to avoid conflict."
+}

packages/@lwc/babel-plugin-component/src/__tests__/fixtures/private-methods/multiple-collisions/actual.js

@@ -1,18 +1,12 @@
 import { LightningElement } from 'lwc';
 export default class Test extends LightningElement {
-    #validate(input) {
-        return input != null;
+    #method1() {
+        return 1;
     }
-    #transform(input) {
-        return String(input).trim();
+    #method2() {
+        return 2;
     }
-    #process(input) {
-        if (this.#validate(input)) {
-            return this.#transform(input);
-        }
-        return null;
-    }
-    connectedCallback() {
-        this.#process('hello');
+    #method3() {
+        return 3;
     }
 }