Skip to content

Commit 2564bf7

Browse files
authored
fix: send blocks before signaling sync complete (#725)
1 parent 11bc2dc commit 2564bf7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ethereum/consensus-core/tests/runner/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ fn get_forks(with_electra: bool) -> Forks {
183183
epoch: if with_electra { 0 } else { u64::MAX },
184184
fork_version: fixed_bytes!("05000001"),
185185
},
186-
fusaka: Fork {
186+
fulu: Fork {
187187
epoch: u64::MAX,
188188
fork_version: fixed_bytes!("06000001"),
189189
},

ethereum/src/consensus.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ impl<S: ConsensusSpec, R: ConsensusRpc<S>, DB: Database> ConsensusClient<S, R, D
167167
}
168168
}
169169

170-
_ = sync_status_send.send(ConsensusSyncStatus::Synced);
171170
_ = inner.send_blocks().await;
171+
_ = sync_status_send.send(ConsensusSyncStatus::Synced);
172172

173173
let start = Instant::now() + inner.duration_until_next_update().to_std().unwrap();
174174
let mut interval = interval_at(start, std::time::Duration::from_secs(12));

tests/rpc_equivalence.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,7 @@ async fn test_get_balance_zero_address(
931931

932932
async fn test_get_code_eoa_address(helios: &RootProvider, expected: &RootProvider) -> Result<()> {
933933
let block_num = helios.get_block_number().await?;
934-
let eoa_address = address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045"); // vitalik.eth
934+
let eoa_address = address!("4838B106FCe9647Bdf1E7877BF73cE8B0BAD5f97");
935935

936936
let code = helios
937937
.get_code_at(eoa_address)
@@ -949,7 +949,7 @@ async fn test_get_code_eoa_address(helios: &RootProvider, expected: &RootProvide
949949
code.len()
950950
);
951951
if !code.is_empty() {
952-
return Err(eyre::eyre!("EOA should have empty code"));
952+
return Err(eyre::eyre!("EOA should have empty code. Found: {}", code));
953953
}
954954
Ok(())
955955
}

0 commit comments

Comments
 (0)