Skip to content

Commit 02ed767

Browse files
committed
Support explicit None overrides by removing exclude_none in MessageSendConfiguration handling
1 parent 7d1adcf commit 02ed767

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

src/a2a/client/base_client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ async def send_message(
8080
if configuration is not None:
8181
overrides = configuration.model_dump(
8282
exclude_unset=True,
83-
exclude_none=True,
8483
by_alias=False,
8584
)
8685
config = base_config.model_copy(update=overrides)

tests/client/test_base_client.py

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -162,39 +162,6 @@ async def test_send_message_callsite_config_overrides_history_length_non_streami
162162
)
163163

164164

165-
@pytest.mark.asyncio
166-
async def test_send_message_ignores_none_fields_in_callsite_configuration_non_streaming(
167-
base_client: BaseClient, mock_transport: MagicMock, sample_message: Message
168-
):
169-
base_client._config.streaming = False
170-
mock_transport.send_message.return_value = Task(
171-
id='task-cfg-ns-2',
172-
context_id='ctx-cfg-ns-2',
173-
status=TaskStatus(state=TaskState.completed),
174-
)
175-
176-
cfg = MessageSendConfiguration(history_length=None, blocking=None)
177-
events = [
178-
event
179-
async for event in base_client.send_message(
180-
sample_message, configuration=cfg
181-
)
182-
]
183-
184-
mock_transport.send_message.assert_called_once()
185-
assert len(events) == 1
186-
task, _ = events[0]
187-
assert task.id == 'task-cfg-ns-2'
188-
189-
params = mock_transport.send_message.await_args.args[0]
190-
assert params.configuration.history_length is None
191-
assert params.configuration.blocking == (not base_client._config.polling)
192-
assert (
193-
params.configuration.accepted_output_modes
194-
== base_client._config.accepted_output_modes
195-
)
196-
197-
198165
@pytest.mark.asyncio
199166
async def test_send_message_callsite_config_overrides_history_length_streaming(
200167
base_client: BaseClient, mock_transport: MagicMock, sample_message: Message

0 commit comments

Comments
 (0)