Commit 2e8fbc4
authored
fix: Add validation for transport types in
### Description
This update introduces upfront validation for transport protocols within
the `ClientFactory`. Previously, if an invalid or misspelled transport
type was provided in the `ClientConfig`, it would be silently ignored.
This could lead to confusing `ValueError('no compatible transports
found.')` errors later on, making it difficult to debug
misconfigurations.
### Changes
* **`src/a2a/client/client_factory.py`**: Added a validation loop at the
beginning of the `create` method to check all transport types provided
in the `ClientConfig`.
* **`tests/client/test_client_factory.py`**: Added a new unit test,
`test_client_factory_invalid_transport_in_config`, to confirm that a
`ValueError` is raised when an invalid transport string is used.ClientFactory (#396)1 parent a96df5c commit 2e8fbc4
File tree
2 files changed
+44
-1
lines changed- src/a2a/client
- tests/client
2 files changed
+44
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
127 | 141 | | |
128 | 142 | | |
129 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
0 commit comments